Skip to content

๐Ÿ›ก๏ธ Sentinel: [MEDIUM] Fix missing input validation in exported functions - #76

Closed
seonghobae wants to merge 1 commit into
masterfrom
sentinel-input-validation-9383857040763345887
Closed

๐Ÿ›ก๏ธ Sentinel: [MEDIUM] Fix missing input validation in exported functions#76
seonghobae wants to merge 1 commit into
masterfrom
sentinel-input-validation-9383857040763345887

Conversation

@seonghobae

Copy link
Copy Markdown
Collaborator

๐Ÿšจ Severity: MEDIUM
๐Ÿ’ก Vulnerability: Unvalidated arguments passed to exported functions could bypass top-level stop(..., call. = FALSE) safeguards and trigger raw R errors deep inside internal logic, leaking internal execution contexts.
๐ŸŽฏ Impact: This could lead to information disclosure by exposing internal execution details and call stacks.
๐Ÿ”ง Fix: Added strict input validation for the nested, adj, and conf.level arguments at the beginning of the vuongtest and icci exported functions. conf.level is now checked to be a single numeric value between 0 and 1. nested is checked to be a single logical value. adj is checked using match.arg.
โœ… Verification: Ran the package test suite locally.


PR created automatically by Jules for task 9383857040763345887 started by @seonghobae

Added strict input validation for the `nested`, `adj`, and `conf.level` arguments at the beginning of the `vuongtest` and `icci` exported functions. `conf.level` is now checked to be a single numeric value between 0 and 1. `nested` is checked to be a single logical value. `adj` is checked using `match.arg`. This prevents unvalidated arguments from bypassing top-level safeguards and triggering raw R errors deep inside internal logic, which could leak internal execution contexts.
@google-labs-jules

Copy link
Copy Markdown

๐Ÿ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a ๐Ÿ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 6 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
โš™๏ธ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 85f93b86-5087-46db-961f-7cd108ecb608

๐Ÿ“ฅ Commits

Reviewing files that changed from the base of the PR and between 2116b0d and 3341b80.

๐Ÿ“’ Files selected for processing (3)
  • .jules/sentinel.md
  • R/icci.R
  • R/vuongtest.R

Comment @coderabbitai help to get the list of available commands.

@opencode-agent opencode-agent Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

OpenCode cannot approve yet because required coverage evidence did not pass.

Review outcome

1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence

  • Problem: The required coverage-evidence job result was failure, so OpenCode cannot establish approval sufficiency for this head.

  • Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.

  • Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports success with required evidence or explicit no-source not-applicable evidence.

  • Regression test: Keep the approval branch checking needs.coverage-evidence.result == success before posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present.

  • Result: REQUEST_CHANGES

  • Reason: coverage-evidence result was failure, so required test/docstring evidence was not proven for current head 3341b80df404089fbc96f055b7135ca148b3bc6c.

  • Head SHA: 3341b80df404089fbc96f055b7135ca148b3bc6c

  • Workflow run: 31153436618

  • Workflow attempt: 1

Coverage evidence

Coverage Decision

  • Result: FAIL
  • Test evidence: not proven passing
  • Docstring evidence: not proven passing when configured
  • Failure count: 1

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Changed file (3 files)"]
  S1 --> I1["repository behavior"]
  I1 --> R1["Review risk: Changed file (3 files)"]
  R1 --> V1["required checks"]
Loading

@opencode-agent

opencode-agent Bot commented Aug 7, 2026

Copy link
Copy Markdown

OpenCode Review Overview

  • Head SHA: 3341b80df404089fbc96f055b7135ca148b3bc6c
  • Workflow run: 31153436618
  • Workflow attempt: 1
  • Gate result: REQUEST_CHANGES (approval step)

Pull request overview

OpenCode cannot approve yet because required coverage evidence did not pass.

Review outcome

1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence

  • Problem: The required coverage-evidence job result was failure, so OpenCode cannot establish approval sufficiency for this head.

  • Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.

  • Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports success with required evidence or explicit no-source not-applicable evidence.

  • Regression test: Keep the approval branch checking needs.coverage-evidence.result == success before posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present.

  • Result: REQUEST_CHANGES

  • Reason: coverage-evidence result was failure, so required test/docstring evidence was not proven for current head 3341b80df404089fbc96f055b7135ca148b3bc6c.

  • Head SHA: 3341b80df404089fbc96f055b7135ca148b3bc6c

  • Workflow run: 31153436618

  • Workflow attempt: 1

Coverage evidence

Coverage Decision

  • Result: FAIL
  • Test evidence: not proven passing
  • Docstring evidence: not proven passing when configured
  • Failure count: 1

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Changed file (3 files)"]
  S1 --> I1["repository behavior"]
  I1 --> R1["Review risk: Changed file (3 files)"]
  R1 --> V1["required checks"]
Loading

Copy link
Copy Markdown
Collaborator Author

Closing as superseded by #71. Both PRs address the same icci() / vuongtest() input-validation gap, but #71 carries dedicated regression tests for the invalid-input/error-call contract and is now the single canonical repair branch. This PR has no regression-test changes and also changes the adj formal default to a choice vector for match.arg(), which is unnecessary to resolve the finding and creates avoidable API-semantics risk. Consolidating on #71 avoids competing writers and duplicate security fixes.

@seonghobae seonghobae closed this Aug 8, 2026
@google-labs-jules

Copy link
Copy Markdown

Closing as superseded by #71. Both PRs address the same icci() / vuongtest() input-validation gap, but #71 carries dedicated regression tests for the invalid-input/error-call contract and is now the single canonical repair branch. This PR has no regression-test changes and also changes the adj formal default to a choice vector for match.arg(), which is unnecessary to resolve the finding and creates avoidable API-semantics risk. Consolidating on #71 avoids competing writers and duplicate security fixes.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant