Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion services/account_unification/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ dependencies = [
"pydantic==2.13.4",
"httpx==0.28.1",
"pyyaml==6.0.3",
"uvicorn==0.52.3",
"uvicorn==0.52.4",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Lock files still pin the old uvicorn version

The manifest now requires uvicorn==0.52.4 but uv.lock (services/account_unification/uv.lock:379) and requirements.lock (services/account_unification/requirements.lock:367) still pin 0.52.3. The uv sync --locked CI step fails on this mismatch.

Prompt for agents
The uvicorn bump to 0.52.4 was applied to pyproject.toml and requirements-dev.txt, but the pinned lock files were not regenerated. services/account_unification/uv.lock still contains `{ name = "uvicorn", specifier = "==0.52.3" }` (line 379) plus the corresponding [[package]] entry with old sdist/wheel hashes, and services/account_unification/requirements.lock line 367 still lists `uvicorn==0.52.3` with old hashes. CI runs `uv sync --locked` which requires uv.lock to be consistent with pyproject.toml, so this mismatch will fail the build. Regenerate both lock files (e.g. `uv lock` / the tool that produces requirements.lock) so uvicorn is pinned to 0.52.4 with the correct hashes across all four files.
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Info: CHANGELOG untouched for dependency bump

AGENTS.md asks for CHANGELOG.md updates on behavior changes. This dependency-only bump likely does not qualify, so it is noted rather than flagged.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

]

[project.optional-dependencies]
Expand Down
6 changes: 3 additions & 3 deletions services/account_unification/requirements-dev.txt
Original file line number Diff line number Diff line change
Expand Up @@ -556,7 +556,7 @@ typing-inspection==0.4.4 \
# via
# fastapi
# pydantic
uvicorn==0.52.3 \
--hash=sha256:116af2710dbf47c80f463cd20ee4884b6662f4c9f227d797ddc7279d2fcc2c7c \
--hash=sha256:18857b9e6579300be55c91c0a1cfd37d9a2cf0cabea33b88275f199eb73b8b58
uvicorn==0.52.4 \
--hash=sha256:73acfee47a0b133c5de13d219492d62d8a31e935f4fe6e41a232451a15379f86 \
--hash=sha256:f86e41a149d7d05a9969337e3946a9c171c06a5d42680896daaba624aeac8da1
# via cwl-idp-account-unification
Loading