Skip to content

fix(reliability): preflight Blob size before conversion reads #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
seonghobae wants to merge 1 commit into from
Closed

fix(reliability): preflight Blob size before conversion reads #180

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions src/converter/blobSizePreflight.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
import { describe, expect, it, vi } from 'vitest';

import { Base64SizeError, blobToDataUri } from './index.js';

describe('Blob conversion resource preflight', () => {
it('rejects a known oversized Blob before reading its payload bytes', async () => {
const blob = new Blob([new Uint8Array(32)], { type: 'application/octet-stream' });
const read = vi.fn(async () => new Uint8Array(32).buffer);
Object.defineProperty(blob, 'arrayBuffer', {
configurable: true,
value: read,
});

await expect(blobToDataUri(blob, { maxBytes: 4 })).rejects.toMatchObject({
name: 'Base64SizeError',
bytes: 32,
maxBytes: 4,
} satisfies Partial<Base64SizeError>);
expect(read).not.toHaveBeenCalled();

Check failure on line 19 in src/converter/blobSizePreflight.test.ts

View workflow job for this annotation

GitHub Actions / build-and-test

src/converter/blobSizePreflight.test.ts > Blob conversion resource preflight > rejects a known oversized Blob before reading its payload bytes 

AssertionError: expected "spy" to not be called at all, but actually been called 1 times

Received: 

  1st spy call:

    Array []


Number of calls: 1

 ❯ src/converter/blobSizePreflight.test.ts:19:22
});
});
Loading