Skip to content

🎨 Palette: ν‚€λ³΄λ“œ 포컀슀 κ°€μ‹œμ„± κ°œμ„  (focus-visible) - #1256

Closed
seonghobae wants to merge 1 commit into
mainfrom
palette/css-focus-visible-17371512451611161829
Closed

🎨 Palette: ν‚€λ³΄λ“œ 포컀슀 κ°€μ‹œμ„± κ°œμ„  (focus-visible)#1256
seonghobae wants to merge 1 commit into
mainfrom
palette/css-focus-visible-17371512451611161829

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

πŸ’‘ What (무엇을 λ³€κ²½ν–ˆλ‚˜μš”?)
HTML λ³΄κ³ μ„œλ₯Ό μƒμ„±ν•˜λŠ” python/fast_mlsirm/report.py λ‚΄λΆ€μ˜ CSS ν…œν”Œλ¦Ώμ—μ„œ <main>, .table-wrap, .export-block pre μš”μ†Œμ— ν• λ‹Ήλ˜μ–΄ 있던 λ²”μš© :focus { outline: none; } μŠ€νƒ€μΌμ„ :focus:not(:focus-visible) { outline: none; }둜 λ³€κ²½ν–ˆμŠ΅λ‹ˆλ‹€.

🎯 Why (μ™œ λ³€κ²½ν–ˆλ‚˜μš”?)
κΈ°μ‘΄ 방식(:focus { outline: none; })은 마우슀 클릭 μ‹œ μƒκΈ°λŠ” κ±°μŠ¬λ¦¬λŠ” λΈŒλΌμš°μ € κΈ°λ³Έ 포컀슀 링을 μ—†μ• μ£Όμ§€λ§Œ, ν‚€λ³΄λ“œ(Tab ν‚€ λ“±)λ₯Ό μ΄μš©ν•˜μ—¬ νŽ˜μ΄μ§€λ₯Ό νƒμƒ‰ν•˜λŠ” μ‚¬μš©μžλ“€μ˜ 포컀슀 μ§€ν‘œκΉŒμ§€ μ™„μ „νžˆ μ§€μ›Œλ²„λ € μ‹¬κ°ν•œ μ›Ή μ ‘κ·Όμ„±(a11y) 문제λ₯Ό μΌμœΌν‚΅λ‹ˆλ‹€. 이λ₯Ό ν•΄κ²°ν•˜μ—¬ 마우슀 μ‚¬μš©μžμ˜ μ‹œκ°μ  κ²½ν—˜μ„ μœ μ§€ν•˜λ©΄μ„œλ„ ν‚€λ³΄λ“œ μ‚¬μš©μžμ—κ²Œ μ˜¬λ°”λ₯Έ 포컀슀 인디케이터λ₯Ό μ œκ³΅ν•˜κΈ° μœ„ν•¨μž…λ‹ˆλ‹€.

πŸ“Έ Before/After

  • Before: .table-wrap (슀크둀이 μžˆλŠ” ν…Œμ΄λΈ” μ»¨ν…Œμ΄λ„ˆ) 등을 ν‚€λ³΄λ“œλ‘œ ν¬μ»€μŠ€ν•  λ•Œ μ•„λ¬΄λŸ° μ‹œκ°μ  ν”Όλ“œλ°±μ΄ μ—†μ–΄ μ‚¬μš©μžκ°€ ν˜„μž¬ μœ„μΉ˜λ₯Ό μ•Œ 수 μ—†μŒ.
  • After: 마우슀 클릭 μ‹œμ—λŠ” 포컀슀 링이 μ—†μ§€λ§Œ, ν‚€λ³΄λ“œ 포컀슀 μ§„μž… μ‹œμ—λŠ” κΈ°λ³Έ μœ€κ³½μ„ μ΄ λ‚˜νƒ€λ‚˜λ©° :focus-visible μ»€μŠ€ν…€ μŠ€νƒ€μΌ(ν…ŒμΌ 컬러 μœ€κ³½μ„ )이 μ •μƒμ μœΌλ‘œ λ Œλ”λ§λ¨.

β™Ώ Accessibility (μ ‘κ·Όμ„±)

  • 마우슀 μ‚¬μš©μžμ˜ λ°©ν•΄μš”μ†Œλ₯Ό 쀄이기 μœ„ν•œ μ˜λ„λ‘œ μΆ”κ°€λœ CSSκ°€ ν‚€λ³΄λ“œ μ „μš© μ‚¬μš©μž(Screen reader μ‚¬μš©μž 포함)의 포컀슀 인지 λŠ₯λ ₯을 λ°•νƒˆν•˜λ˜ 문제λ₯Ό μˆ˜μ •ν–ˆμŠ΅λ‹ˆλ‹€. (이슈 기반: Palette's Journal: Focus Visible For Scrollable Tables)

PR created automatically by Jules for task 17371512451611161829 started by @seonghobae


Open in Devin Review

`fast_mlsirm/report.py`에 μƒμ„±λ˜λŠ” HTML 리포트의 접근성을 ν–₯μƒν•˜κΈ° μœ„ν•΄, 슀크둀 κ°€λŠ₯ν•œ μš”μ†Œμ™€ 메인 μ»¨ν…Œμ΄λ„ˆμ— 적용된 `outline: none` μŠ€νƒ€μΌμ„ `:focus:not(:focus-visible)`둜 λ³€κ²½ν–ˆμŠ΅λ‹ˆλ‹€.
이둜 인해 마우슀 클릭 μ‹œμ—λŠ” 포컀슀 링이 보이지 μ•Šμ•„ μ‹œκ°μ  깔끔함을 μœ μ§€ν•˜λ©΄μ„œλ„, ν‚€λ³΄λ“œ λ„€λΉ„κ²Œμ΄μ…˜ μ‹œμ—λŠ” 포컀슀 κ°€μ‹œμ„±(`:focus-visible`)을 μ§€μ›ν•˜κ²Œ λ˜μ–΄ 슀크린 리더 및 ν‚€λ³΄λ“œ μ‚¬μš©μžμ˜ 접근성이 κ°œμ„ λ˜μ—ˆμŠ΅λ‹ˆλ‹€.

κ΄€λ ¨ ν…ŒμŠ€νŠΈ 검증 μ½”λ“œλ₯Ό μ—…λ°μ΄νŠΈν•˜μ˜€μŠ΅λ‹ˆλ‹€.
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 43 minutes

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
βš™οΈ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 7b7cee8e-c217-4b6a-ad78-1d62a9c474ce

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between 04d0bc2 and 7fceaf5.

πŸ“’ Files selected for processing (2)
  • python/fast_mlsirm/report.py
  • tests/test_report.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❀️ Share

Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

βœ… Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

Copy link
Copy Markdown
Contributor Author

Closing as a proven duplicate of the existing single-writer diagnostics-report accessibility lane in #1002. Fresh patch comparison shows this PR's entire production change (main, .table-wrap, and export <pre> from blanket :focus suppression to :focus:not(:focus-visible)) and its table regression are already present in #1002, which additionally covers disclosure <summary> focus and the report-title trust boundary. Keeping both open would create competing writers on the same report.py/focus contract. No source from #1256 needs separate integration.

@seonghobae seonghobae closed this Aug 22, 2026
@google-labs-jules

Copy link
Copy Markdown

Closing as a proven duplicate of the existing single-writer diagnostics-report accessibility lane in #1002. Fresh patch comparison shows this PR's entire production change (main, .table-wrap, and export <pre> from blanket :focus suppression to :focus:not(:focus-visible)) and its table regression are already present in #1002, which additionally covers disclosure <summary> focus and the report-title trust boundary. Keeping both open would create competing writers on the same report.py/focus contract. No source from #1256 needs separate integration.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant