build(rust): raise DiskSage compiler baseline to 1.97.1 - #244
build(rust): raise DiskSage compiler baseline to 1.97.1#244seonghobae wants to merge 21 commits into
Conversation
|
Warning Review limit reachedNext included review available in 38 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthrough프로젝트의 Rust 컴파일러 기준을 1.97.1로 통일했습니다. 로컬 툴체인, Cargo, CI, Dependabot 설정과 계약 테스트를 갱신했습니다. ChangesRust 툴체인 업그레이드
Estimated code review effort: 3 (Moderate) | ~25 minutes Merge Risk: 🟡 Moderate · up to This PR raises DiskSage’s Rust compiler baseline to 1.97.1 and changes CI and release compiler selection. The exact-head Test, Release, Security Scan, and SAST checks are still queued and non-passing, so merge should wait until those required validations complete. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
The exact-head checks are green at |
|
The exact-head source and all required checks are green at |
|
Reviewed exact current head |
|
Validated the latest Devin concern against current GitHub documentation: |
GitHub Dependabot does not recognize "rust-toolchain" as a package-ecosystem value (see the supported-ecosystems docs); an unrecognized value fails schema validation for the whole config file, which would have silently disabled the existing github-actions, npm, and cargo update jobs too. Drop the entry, update the compiler-updates contract test to guard against reintroducing it and instead verify the real cargo/github-actions ecosystems stay configured, and correct the changelog line that claimed rust-toolchain.toml tracking through Dependabot. Addresses a reviewer finding on PR #244. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
OpenCode current-head evidence (2026-08-24):
The PR remains draft/blocked with required review and hosted checks pending; no merge claimed. |
|
The PR is now marked ready for review at exact HEAD |
|
Exact current head Local pinned evidence: The non-doc full matrix was intentionally stopped after a long per-helper rebuild; no merge/readiness claim. Hosted checks and independent approvals remain required. |
|
Current-head Strix failure is provider infrastructure, not a source finding. Job 97338769912 for HEAD |
|
Follow-up: both |
|
Hosted failure classification: Strix is provider-gated and remains separate from source correctness; no source mutation made. Keep the documented provider retry path and protected review requirements. |
Problem
DiskSage declared Rust
1.88in its Tauri package while test and release workflows relied on a floating stable compiler. That made the application compiler baseline old and non-reproducible.Exact current state
main:7eb131c4b4ac628226b262d6406a663fc7dc632f13caeb04333e50e57c8a51a11b64aeb131c080b2Changes
rust-toolchain.tomlpinned to Rust1.97.1rust-versionto1.97.1cargoandgithub-actionstracking; no unsupportedrust-toolchainecosystem is declaredCurrent review repair
The structured contract reader previously accepted required YAML keys at arbitrary descendant depth. A malicious or accidental nested
with.nested.toolchain, nested Dependabotmetadata.directory, orschedule.nested.intervalcould therefore satisfy a governance test even though the actual direct mapping was wrong.The current head was repaired test-first:
withandtoolchainkeys must now be immediate children at the expected indentation;directoryandopen-pull-requests-limitmust now be direct update-item fields;schedule.intervalmust be an immediate child of the directschedulemapping;Pinned Rust 1.97.1 local documentation tests pass on this exact head; the full hosted exact-head Test, coverage, security, and independent review gates remain required.
Evidence contract
The exact-head Test must prove Tauri/Rust tests, cloud/archive CLI proofs, embedded llama.cpp CPU build, frontend tests/build, and compiler contract tests under the pinned compiler. Release must independently prove packaging from the same exact source without relying on restored Rust target artifacts. Security/SAST and every applicable central workflow must also be current.
This intentionally raises DiskSage's application MSRV from 1.88 to 1.97.1. DiskSage is
publish = false, so it does not alter a public crate compatibility promise. No storage, cloud, authorization, model, UI, or data semantics are intentionally changed.Required before merge
Keep Draft until the unchanged exact head satisfies every live required workflow, zero valid unresolved findings, fresh protected-main ancestry, actual review governance, and repository-wide exact 100% owned-production region/statement-equivalent, branch, function, and line coverage without exclusions or threshold weakening. Pending, queued, skipped-required, failed, stale, predecessor, synthetic, diagnostic-only, status-only, model-only, author-only, or no-source evidence is non-passing.
Summary by CodeRabbit
개선 사항
테스트