fix: make incomplete-download execution help successful and bounded - #219
Closed
seonghobae wants to merge 1 commit into
Closed
fix: make incomplete-download execution help successful and bounded#219seonghobae wants to merge 1 commit into
seonghobae wants to merge 1 commit into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Advance #210 with one non-conflicting execution CLI: require
disksage-incomplete-download-materializeto treat a sole--help/-has a successful terminal action, while preserving fail-closed execution semantics and preventing opaque option payloads from being reflected in diagnostics.Exact test-first state
main:be418bac9bfbdc8aa41b1a698713833e3dbccfdc.549c37ed508cfb3f2a6509a757744a0b382226c8.src-tauri/tests/cli_help_materialize_exec_exit.rs.--locked --features cloud-cliinto an isolated target directory before process assertions.The regression requires:
--helpand-h=> exit 0, stable usage on stdout, empty stderr;--helpmixed with that invalid option => still non-zero and bounded.Protected main currently routes help through
Err(usage()), projects it via stderr/exit 2, and interpolates unknown argument text. No production fix or GREEN result is claimed before this exact test-only head proves a realistic RED rather than setup/build failure.Intended narrow remedy
Handle only a sole help flag as a successful terminal request before destination-plan, HOME/cloud-root, capacity, audit, recovery, approval, or materialization execution. Replace raw unknown-option reflection with a stable bounded diagnostic. Mixed help/invalid input must remain an error. Preserve explicit
--execute, human attribution/rationale, fingerprint confirmation, capacity admission, create-new private receipts, path safety, recovery validation, and all existing limits.Ownership / non-duplication
Fresh exact-path search found no open PR owning
src-tauri/src/bin/disksage-incomplete-download-materialize.rs. #218 owns the distinct materialization-planning and recovery CLIs; #217 owns eviction and destination-plan CLIs; #156 owns repository-wide exact coverage; #149 owns canonical acquisition documentation. This line does not race those owners.Required before Ready / merge
Keep Draft until realistic exact-head RED -> narrow GREEN is proven, every applicable native and live required workflow passes on the unchanged implementation head, every valid current-head finding is addressed, live-base ancestry remains current, and repository-wide exact 100% owned-production statement/branch/function/line coverage is satisfied without exclusions or threshold weakening. Pending, queued, skipped-required, neutral-required, failed, stale, predecessor, synthetic, diagnostic-only, status-only, model-only, rate-limited, or infrastructure-only evidence is not passing.