Skip to content

fix: make provider runtime help successful and bounded - #216

Open
seonghobae wants to merge 65 commits into
mainfrom
fix/provider-client-runtime-help-v1
Open

fix: make provider runtime help successful and bounded#216
seonghobae wants to merge 65 commits into
mainfrom
fix/provider-client-runtime-help-v1

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Purpose

Advance #210 with bounded operational CLI contracts for disksage-provider-client-runtime and disksage-cloud-local-inventory: terminal help succeeds before environment/domain work, malformed host input stays bounded, invalid cloud-inventory resource limits fail closed before provider discovery, coverage instrumentation exercises shipped runtime behavior, and provider-runtime audit publication rejects unsafe output authority.

Exact current state

  • exact source head: 1ba878885dc08296d21f23ac0a43301381449f85;
  • independently resolved live main: 7eb131c4b4ac628226b262d6406a663fc7dc632f;
  • PR remains Draft; mechanical mergeability is not merge authorization;
  • exact-head Test 32695963790, Release 32695963785, Security Scan 32695963784, and SAST Semgrep 32695963805 are queued/in progress and therefore non-passing;
  • predecessor checks/reviews never transfer to this changed head.

Current executable evidence increment

The Unix provider-runtime real-binary contract now proves the output leaf object cannot redirect create-new publication. A private parent contains a symlink provider-runtime.json targeting an external sentinel file; the shipped feature-gated CLI must exit 2 with the stable provider-client-runtime-output-create-failed diagnostic, emit no success JSON, leave the external target byte-identical, and leave the symlink leaf intact. This complements the existing parent/ancestor authority regressions without pretending to solve the separately owned same-user directory-replacement problem in #194/#187/#228.

Existing bounded contracts retained

  • sole --help / -h is successful and terminal before HOME/provider/filesystem work;
  • invalid, mixed-help, duplicate, missing-value, unsafe-path, and non-UTF-8 option-shaped inputs remain bounded;
  • provider-runtime native output paths remain OsString/PathBuf values rather than being forced through UTF-8;
  • provider-runtime publication is create-new and Unix mode 0600, with parent/ancestor authority revalidated immediately before file creation;
  • cloud-local-inventory limits are overflow-safe and bounded, with synthetic read-only success and symlink/non-directory relative-subpath escape rejection;
  • historical #[cfg(coverage)] no-op entrypoints remain removed so coverage builds execute shipped parser/runtime behavior.

Stale convergence / ownership

This branch was non-destructively converged onto live-main lineage before the current test increment. Its semantic owner remains the two operational binaries and their focused process/coverage tests. It does not absorb #247 provider/cloud follow-up semantics, #227 symlink-root authority, #249 Git-worktree CLI ownership, #156 repository-wide coverage ownership, or #149 canonical documentation.

Required before merge

Keep Draft until one unchanged exact head satisfies every applicable live Test/Release/Security/SAST and central gate, zero valid unresolved findings, fresh live-base ancestry, actual review governance, repository-wide exact non-vacuous 100% owned-production coverage without exclusions or threshold weakening, package/SBOM/provenance requirements, and effective enforceable main governance. Pending, queued, skipped-required, cancelled, failed, stale, predecessor, synthetic, diagnostic-only, status-only, model-only, author-only, no-source, or infrastructure-only evidence is non-passing.

@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

Next included review available in 34 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d59dbe51-7414-4c16-abe5-0f8b122dcf41

📥 Commits

Reviewing files that changed from the base of the PR and between b02150e and f8877d3.

📒 Files selected for processing (14)
  • .github/scripts/verify-release-artifacts.sh
  • .github/workflows/release.yml
  • src-tauri/src/bin/disksage-cloud-local-inventory.rs
  • src-tauri/src/bin/disksage-provider-client-runtime.rs
  • src-tauri/tests/cloud_local_inventory_cli_admission.rs
  • src-tauri/tests/cloud_local_inventory_coverage_semantics.rs
  • src-tauri/tests/cloud_local_inventory_help_exit.rs
  • src-tauri/tests/cloud_local_inventory_option_bounds.rs
  • src-tauri/tests/cloud_local_inventory_relative_subpath_process.rs
  • src-tauri/tests/provider_client_runtime_coverage_semantics.rs
  • src-tauri/tests/provider_client_runtime_help_exit.rs
  • src-tauri/tests/provider_client_runtime_native_output_path.rs
  • src/lib/releaseArtifactVerifierDirectoryContract.test.ts
  • src/lib/releaseTagArtifactVerifierContract.test.ts

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 505dabaa-624a-40ce-90ff-0d7a83e5e02b

📥 Commits

Reviewing files that changed from the base of the PR and between be418ba and b02150e.

📒 Files selected for processing (4)
  • src-tauri/src/bin/disksage-cloud-local-inventory.rs
  • src-tauri/src/bin/disksage-provider-client-runtime.rs
  • src-tauri/tests/cloud_local_inventory_help_exit.rs
  • src-tauri/tests/provider_client_runtime_help_exit.rs

📝 Walkthrough

Walkthrough

두 CLI 바이너리가 단독 --help-h를 성공 처리합니다. 알 수 없는 인자는 고정된 오류를 반환하고 입력값을 노출하지 않습니다. 각 바이너리에 프로세스 수준 통합 테스트를 추가했습니다.

Changes

CLI 인자 처리 계약

Layer / File(s) Summary
클라우드 로컬 인벤토리 CLI 처리
src-tauri/src/bin/disksage-cloud-local-inventory.rs, src-tauri/tests/cloud_local_inventory_help_exit.rs
단독 도움말 인자는 사용법을 표준 출력에 표시하고 성공 종료합니다. 알 수 없는 인자와 혼합 인자는 실패 종료하며 표준 오류에 고정 오류를 표시합니다. 테스트는 종료 상태와 stdout/stderr 내용을 검증합니다.
Provider client-runtime CLI 처리
src-tauri/src/bin/disksage-provider-client-runtime.rs, src-tauri/tests/provider_client_runtime_help_exit.rs
usage 함수로 사용법 문자열을 통합합니다. 단독 도움말 인자는 성공 처리하고, 알 수 없는 인자는 입력값을 제외한 오류를 반환합니다. 테스트는 도움말, 알 수 없는 인자, 혼합 인자 시나리오를 검증합니다.

Estimated code review effort: 2 (Simple) | ~10 minutes

Mergeability Score: ⚪ Minimal · up to b0215

The change is localized and no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 제목은 provider runtime의 도움말 성공 처리와 제한된 오류 메시지라는 주요 변경 사항을 간결하게 설명합니다.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/provider-client-runtime-help-v1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae marked this pull request as ready for review August 14, 2026 02:06

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown
⚠️ Action not completed

Already reviewed.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@seonghobae

Copy link
Copy Markdown
Contributor Author

@OpenCode review current head 1f2def5 (fix non-UTF-8 CLI argument panic in both sibling binaries)

@opencode-agent opencode-agent Bot added priority: medium Normal-priority or P2 work status: draft Draft pull request type: bug Defect or incorrect behavior labels Aug 22, 2026
@seonghobae
seonghobae marked this pull request as ready for review August 24, 2026 05:28
devin-ai-integration[bot]

This comment was marked as resolved.

@seonghobae
seonghobae marked this pull request as draft August 24, 2026 05:33
@seonghobae

Copy link
Copy Markdown
Contributor Author

Hosted failure classification: the macOS Release job built and signed the artifacts, then failed in actions/upload-artifact with ENOTFOUND while creating the artifact. This is runner-to-GitHub endpoint resolution, not a source/build failure; no source mutation made. Re-run remains the appropriate remediation under protected gates.

@seonghobae

Copy link
Copy Markdown
Contributor Author

Exact-head release rerun completed successfully at run 32709525283. macOS, Windows, and Ubuntu build jobs all passed; GPU, attestation, and publish remained intentionally skipped by workflow conditions. The earlier macOS artifact ENOTFOUND was transient runner/network evidence and was not worked around. Protected approvals and the draft/stacked PR gate remain unchanged.

@seonghobae
seonghobae marked this pull request as ready for review August 25, 2026 20:43
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@seonghobae
seonghobae enabled auto-merge (squash) August 25, 2026 21:18

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

Open in Devin Review

Comment thread .github/scripts/verify-release-artifacts.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: medium Normal-priority or P2 work status: draft Draft pull request type: bug Defect or incorrect behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant