fix: make provider runtime help successful and bounded - #216
Conversation
|
Warning Review limit reachedNext included review available in 34 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (14)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthrough두 CLI 바이너리가 단독 ChangesCLI 인자 처리 계약
Estimated code review effort: 2 (Simple) | ~10 minutes Mergeability Score: ⚪ Minimal · up to The change is localized and no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
|
|
Hosted failure classification: the macOS Release job built and signed the artifacts, then failed in actions/upload-artifact with |
|
Exact-head release rerun completed successfully at run 32709525283. macOS, Windows, and Ubuntu build jobs all passed; GPU, attestation, and publish remained intentionally skipped by workflow conditions. The earlier macOS artifact |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
…espace-v1' into HEAD
Purpose
Advance #210 with bounded operational CLI contracts for
disksage-provider-client-runtimeanddisksage-cloud-local-inventory: terminal help succeeds before environment/domain work, malformed host input stays bounded, invalid cloud-inventory resource limits fail closed before provider discovery, coverage instrumentation exercises shipped runtime behavior, and provider-runtime audit publication rejects unsafe output authority.Exact current state
1ba878885dc08296d21f23ac0a43301381449f85;main:7eb131c4b4ac628226b262d6406a663fc7dc632f;32695963790, Release32695963785, Security Scan32695963784, and SAST Semgrep32695963805are queued/in progress and therefore non-passing;Current executable evidence increment
The Unix provider-runtime real-binary contract now proves the output leaf object cannot redirect create-new publication. A private parent contains a symlink
provider-runtime.jsontargeting an external sentinel file; the shipped feature-gated CLI must exit 2 with the stableprovider-client-runtime-output-create-faileddiagnostic, emit no success JSON, leave the external target byte-identical, and leave the symlink leaf intact. This complements the existing parent/ancestor authority regressions without pretending to solve the separately owned same-user directory-replacement problem in #194/#187/#228.Existing bounded contracts retained
--help/-his successful and terminal before HOME/provider/filesystem work;OsString/PathBufvalues rather than being forced through UTF-8;0600, with parent/ancestor authority revalidated immediately before file creation;#[cfg(coverage)]no-op entrypoints remain removed so coverage builds execute shipped parser/runtime behavior.Stale convergence / ownership
This branch was non-destructively converged onto live-main lineage before the current test increment. Its semantic owner remains the two operational binaries and their focused process/coverage tests. It does not absorb #247 provider/cloud follow-up semantics, #227 symlink-root authority, #249 Git-worktree CLI ownership, #156 repository-wide coverage ownership, or #149 canonical documentation.
Required before merge
Keep Draft until one unchanged exact head satisfies every applicable live Test/Release/Security/SAST and central gate, zero valid unresolved findings, fresh live-base ancestry, actual review governance, repository-wide exact non-vacuous 100% owned-production coverage without exclusions or threshold weakening, package/SBOM/provenance requirements, and effective enforceable main governance. Pending, queued, skipped-required, cancelled, failed, stale, predecessor, synthetic, diagnostic-only, status-only, model-only, author-only, no-source, or infrastructure-only evidence is non-passing.