fix: make audit CLI help successful and bounded

[seonghobae]

Purpose

Advance issue #210 with one bounded audit-oriented CLI batch: make disksage-multipart-archive-audit and disksage-incomplete-download-audit expose a sole --help / -h as a successful terminal action while keeping invalid input non-zero and preventing opaque argument payloads from being reflected in diagnostics.

Exact current state

• Exact source head: b1bfb158a88947a43a608163d625768fb197d615.
• Independently resolved live protected main: be418bac9bfbdc8aa41b1a698713833e3dbccfdc.
• Branch ancestry starts directly from that protected-main tip.
• Current semantic delta is exactly three files:
  • src-tauri/src/bin/disksage-incomplete-download-audit.rs;
  • src-tauri/src/bin/disksage-multipart-archive-audit.rs;
  • src-tauri/tests/cli_help_audit_batch_exit.rs.
• The PR is Ready for review, mergeable, with no submitted formal review and no current review thread.

Test-first history and RCA

• cb6b03c1b4aff843148bc85ab88f36b3233606c3 first added the process-level contract.
• The initial harness assumed feature-gated Cargo binaries were already available and failed before product semantics; that setup failure was not accepted as the intended RED.
• 9a8d67cd6e81bdce2ca241146db407236c261abf repaired the harness to build the real audit CLIs with the required feature set before launching them.
• The resulting process checks exercise the actual binaries and require sole --help / -h to exit 0 with stable usage on stdout and empty stderr; unknown and mixed help/invalid invocations remain non-zero and may not reflect an opaque payload.
• 3b0bffd26b770f99b7bf02bc0721c229e84e6627 implements the incomplete-download audit remedy.
• b1bfb158a88947a43a608163d625768fb197d615 implements the multipart-archive audit remedy.

Both production changes are deliberately narrow: only sole help becomes a successful terminal action and unknown-argument diagnostics become bounded. Existing audit limits, path admission, archive/incomplete-download inspection, private create-new evidence behavior, filesystem-read authority, and normal JSON stdout behavior remain unchanged.

Current exact-head validation

On unchanged exact head b1bfb158a88947a43a608163d625768fb197d615:

• Test 31739193059 — completed successfully;
• Release 31739193071 — completed successfully;
• Security Scan 31739193110 — completed successfully;
• SAST Semgrep 31739193141 — completed successfully.

A fresh @coderabbitai review request was issued on the unchanged exact head. CodeRabbit currently reports its review limit rather than a substantive review, finding, or approval. Rate-limited review evidence is not treated as passing.

Scope / non-duplication

This line owns only the two audit CLI implementations and their focused process contract. Repository-wide exact production coverage remains owned by #156 and canonical acquisition documentation by #149; neither lane is raced here. disksage-volume-snapshot is not included because protected main already models its help path as a successful terminal action with bounded unknown-argument behavior.

Required before merge

Do not merge unless the unchanged exact head satisfies every applicable live required workflow and current finding, all review threads are resolved, fresh live-base/ancestry evidence remains current, and repository-wide exact 100% owned-production statement/branch/function/line coverage is satisfied without exclusions or threshold weakening. Pending, queued, skipped-required, neutral-required, failed, stale, predecessor, synthetic, diagnostic-only, status-only, model-only, rate-limited, or infrastructure-only evidence is not passing.

---

[coderabbitai]

Warning

Review limit reached

Next included review available in 35 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: aae876c2-f7cc-458a-8b7a-751b649e1ed0

📥 Commits

Reviewing files that changed from the base of the PR and between 79067c1 and 7c54231.

📒 Files selected for processing (3)

• src-tauri/src/bin/disksage-incomplete-download-audit.rs
• src-tauri/src/bin/disksage-multipart-archive-audit.rs
• src-tauri/tests/cli_help_audit_batch_exit.rs

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[seonghobae]

@coderabbitai review

[coderabbitai]

⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[opencode-agent]

Pull request overview

OpenCode cannot approve yet because required coverage evidence did not pass.

Review outcome

1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence

• Problem: The required coverage-evidence job result was failure, so OpenCode cannot establish approval sufficiency for this head.

• Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.

• Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports success with required evidence or explicit no-source not-applicable evidence.

• Regression test: Keep the approval branch checking needs.coverage-evidence.result == success before posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present.

• Result: REQUEST_CHANGES

• Reason: coverage-evidence result was failure, so required test/docstring evidence was not proven for current head 05569ea9fe0cab608a37b268c78a81e047f5d991.

• Head SHA: 05569ea9fe0cab608a37b268c78a81e047f5d991

• Workflow run: 32148583820

• Workflow attempt: 1

Coverage evidence

Coverage Decision

• Result: FAIL
• Test evidence: not proven passing
• Docstring evidence: not proven passing when configured
• Failure count: 1

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Changed file (3 files)"]
  S1 --> I1["repository behavior"]
  I1 --> R1["Review risk: Changed file (3 files)"]
  R1 --> V1["required checks"]

Loading

[opencode-agent]

OpenCode Review Overview

• Head SHA: 05569ea9fe0cab608a37b268c78a81e047f5d991
• Workflow run: 32148583820
• Workflow attempt: 1
• Gate result: REQUEST_CHANGES (approval step)

Pull request overview

OpenCode cannot approve yet because required coverage evidence did not pass.

Review outcome

1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence

• Problem: The required coverage-evidence job result was failure, so OpenCode cannot establish approval sufficiency for this head.

• Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.

• Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports success with required evidence or explicit no-source not-applicable evidence.

• Regression test: Keep the approval branch checking needs.coverage-evidence.result == success before posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present.

• Result: REQUEST_CHANGES

• Reason: coverage-evidence result was failure, so required test/docstring evidence was not proven for current head 05569ea9fe0cab608a37b268c78a81e047f5d991.

• Head SHA: 05569ea9fe0cab608a37b268c78a81e047f5d991

• Workflow run: 32148583820

• Workflow attempt: 1

Coverage evidence

Coverage Decision

• Result: FAIL
• Test evidence: not proven passing
• Docstring evidence: not proven passing when configured
• Failure count: 1

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Changed file (3 files)"]
  S1 --> I1["repository behavior"]
  I1 --> R1["Review risk: Changed file (3 files)"]
  R1 --> V1["required checks"]

Loading

[devin-ai-integration]

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

[seonghobae]

Current head 931bdd0 has hosted checks green; any earlier CHANGES_REQUESTED review is stale. @OpenCode review current head 931bdd0 and publish fresh approval from exact-head evidence.

[seonghobae]

@OpenCode review current exact head 931bdd09d9a15de593d4e4e397296985a9316b01. The recorded REQUEST_CHANGES is bound to an older predecessor; current hosted checks report no failures. Re-run coverage/review evidence against this exact head only; do not transfer predecessor decisions.