fix: support standard Intel Homebrew executable target - #205
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
opencode-agent
Bot
added
priority: medium
|
The Intel Homebrew executable slice is ready for review at exact head |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
![opencode-agent[bot]](https://avatars.githubusercontent.com/in/1549082?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current head5c86668a6e503a174ff0b07151f67226b39547ff. -
Head SHA:
5c86668a6e503a174ff0b07151f67226b39547ff -
Workflow run: 32702639442
-
Workflow attempt: 1
Coverage evidence
Coverage Decision
- Result: FAIL
- Test evidence: not proven passing
- Docstring evidence: not proven passing when configured
- Failure count: 1
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (2 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (2 files)"]
R1 --> V1["required checks"]
OpenCode Review Overview
Pull request overviewOpenCode cannot approve yet because required coverage evidence did not pass. Review outcome1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
Coverage evidenceCoverage Decision
Changed-File Evidence Mapflowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (2 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (2 files)"]
R1 --> V1["required checks"]
|
1 participant
Purpose
Make the local-LLM-gated Homebrew cleanup available on a standard Intel macOS Homebrew installation without following or trusting the public
/usr/local/bin/brewalias symlink and without changing command, dry-run, model, human-approval, executable-identity, audit, or filesystem authority.Root cause
The official Homebrew installer uses
/usr/localas the Intel prefix, stores the repository at/usr/local/Homebrew, and creates/usr/local/bin/brewas../Homebrew/bin/brew. DiskSage rejected that public symlink alias while omitting the actual fixed repository target, so a standard Intel installation failed asbrew-cleanup-brew-not-foundbefore object-bound executable verification.Exact current state
8d1733849884bc517171e44065e1219568120e664432ea1aa12ccafd4774828f135898cd333f2d97src-tauri/src/brew_cleanup.rsplussrc-tauri/tests/brew_cleanup_intel_install_contract.rsPath::new("/usr/local/Homebrew/bin/brew"), placed before the rejected public alias32319948669and Release32319948682are queued; no passing evidence is transferred from predecessor4bda9d27...Test-first proof
The original RED process/contract evidence proved the standard Intel repository target was absent; the narrow production fix adds only that fixed target. Existing
symlink_metadata, executable-bit admission, symlink rejection, opened-file device/inode binding,/dev/fd/3execution, fixed arguments, plan fingerprinting, dry-run, model judgment, exact approval, and audit publication remain unchanged.The branch was advanced onto the current #187 dependency root with a non-forced merge commit. The current base-to-head diff proves protected-main package movement did not leak into this stack edge.
Stack / ownership
Dependency order is #187 durable audit authority → this Intel compatibility slice → #206 content-bound executable bytes. #206 has also been advanced onto this exact head and retains only its content-binding delta.
Required before merge
Keep Draft until the parent dependency is integrated or deliberately preserved; every applicable exact-head native and central workflow passes; every valid current-head finding is addressed; repository-wide exact 100% owned-production coverage is satisfied without weakening; package/SBOM/provenance/release requirements are complete where applicable; and fresh stack/base ancestry remains current. Pending, queued, absent-required, skipped-required, failed, stale, predecessor, synthetic, diagnostic-only, status-only, model-only, or author-only evidence is non-passing.