fix: bound cloud archive failure feedback - #200
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan includes up to 1 review per rolling hour; 0 remain after this review. 📝 WalkthroughWalkthrough
Changes클라우드 오류 개인정보 보호
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: 🟡 Moderate · up to This PR replaces raw cloud and filesystem exception text with bounded, operation-specific guidance, improving privacy and recovery without changing archive operations. The current head is not merge-ready because required validation is still queued or pending and the required independent approval is absent; a localized redundant-wording issue also remains for owner follow-up. Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Superseded by main: the bounded error-message boundary ( |
Purpose
Prevent arbitrary provider/filesystem exception text from crossing the CloudArchive desktop failure boundary and ensure every bounded failure message tells the customer what to check or do next, without changing cloud discovery, planning, review/tenant authority, copy/adoption, attestation, source-eviction authority, OAuth, capacity, persistence, or provider/filesystem mutation semantics.
Exact current state
44a548f3bf11dd89440bb1caf013be1b2d42567a.main:be418bac9bfbdc8aa41b1a698713833e3dbccfdc.src/lib/CloudArchive.svelteplussrc/lib/cloudArchiveErrorPrivacyContract.test.ts.Test-first privacy and next-action repair
e71e6e000ce9ffe43deb2ab05d7fed3b8edc503dadded the source contract while the component still projected arbitraryString(e)values into visible feedback.23034fec4f8c0c81dcdfa3621711d5a1fda8be87removed those projections across discovery, planning, review, copy/adoption, attestation, verified-source eviction, capacity verification, provider connect, and provider disconnect, and gave the dynamic failure regionrole="alert".5c359fab375cf42c76b52ae13fa7dcbbf84b81dbrequires operation-specific next actions and rejects unusedcatch (e)bindings.44a548f3bf11dd89440bb1caf013be1b2d42567achanges only those ten catch boundaries: each now usescatchand supplies path-free guidance to check the relevant root permissions, scan result, tenant attestation, remote capacity, provider connection, approval phrase, provider evidence, OAuth consent, or OS Keychain before retrying from the correct safe stage.planCloudArchive,reviewCloudCandidate,copyCloudCandidate,adoptExistingCloudCandidate,attestCloudCopy,trashVerifiedCloudSource,verifyCloudProviderCapacity,connectCloudProvider, anddisconnectCloudProviderauthority calls.Visible source and destination paths deliberately selected for business review remain available. Raw thrown provider, filesystem, credential, and implementation detail is not reflected into the interface.
Exact-head validation
For exact head
44a548f3bf11dd89440bb1caf013be1b2d42567a:31884524731— queued;31884524708— pending;31884524710— queued;31884524703— queued.Queued or pending evidence is not passing, and predecessor-head success does not transfer. Conditional PR-inapplicable publication or attestation helpers are not represented as passing release or provenance evidence.
Scope / non-duplication
This line owns only the CloudArchive desktop feedback boundary and its focused contract. It does not import repository-wide coverage #156, generic cleanup #174, canonical documentation #149, provider/cloud durable-authority storage lines, or another active owner.
Remaining integration blockers
Required before merge
Do not merge unless the unchanged exact head satisfies every applicable live required workflow and current finding, every review thread is resolved, a qualifying independent approval covers the last push/current head, fresh protected-main ancestry remains current, the live review ruleset is satisfied, and repository-wide exact coverage is satisfied without exclusions or threshold weakening. Pending, queued, skipped-required, neutral-required, failed, stale, predecessor, synthetic, diagnostic-only, status-only, model-only, rate-limited, no-source scanner, or infrastructure-only evidence is not passing.
Summary by CodeRabbit
버그 수정
접근성
role="alert"을 적용해 보조 기술이 오류를 즉시 인식할 수 있습니다.