Skip to content

security: reject shared-writable cloud review authority - #178

Merged
seonghobae merged 2 commits into
mainfrom
security/cloud-review-directory-authority-v1
Aug 12, 2026
Merged

security: reject shared-writable cloud review authority#178
seonghobae merged 2 commits into
mainfrom
security/cloud-review-directory-authority-v1

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Purpose

Fail cloud-review decision authority closed when its Unix storage directory is writable by group or other principals. Read-only decision files are not durable authorization evidence if another principal can unlink or replace entries through the parent directory.

Test-first state

Current RED head 7b4d7c1b254117437c62df0847efe8a046a7f02d adds a Unix integration regression through the public load_latest_decisions boundary. It makes an existing review directory mode 0777 and requires stable refusal cloud-review-directory-writable-by-others.

No production behavior is changed yet. The exact-head Test workflow must demonstrate the expected RED before the narrow fix is applied.

Scope

This lane owns only cloud-review directory authority and its focused regression. It does not modify the active global coverage owner #156, provider-global-sync #177, generic-cleanup #174, Podman desktop #150, or canonical documentation #149.

Keep Draft until RED is observed, the narrow production fix turns the same regression GREEN, all exact-head required checks pass, and live-base/writer evidence remains clean.

@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 53 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 7af1e687-76f9-41db-b109-40299f94819d

📥 Commits

Reviewing files that changed from the base of the PR and between 0ecb8c2 and 99dad9a.

📒 Files selected for processing (2)
  • src-tauri/src/cloud_review.rs
  • src-tauri/tests/cloud_review_directory_authority.rs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae marked this pull request as ready for review August 12, 2026 01:44
@seonghobae
seonghobae merged commit 3e5b81a into main Aug 12, 2026
35 checks passed
@seonghobae
seonghobae deleted the security/cloud-review-directory-authority-v1 branch August 12, 2026 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant