Skip to content

ux(admin): make console copy actionable and hide implementation boundaries - #858

Open
seonghobae wants to merge 12 commits into
mainfrom
ux/admin-copy-actionable
Open

ux(admin): make console copy actionable and hide implementation boundaries#858
seonghobae wants to merge 12 commits into
mainfrom
ux/admin-copy-actionable

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Summary

Subagent-audited pass over every operator-visible string in the admin console (EN + KO bundles), enforcing two rules: no internal implementation boundaries on screen, every phrase helps the next action.

Fixed (must-fix)

  • Readiness summary rendered an unlabeled 2/1/0 | commercial 5/0/1 | gtm … dump of internal abbreviations — replaced with a localized, labeled sentence plus a remediation pointer.
  • Raw enum values (local_commercial_due_diligence_room, …) appeared verbatim as status chips; a client-side label map now shows operator wording ('Measured on this server', 'Generated locally on this server').
  • Identity-key translations ("sales_readiness": "sales_readiness") replaced with real display copy in both locales.
  • EN/KO meaning drift corrected (보안 자세→보안 태세, readiness qualifiers, success rate); every new key ships with its KO twin so the locale_key_parity guardrail stays at 100%.

Fixed (should-fix)

  • EWMA → 'Avg latency (recent)' / '최근 평균 지연 시간'; Locale Bundle → Languages; docId → Document ID; 'async conversion' → automatic PDF conversion.
  • Duplicate-group error no longer tells console operators to 'use PATCH' (the UI does that transparently); invalid-token message guides re-entry while keeping the machine-contract keyword.

Verification

  • Full local suite green (2254 tests) including the locale-parity guardrail.
  • Focused admin contract + spend-view suites green.

Open in Devin Review

…aries

Subagent-audited pass over every operator-visible string (EN + KO):

Must-fix:
- Readiness pipe-dump ('sales 2/1/0 | commercial … | gtm …') replaced by
  a labeled, localized count sentence with a remediation pointer.
- Raw measurement_status enum values no longer render verbatim; a client
  label map shows operator wording ('Measured on this server', etc.).
- Identity-key translations replaced with real display copy.
- Duplicate-group and invalid-admin-token errors rewritten to guide the
  next action while keeping machine-contract keywords.
- EN/KO meaning drift fixed (보안 자세→보안 태세, readiness qualifiers,
  success rate); KO twin added for every new key so locale parity stays
  at 100% (guardrail-verified).

Should-fix: EWMA → 'Avg latency (recent)', Locale Bundle → Languages,
docId → Document ID, async conversion → automatic PDF conversion.
@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: dac0de2d-64b5-4c47-9e75-531e067c5b2e


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

devin-ai-integration[bot]

This comment was marked as resolved.

@seonghobae
seonghobae enabled auto-merge (squash) August 26, 2026 04:52
devin-ai-integration[bot]

This comment was marked as resolved.

@opencode-agent
opencode-agent Bot disabled auto-merge August 26, 2026 05:36
@seonghobae
seonghobae enabled auto-merge (squash) August 26, 2026 06:12
@opencode-agent
opencode-agent Bot disabled auto-merge August 26, 2026 06:25
@seonghobae
seonghobae enabled auto-merge (squash) August 26, 2026 06:54
@opencode-agent
opencode-agent Bot disabled auto-merge August 26, 2026 07:31
@seonghobae
seonghobae enabled auto-merge August 26, 2026 08:13
devin-ai-integration[bot]

This comment was marked as resolved.

@opencode-agent
opencode-agent Bot disabled auto-merge August 26, 2026 09:04
@seonghobae
seonghobae enabled auto-merge (squash) August 26, 2026 09:39
@seonghobae
seonghobae disabled auto-merge August 26, 2026 11:40
@seonghobae
seonghobae enabled auto-merge (squash) August 26, 2026 11:54
devin-ai-integration[bot]

This comment was marked as resolved.

@opencode-agent
opencode-agent Bot disabled auto-merge August 26, 2026 12:45
@seonghobae
seonghobae enabled auto-merge (squash) August 26, 2026 12:53
devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant