fix: use provider-backed embeddings for remote agents - #857
Conversation
|
Warning Review limit reachedNext included review available in 52 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (35)
📝 WalkthroughWalkthrough임베딩 배치를 provider 기반 비동기 작업으로 변경했습니다. Rust 토큰 패커, 입력별 provenance, 요청 deadline, provider retry·failover 제어, streaming 오류 처리, 비용 meter 및 가속기 런타임 문서를 추가했습니다. Changes임베딩 라우팅
요청 단위 provider deadline
Rust 및 런타임 경계
요청 계약과 운영 기록
Estimated code review effort: 5 (Critical) | ~120 minutes Merge Risk: 🟠 High · up to This change routes remote embedding work through configured providers and adds durable batch execution behavior, but the current implementation can leave some jobs stuck, fail concurrent submissions, and turn caller timeouts into 500 errors and misleading provider-health records. These production-facing correctness and availability risks should be fixed before merge. Sequence Diagram(s)sequenceDiagram
participant Client
participant Server
participant CostRoutingCoordinator
participant ProviderEmbeddingBatchBackend
participant Provider
Client->>Server: 임베딩 배치 요청
Server->>CostRoutingCoordinator: 입력과 요청 deadline 전달
CostRoutingCoordinator->>ProviderEmbeddingBatchBackend: shard 작업 제출
ProviderEmbeddingBatchBackend->>Provider: 임베딩 요청
Provider-->>ProviderEmbeddingBatchBackend: 벡터와 prompt usage 반환
ProviderEmbeddingBatchBackend-->>CostRoutingCoordinator: terminal 상태와 결과 저장
CostRoutingCoordinator-->>Server: 결과와 provenance 반환
Server-->>Client: HTTP 응답
sequenceDiagram
participant Client
participant Server
participant Orchestrator
participant ProviderRetry
participant Provider
Client->>Server: timeout header 포함 요청
Server->>Orchestrator: monotonic deadline 전달
Orchestrator->>ProviderRetry: 남은 budget으로 실행
ProviderRetry->>Provider: 제한된 timeout으로 호출
Provider-->>ProviderRetry: 응답 또는 오류
ProviderRetry-->>Orchestrator: 성공 또는 RequestDeadlineExceeded
Orchestrator-->>Server: 결과 또는 504 오류
Server-->>Client: HTTP 응답
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 40.38% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 312 functions across 37 files. (18 skipped: 17 unsupported, 1 too large.) ✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…o fix/provider-backed-embedding-batch
…tch' into fix/provider-backed-embedding-batch # Conflicts: # contextual_orchestrator/cost_router.py # contextual_orchestrator/orchestrator.py # tests/test_cost_router.py # tests/test_kv_credentials.py
…tch' into fix/provider-backed-embedding-batch
…tch' into fix/provider-backed-embedding-batch
…tch' into fix/provider-backed-embedding-batch
…857-rust-test-bootstrap
…tch' into codex/embedding-auto-discovery-audit
…tch' into HEAD # Conflicts: # CHANGELOG.md
…review-followup fix: harden embedding batch review boundaries
…857-rust-test-bootstrap
…857-rust-test-bootstrap # Conflicts: # Makefile
* fix: scope structured provider failures to request * fix: keep caller deadlines out of provider health * fix: scope direct conducted workflows * fix: admit only structured-ready workflow agents * feat: run readiness refresh as durable bounded jobs * fix: expire stale structured admission evidence * fix: bound readiness by provider concurrency * fix: preserve durable readiness evidence * fix: serialize durable readiness admission
* fix: scope structured provider failures to request * fix: keep caller deadlines out of provider health * fix: scope direct conducted workflows * fix: admit only structured-ready workflow agents * feat: run readiness refresh as durable bounded jobs * fix: expire stale structured admission evidence * fix: bound readiness by provider concurrency * fix: preserve durable readiness evidence * fix: close readiness review gaps
* fix: fail over structured passthrough by readiness * fix: preserve free-only passthrough contract * fix: enforce structured readiness admission
Summary
Verification
29 passedacross credential, batch embedding, routing-boundary, and cost-router testsgit diff --checkThis repairs the runtime boundary needed by LineageWeave Global Ask. It does not bypass protected review or checks.
Summary by CodeRabbit
새 기능
개선