Skip to content

fix: pass explicit argv to CLI entrypoint - #801

Merged
seonghobae merged 2 commits into
fix/auto-reasoning-effort-contract-rebasedfrom
fix/explicit-cli-argv-on-765
Aug 21, 2026
Merged

fix: pass explicit argv to CLI entrypoint#801
seonghobae merged 2 commits into
fix/auto-reasoning-effort-contract-rebasedfrom
fix/explicit-cli-argv-on-765

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Why

The LineageWeave bootstrap had to replace sys.argv before importing the CLI entrypoint. That is a monkey patch and makes the authenticated server invocation implicit.

Change

  • add an optional argv parameter to contextual_orchestrator.__main__.main
  • preserve normal console invocation and subcommands
  • route argparse through the supplied argument list
  • cover explicit argv and assert that process argv is unchanged

This PR is stacked on #765 because that is the current upstream base carrying the orchestrator auto-discovery and bounded multimodal body options consumed by LineageWeave.

Verification

  • uv run --with pytest pytest tests/test_cli_auth.py -q
  • 9 passed

Open in Devin Review

Exact-head reconciliation (2026-08-21)

  • Restacked on parent refactor: publish gateway-only paper-grounded reasoning contract #765 head 39072a654261c3570496849bb4da1e2c340e2fbc; current head eb9ec5f4e3f8ecbcf96cb132f58a212981ff0a6d.
  • Preserves the parent contract that an unspecified sampling temperature remains absent, so provider-default-only models do not receive an implicit 0.2.
  • Focused: .venv/bin/python -m pytest -q tests/test_cli_auth.py tests/test_discover_models_cli.py — 15 passed.
  • Full: .venv/bin/python -m pytest tests -q — 1521 passed in 555.46s.
  • git diff --check and codegraph status passed.

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 2bfc8385-7476-4a00-8f7d-7ce68844acb6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@seonghobae

Copy link
Copy Markdown
Contributor Author

Exact-head review completed at 1ed5148. This is the clean two-file CLI boundary stacked directly on the current #765 HEAD a4e4f68; no #789 drift is included. Local proof: 9 tests passed in tests/test_cli_auth.py, Ruff, compileall, and git diff --check passed. Auto-merge is being armed; protected Checks and independent approval remain required.

@seonghobae

Copy link
Copy Markdown
Contributor Author

Current-head verification for 1ed5148 (base a4e4f68): explicit CLI argv parsing preserves process argv and the inbound framing contracts pass locally (29 passed); Ruff, compileall, and diff --check pass. Hosted Checks and protected review remain authoritative for merge.

…effort-contract-rebased' into repair/pr801-latest-parent
@seonghobae

Copy link
Copy Markdown
Contributor Author

Exact-head RCA: Strix run 32436050151 / job 96637367737 materialized only one changed Python file, so unchanged local imports in contextual_orchestrator/main.py were absent from the temporary scan tree. The resulting ImportError report is scanner-context false positive; the current package contains those modules. The trusted central fix is stacked as ContextualWisdomLab/.github#1192 (parent #1191), which enumerates contextual_orchestrator/*.py from the exact PR head while preserving changed-file attribution. Do not weaken the Strix gate or rerun unchanged.

@seonghobae seonghobae added the bug Something isn't working label Aug 21, 2026 — with ChatGPT Codex Connector
@seonghobae
seonghobae merged commit 3bbe137 into fix/auto-reasoning-effort-contract-rebased Aug 21, 2026
27 checks passed
@seonghobae
seonghobae deleted the fix/explicit-cli-argv-on-765 branch August 21, 2026 14:12
@seonghobae

Copy link
Copy Markdown
Contributor Author

Exact stack recheck:

  • PR head: eb9ec5f4e3f8ecbcf96cb132f58a212981ff0a6d.
  • The PR records base 39072a654261c3570496849bb4da1e2c340e2fbc, but the live parent branch is 70f8b4dbb6b8d5749140581c50bcdf3b31ad8475 after subsequent normal stack merges.
  • The logical fix: pass explicit argv to CLI entrypoint #801 change is already present in the live parent tree: contextual_orchestrator.__main__.main accepts explicit argv, and tests/test_cli_auth.py contains the explicit-argv regression test.
  • A local merge of the live parent into the stale PR head produced no missing fix: pass explicit argv to CLI entrypoint #801 tree change; it was not pushed.

Decision: WAIT_AND_REMEDIATE as a no-op/stale-base stack item. Do not merge the stale PR head or reuse its CLEAN status as current-base evidence; the parent branch already contains the requested change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant