Skip to content

merge: integrate automatic embedding selection with temperature negotiation - #791

Merged
seonghobae merged 7 commits into
fix/provider-temperature-capability-negotiation-on-765-v2from
integrate/temperature-and-auto-embedding
Aug 20, 2026
Merged

merge: integrate automatic embedding selection with temperature negotiation#791
seonghobae merged 7 commits into
fix/provider-temperature-capability-negotiation-on-765-v2from
integrate/temperature-and-auto-embedding

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Summary

Stack

Verification

  • focused provider-temperature, embedding HTTP honesty, and OpenAPI contract tests: 21 passed
  • exact integration head full suite: 1478 passed in 547.52s
  • python -m compileall -q contextual_orchestrator tests
  • git diff --check

No provider credentials or response content are persisted.


Open in Devin Review

@seonghobae

Copy link
Copy Markdown
Contributor Author

@opencode-agent review exact current HEAD 0246e91f107c8dbb82eb0b421d0aeb0f5fe21ecf. Verify that PR #789 omitted-model embedding selection remains capability-gated and provenance-bearing after integration with PR #779 temperature negotiation, and that neither contract regresses the other. Publish a formal current-head review; do not approve either parent head as evidence for this merge head.

@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 32634510-f71f-442d-ab08-28162c627199

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

devin-ai-integration[bot]

This comment was marked as resolved.

@seonghobae

Copy link
Copy Markdown
Contributor Author

Fixed the Devin finding on exact current HEAD 4c31c3549537ba4813fe25e2bf4efc3e5b56aa3f:

  • Renamed the new ADR from 0012-auto-embedding-model-selection.md to 0015-auto-embedding-model-selection.md.
  • Updated its front matter ID and heading to 0015; existing ADR 0012 provider-contract references remain unambiguous.
  • Embedding, batch, discovery, and API-contract regression suite: 71 passed.
  • Ruff and git diff --check: passed.

@devin-ai-integration please re-review this exact current HEAD.

@seonghobae

Copy link
Copy Markdown
Contributor Author

The prior ADR collision finding is resolved on current exact HEAD 4c31c3549537ba4813fe25e2bf4efc3e5b56aa3f by renaming the new decision record to ADR 0015. Please review this exact integration head against fix/provider-temperature-capability-negotiation-on-765-v2 and publish findings or explicit no-findings before any merge decision.

@seonghobae

Copy link
Copy Markdown
Contributor Author

Current-head proof for 4c31c3549537ba4813fe25e2bf4efc3e5b56aa3f:

  • Integration keeps omitted-model embedding selection capability-gated and preserves the temperature-negotiation contract; the ADR collision was resolved as 0015.
  • Embedding/discovery/API/batch focused suite: 67 passed; Ruff, compileall, and diff checks passed.
  • First full run reported 1477 passed plus one teardown failure from local OSError: [Errno 28] No space left on device; the affected test passed alone after disk recovery. A clean exact-tree rerun with an explicit temporary directory completed 1478 passed in 555.34s.

This stacked PR remains dependent on its parent chain and protected review/check evidence. No bypass, self-approval, or force-push was used.

@seonghobae
seonghobae merged commit 995effd into fix/provider-temperature-capability-negotiation-on-765-v2 Aug 20, 2026
2 checks passed
@seonghobae
seonghobae deleted the integrate/temperature-and-auto-embedding branch August 20, 2026 15:43
seonghobae added a commit that referenced this pull request Aug 20, 2026
…iation (#791)

* feat: auto-select embedding agents

* fix: align embedding selection API contract

* test: cover embedding capability selection boundaries

* test: declare embedding capability in embedding fixtures

* style: normalize embedding HTTP fixture imports

* docs: assign unique embedding selection ADR number
seonghobae added a commit that referenced this pull request Aug 20, 2026
…ation line (#779)

* fix: negotiate unsupported temperature capability

* test(protocol): preserve 4xx evidence and negotiated retry state

* fix: preserve negotiated temperature capability

* merge: integrate automatic embedding selection with temperature negotiation (#791)

* feat: auto-select embedding agents

* fix: align embedding selection API contract

* test: cover embedding capability selection boundaries

* test: declare embedding capability in embedding fixtures

* style: normalize embedding HTTP fixture imports

* docs: assign unique embedding selection ADR number

* docs: assign unique sampling capability ADR number

* feat: opt in to client-owned tool loops (#787)

* feat: opt in to client-owned tool loops

* test: repair stale standalone test entrypoints

* fix: reject streaming responses tool loops

* fix: enforce total inbound body deadline

* test: keep static checks clean
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant