Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions AGENTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ This section applies to any agent (Claude, Codex, Cursor, opencode, ...) working
- Keep UI and analysis engine decoupled through shared contracts.
- Prefer minimal, test-first changes for production code.
- Prefer practical, friendly, rehearsal-first wording over academic or authority-heavy language.
- Name tonight's first open rehearsal comment with the author, the corroborated holding part, the labeled section, and the time so the next action is obvious.
- Do not reduce the product to a chord analyzer when form, timing, player coordination, playable ranges, simplification, and setup cues are the real rehearsal blockers.
- Do not frame usability as a reason to accept weak analysis quality; BandScope should aim for both easy use and high accuracy.

Expand Down
1 change: 1 addition & 0 deletions ARCHITECTURE.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ Last updated: 2026-03-11
## Brand source

- Product identity, UX tone, copy rules, and prioritization tie-breakers live in `docs/brand-story.md`.
- The mounted workspace copy for tonight's first open rehearsal comment must name the author, the corroborated holding part, the labeled section, and the time so the next action is obvious. Open moves to the matching rendered map section. Do not invent a note from resolved comments, assignments, approvals, cues, groove, setup, simplification, overlap, or range copy.
- Future PRDs, TRDs, onboarding copy, empty states, error messages, and marketing copy should use that document as the single brand source of truth.

## Security source
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

### Added

- Name tonight's first open rehearsal comment in the mounted rehearsal workspace so the room can read the MD note and open the matching rendered map section, while inherited or accessor-backed runtime metadata remains guidance-only instead of becoming navigation authority.
- Name tonight's first playable range on the ready rehearsal map and tell the player to check that span on their instrument before the section.
- Display the analyzed song tempo (BPM) as a badge in the rehearsal workspace.
- 각 합주 역할(Role)별 개인 연습 진행도를 0~100% 범위로 기록 및 시각화할 수 있는 연습 진척도(`practiceProgress`) 트래커 기능 추가. UI 컨트롤(슬라이더 및 +/- 버튼)과 한/영 다국어 지원 포함.
Expand Down
2 changes: 1 addition & 1 deletion CLAUDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ BandScope is a local-first desktop app for rehearsal prep: it turns a song into

Three layers, decoupled through shared contracts:

- `apps/desktop` — Tauri 2 + Vite + React 19 shell (Tailwind 4, Base UI, Storybook). Feature screens live in `src/features/` (home, workspace, chords, ranges, player, settings). The ready workspace names tonight's first playable range and the next instrument check. `src/lib/analysis.ts` and `src/lib/job_runner.ts` call typed Tauri IPC commands, with a browser fallback that serves demo data when not running inside Tauri.
- `apps/desktop` — Tauri 2 + Vite + React 19 shell (Tailwind 4, Base UI, Storybook). Feature screens live in `src/features/` (home, workspace, chords, ranges, player, settings). The mounted workspace names tonight's first open rehearsal comment and opens the matching rendered map section. The ready workspace names tonight's first playable range and the next instrument check. Do not invent a note from resolved comments, assignments, approvals, cues, groove, setup, simplification, overlap, or range copy. `src/lib/analysis.ts` and `src/lib/job_runner.ts` call typed Tauri IPC commands, with a browser fallback that serves demo data when not running inside Tauri.
- `apps/desktop/src-tauri/src/main.rs` — the Rust orchestration boundary. Tauri commands (`start_analysis_job`, `get_analysis_job_status`, `select_local_audio_source`, `import_youtube_url`) validate untrusted input (project IDs, file paths, URLs) and spawn the Python engine as a subprocess. There is no loopback HTTP listener and no network path for local analysis.
- `services/analysis-engine` — Python package `bandscope_analysis` (librosa/numpy). Entry point `cli.py` reads a JSON job request on stdin and prints a structured job-status JSON envelope on stdout (`--progress-jsonl` streams progress lines). `api.py` orchestrates the pipeline across the `separation`, `sections`, `roles`, `chords`, `ranges`, `temporal`, `transcription`, and `youtube` modules.

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
import { fireEvent, render, screen } from "@testing-library/react";
import { createDemoRehearsalSong } from "@bandscope/shared-types";
import { afterEach, describe, expect, it, vi } from "vitest";
import { FirstOpenCommentCallout } from "./FirstOpenCommentCallout";

describe("FirstOpenCommentCallout Korean role copy", () => {
afterEach(() => {
vi.unstubAllGlobals();
});

it("keeps vowel-ending dynamic role names particle-safe before and after the note action", () => {
vi.stubGlobal("navigator", { language: "ko-KR" });
const song = createDemoRehearsalSong();
const seed = song.sections[0]!;
seed.roles = [
{
...seed.roles[1]!,
id: "piano",
name: "피아노",
rehearsalPriority: "high"
}
];
seed.partGraph = [{ role_id: "piano", is_active: true, handoff_to: [], handoff_from: [] }];
song.collaboration!.comments = [
{
id: "comment-piano-color",
author: "MD",
body: "첫 패스에서는 톤을 부드럽게 유지하세요.",
sectionId: seed.id,
roleId: "piano",
status: "open"
}
];

const grid = document.createElement("div");
grid.dataset.testid = "song-structure-grid";
grid.setAttribute("role", "region");
grid.setAttribute("aria-label", "Scrollable song structure timeline");
const target = document.createElement("div");
target.dataset.sectionIndex = "0";
Object.defineProperty(target, "scrollIntoView", {
configurable: true,
value: vi.fn()
});
grid.appendChild(target);
document.body.appendChild(grid);

render(<FirstOpenCommentCallout song={song} />);

expect(screen.getByText("MD님이 0:10 벌스에서 피아노 파트에 메모를 남겼습니다.")).toBeTruthy();
expect(screen.queryByText(/피아노이/)).toBeNull();

fireEvent.click(screen.getByRole("button", { name: "0:10 피아노 위치 열기" }));

expect(screen.getByText("0:10에서 피아노 파트 메모를 확인하세요. 그 파트를 보고 있으세요.")).toBeTruthy();
expect(screen.queryByText(/피아노과/)).toBeNull();

grid.remove();
});
});
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
import { render, screen } from "@testing-library/react";
import { createDemoRehearsalSong } from "@bandscope/shared-types";
import { describe, expect, it } from "vitest";
import { FirstOpenCommentCallout } from "./FirstOpenCommentCallout";

describe("FirstOpenCommentCallout hostile runtime identity", () => {
it("contains a song identity descriptor trap without discarding the valid owned comment", () => {
const song = createDemoRehearsalSong();
const hostileSong = new Proxy(song, {
getOwnPropertyDescriptor(target, property) {
if (property === "id") {
throw new Error("hostile song id descriptor trap");
}
return Reflect.getOwnPropertyDescriptor(target, property);
}
});

expect(() => render(<FirstOpenCommentCallout song={hostileSong} />)).not.toThrow();
expect(
screen.getByText("MD left a note for Keyboard 1 Right Hand in the verse at 0:10.")
).toBeTruthy();
expect(
screen.getByText(
"Keep the keyboard color tone gentle on the first pass so the vocal cue stays forward."
)
).toBeTruthy();
});
});
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
import { fireEvent, render, screen } from "@testing-library/react";
import { createDemoRehearsalSong } from "@bandscope/shared-types";
import { afterEach, describe, expect, it, vi } from "vitest";
import { FirstOpenCommentCallout } from "./FirstOpenCommentCallout";

describe("FirstOpenCommentCallout reduced motion", () => {
afterEach(() => {
vi.unstubAllGlobals();
});

it("scrolls immediately when the operating system requests reduced motion", () => {
vi.stubGlobal("matchMedia", (query: string) => ({
matches: query === "(prefers-reduced-motion: reduce)",
media: query,
onchange: null,
addListener: vi.fn(),
removeListener: vi.fn(),
addEventListener: vi.fn(),
removeEventListener: vi.fn(),
dispatchEvent: vi.fn()
}));

const grid = document.createElement("div");
grid.dataset.testid = "song-structure-grid";
grid.setAttribute("role", "region");
grid.setAttribute("aria-label", "Scrollable song structure timeline");
const target = document.createElement("div");
target.dataset.sectionIndex = "0";
const scrollIntoView = vi.fn();
Object.defineProperty(target, "scrollIntoView", {
configurable: true,
value: scrollIntoView
});
grid.appendChild(target);
document.body.appendChild(grid);

render(<FirstOpenCommentCallout song={createDemoRehearsalSong()} />);
fireEvent.click(screen.getByRole("button", { name: "Open Keyboard 1 Right Hand at 0:10" }));
expect(scrollIntoView).toHaveBeenCalledWith({ block: "nearest", behavior: "auto" });

grid.remove();
});
});
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
import type { Meta, StoryObj } from "@storybook/react-vite";
import { createDemoRehearsalSong } from "@bandscope/shared-types";

import { FirstOpenCommentCallout } from "./FirstOpenCommentCallout";

const availableSong = createDemoRehearsalSong();
const unavailableSong = createDemoRehearsalSong();
for (const comment of unavailableSong.collaboration?.comments ?? []) {
comment.status = "resolved";
}

const meta = {
title: "Workspace/First Open Comment Callout",
component: FirstOpenCommentCallout,
parameters: { layout: "padded" },
decorators: [
(Story) => (
<div className="min-h-72 bg-slate-950 p-6 text-white">
<div data-testid="song-structure-grid" className="mb-6 rounded-xl border border-slate-700 p-3">
<div data-section-index="0" className="text-xs text-slate-400">
Song structure target · section 1
</div>
</div>
<Story />
</div>
)
]
} satisfies Meta<typeof FirstOpenCommentCallout>;

export default meta;
type Story = StoryObj<typeof meta>;

/** Figma workspace next-action pattern with the earliest owned open rehearsal note. */
export const Available: Story = {
args: { song: availableSong }
};

/** Guidance-only state when tonight's map has no owned open rehearsal note. */
export const Unavailable: Story = {
args: { song: unavailableSong }
};
Loading
Loading