-
Notifications
You must be signed in to change notification settings - Fork 0
feat(workspace): name tonight's tempo, starting chord, and transpose setup #987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
seonghobae
wants to merge
14
commits into
develop
Choose a base branch
from
feat/workspace-tempo-key-transpose-next-action
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
050ae81
feat(workspace): name tonight's tempo, starting chord, and transpose …
seonghobae d48cba1
fix(workspace): satisfy rehearsal metric lint contract
seonghobae 4f62e44
fix(workspace): preserve section-label literal type
seonghobae c508bb9
test(workspace): reject exceptional rehearsal metric metadata
seonghobae db87b7a
fix(workspace): contain exceptional rehearsal metric metadata
seonghobae 920d39b
test(metrics): bound synthetic section collection scans
seonghobae f379407
fix(metrics): bound runtime collection density scans
seonghobae e42b903
test(workspace): align tempo badge readiness
seonghobae d203417
fix(workspace): align tempo badge readiness
seonghobae ec87428
test(metrics): contain hostile runtime metadata traps
seonghobae 6616450
Merge branch 'develop' into feat/workspace-tempo-key-transpose-next-a…
seonghobae 4092362
fix(review): suppress cockpit next actions while the Score view is ac…
seonghobae f793336
Merge remote-tracking branch 'origin/develop' into HEAD
seonghobae 98dab4f
fix(desktop): fail closed on hostile rehearsal metadata
seonghobae File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 changes: 24 additions & 0 deletions
24
apps/desktop/src/features/workspace/Workspace.tempo.test.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| import { createDemoRehearsalSong } from "@bandscope/shared-types"; | ||
| import { render, screen } from "@testing-library/react"; | ||
| import { describe, expect, it } from "vitest"; | ||
| import { Workspace } from "./Workspace"; | ||
|
|
||
| function songWithTempo(tempo: number) { | ||
| const song = createDemoRehearsalSong(); | ||
| song.tempo = tempo; | ||
| return song; | ||
| } | ||
|
|
||
| describe("Workspace tempo readiness", () => { | ||
| it.each([90.5, 500])("does not present an uncountable %s BPM as a ready tempo", (tempo) => { | ||
| render(<Workspace song={songWithTempo(tempo)} />); | ||
|
|
||
| expect(screen.queryByText(`${tempo} BPM`, { exact: false })).toBeNull(); | ||
| }); | ||
|
|
||
| it("keeps the badge for a countable integer tempo", () => { | ||
| render(<Workspace song={songWithTempo(120)} />); | ||
|
|
||
| expect(screen.getByText("120 BPM", { exact: false })).toBeTruthy(); | ||
| }); | ||
| }); |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.