feat(workspace): loop tonight's first section from the map #971
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| import { render, screen } from "@testing-library/react"; | ||
| import { createDemoRehearsalSong } from "@bandscope/shared-types"; | ||
| import { afterEach, describe, expect, it, vi } from "vitest"; | ||
| import { RehearsalPlayer } from "./RehearsalPlayer"; | ||
|
|
||
| const originalTauriInternals = Object.getOwnPropertyDescriptor( | ||
| window, | ||
| "__TAURI_INTERNALS__", | ||
| ); | ||
|
|
||
| describe("RehearsalPlayer audio authority", () => { | ||
| afterEach(() => { | ||
| vi.restoreAllMocks(); | ||
| if (originalTauriInternals) { | ||
| Object.defineProperty(window, "__TAURI_INTERNALS__", originalTauriInternals); | ||
| } else { | ||
| delete (window as Window & { __TAURI_INTERNALS__?: unknown }) | ||
| .__TAURI_INTERNALS__; | ||
| } | ||
| }); | ||
|
|
||
| it("refuses to start when local-audio metadata has no playable asset URL", () => { | ||
| const song = createDemoRehearsalSong(); | ||
|
|
||
| render( | ||
| <RehearsalPlayer | ||
| song={song} | ||
| hasLocalAudio={true} | ||
| audioSourcePath="browser://selected-audio" | ||
| startNonce={1} | ||
| />, | ||
| ); | ||
|
|
||
| expect( | ||
| screen.getByRole("button", { name: /start the count-in/i }), | ||
| ).toBeDisabled(); | ||
| expect( | ||
| screen.getByTestId("rehearsal-loop-next-action").textContent, | ||
| ).not.toMatch(/count in 4 beats/i); | ||
| }); | ||
|
|
||
| it("reports native asset conversion failures instead of presenting missing-audio copy", () => { | ||
| Object.defineProperty(window, "__TAURI_INTERNALS__", { | ||
| configurable: true, | ||
| value: { | ||
| convertFileSrc: () => { | ||
| throw new Error("asset conversion failed"); | ||
| }, | ||
| }, | ||
| }); | ||
| const song = createDemoRehearsalSong(); | ||
|
|
||
| render( | ||
| <RehearsalPlayer | ||
| song={song} | ||
| hasLocalAudio={true} | ||
| audioSourcePath="/Users/test/Music/late-night-set.wav" | ||
| />, | ||
| ); | ||
|
|
||
| expect( | ||
| screen.getByRole("button", { name: /start the count-in/i }), | ||
| ).toBeDisabled(); | ||
| expect(screen.getByRole("alert").textContent).toMatch( | ||
| /could not play this local audio/i, | ||
| ); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| import { render, screen } from "@testing-library/react"; | ||
| import { createDemoRehearsalSong } from "@bandscope/shared-types"; | ||
| import { describe, expect, it } from "vitest"; | ||
| import { RehearsalPlayer } from "./RehearsalPlayer"; | ||
|
|
||
| describe("RehearsalPlayer descriptor authority", () => { | ||
| it("renders the admitted section snapshot instead of Proxy get values", () => { | ||
| const song = createDemoRehearsalSong(); | ||
| const section = song.sections[0]!; | ||
| const expectedLabel = section.label; | ||
| const expectedStart = section.timeRange.start; | ||
| const expectedEnd = section.timeRange.end; | ||
| song.sections = [ | ||
| new Proxy(section, { | ||
| get(target, property, receiver) { | ||
| if (property === "id") { | ||
| return "proxy-injected-section"; | ||
| } | ||
| if (property === "label") { | ||
| return "outro"; | ||
| } | ||
| if (property === "timeRange") { | ||
| return { start: 90, end: 100 }; | ||
| } | ||
| return Reflect.get(target, property, receiver); | ||
| } | ||
| }) | ||
| ]; | ||
|
|
||
| render(<RehearsalPlayer song={song} hasLocalAudio={true} />); | ||
|
|
||
| expect( | ||
| screen.getByRole("button", { | ||
| name: new RegExp(`${expectedLabel}.*0:${String(expectedStart).padStart(2, "0")}.*0:${String(expectedEnd).padStart(2, "0")}`, "i") | ||
| }) | ||
| ).toBeTruthy(); | ||
| expect(screen.queryByRole("button", { name: /outro.*1:30.*1:40/i })).toBeNull(); | ||
| }); | ||
| }); |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.