feat(workspace): guide tonight's first stop on map and player

AGENTS.md

@@ -83,6 +83,7 @@ This section applies to any agent (Claude, Codex, Cursor, opencode, ...) working
 - Keep UI and analysis engine decoupled through shared contracts.
 - Prefer minimal, test-first changes for production code.
 - Prefer practical, friendly, rehearsal-first wording over academic or authority-heavy language.
+- Name tonight's first stop with the holding part when an active role is corroborated, the labeled cut, and the time so the next action is obvious.
 - Do not reduce the product to a chord analyzer when form, timing, player coordination, playable ranges, simplification, and setup cues are the real rehearsal blockers.
 - Do not frame usability as a reason to accept weak analysis quality; BandScope should aim for both easy use and high accuracy.
 

ARCHITECTURE.md

@@ -6,6 +6,7 @@ Last updated: 2026-03-11
 
 - Product identity, UX tone, copy rules, and prioritization tie-breakers live in `docs/brand-story.md`.
 - Future PRDs, TRDs, onboarding copy, empty states, error messages, and marketing copy should use that document as the single brand source of truth.
+- Workspace and player copy for tonight's first stop must name the holding part when corroborated, the labeled cut, and the time so the next action is obvious.
 
 ## Security source
 

CHANGELOG.md

@@ -4,6 +4,7 @@
 
 ### Added
 
+- Name tonight's first stop on the workspace and player so the room can hold the cut; the workspace action opens the matching map section, while the player exposes a Hear action only when its owning playback surface supplies a seek callback.
 - Name tonight's first playable range on the ready rehearsal map and tell the player to check that span on their instrument before the section.
 - Display the analyzed song tempo (BPM) as a badge in the rehearsal workspace.
 - 각 합주 역할(Role)별 개인 연습 진행도를 0~100% 범위로 기록 및 시각화할 수 있는 연습 진척도(`practiceProgress`) 트래커 기능 추가. UI 컨트롤(슬라이더 및 +/- 버튼)과 한/영 다국어 지원 포함.

CLAUDE.md

@@ -51,7 +51,7 @@ BandScope is a local-first desktop app for rehearsal prep: it turns a song into
 
 Three layers, decoupled through shared contracts:
 
-- `apps/desktop` — Tauri 2 + Vite + React 19 shell (Tailwind 4, Base UI, Storybook). Feature screens live in `src/features/` (home, workspace, chords, ranges, player, settings). The ready workspace names tonight's first playable range and the next instrument check. `src/lib/analysis.ts` and `src/lib/job_runner.ts` call typed Tauri IPC commands, with a browser fallback that serves demo data when not running inside Tauri.
+- `apps/desktop` — Tauri 2 + Vite + React 19 shell (Tailwind 4, Base UI, Storybook). Feature screens live in `src/features/` (home, workspace, chords, ranges, player, settings). Workspace and player name tonight's first stop so the room can hold the cut; the workspace action opens the matching map section, while the player exposes a Hear action only when its owning playback surface supplies a seek callback. The ready workspace also names tonight's first playable range and the next instrument check. `src/lib/analysis.ts` and `src/lib/job_runner.ts` call typed Tauri IPC commands, with a browser fallback that serves demo data when not running inside Tauri.
 - `apps/desktop/src-tauri/src/main.rs` — the Rust orchestration boundary. Tauri commands (`start_analysis_job`, `get_analysis_job_status`, `select_local_audio_source`, `import_youtube_url`) validate untrusted input (project IDs, file paths, URLs) and spawn the Python engine as a subprocess. There is no loopback HTTP listener and no network path for local analysis.
 - `services/analysis-engine` — Python package `bandscope_analysis` (librosa/numpy). Entry point `cli.py` reads a JSON job request on stdin and prints a structured job-status JSON envelope on stdout (`--progress-jsonl` streams progress lines). `api.py` orchestrates the pipeline across the `separation`, `sections`, `roles`, `chords`, `ranges`, `temporal`, `transcription`, and `youtube` modules.
 

apps/desktop/src/features/player/index.test.tsx

@@ -0,0 +1,57 @@
+import { fireEvent, render, screen } from "@testing-library/react";
+import { createDemoRehearsalSong } from "@bandscope/shared-types";
+import { describe, expect, it, vi } from "vitest";
+import { PlayerFeature } from "./index";
+
+function songWithStop() {
+  const song = createDemoRehearsalSong();
+  const verse = song.sections[0]!;
+  const stop = structuredClone(verse);
+  stop.id = "stop-1";
+  stop.label = "stop";
+  stop.timeRange = { start: 18, end: 19 };
+  stop.roles = [
+    {
+      ...verse.roles[2]!,
+      id: "lead-vocal",
+      name: "Lead Vocal",
+      rehearsalPriority: "high"
+    }
+  ];
+  stop.partGraph = [
+    {
+      role_id: "lead-vocal",
+      is_active: true,
+      handoff_to: [],
+      handoff_from: []
+    }
+  ];
+  song.sections = [verse, stop];
+  return song;
+}
+
+describe("PlayerFeature", () => {
+  it("asks the room to analyze first when no song is loaded", () => {
+    render(<PlayerFeature title="Player" />);
+    expect(
+      screen.getByText("Analyze tonight's song first, then hear the first stop from this player.")
+    ).toBeTruthy();
+  });
+
+  it("keeps the stop hear action unavailable without a player playback callback", () => {
+    render(<PlayerFeature title="Player" song={songWithStop()} />);
+
+    expect(screen.queryByRole("button", { name: "Hear Lead Vocal cut at 0:18" })).toBeNull();
+    expect(screen.getByText("Lead Vocal cuts the stop at 0:18.")).toBeTruthy();
+  });
+
+  it("delegates the stop hear action to the owning player callback", () => {
+    const onPlayFromSeconds = vi.fn();
+    render(<PlayerFeature title="Player" song={songWithStop()} onPlayFromSeconds={onPlayFromSeconds} />);
+
+    fireEvent.click(screen.getByRole("button", { name: "Hear Lead Vocal cut at 0:18" }));
+
+    expect(onPlayFromSeconds).toHaveBeenCalledTimes(1);
+    expect(onPlayFromSeconds).toHaveBeenCalledWith(18);
+  });
+});

apps/desktop/src/features/player/index.tsx

@@ -1,27 +1,37 @@
 import type { RehearsalSong } from "@bandscope/shared-types";
+import { FirstStopCallout } from "../workspace/FirstStopCallout";
+import { createTranslator, detectPreferredLocale } from "../../i18n";
 
-/** Documented. */
-export function PlayerFeature(props: { title: string; song?: RehearsalSong | null }) {
-  const { title, song } = props;
+type PlayerFeatureProps = {
+  title: string;
+  song?: RehearsalSong | null;
+  onPlayFromSeconds?: (startSeconds: number) => void;
+};
+
+/** Player surface that names tonight's first stop and delegates playback to the owning player. */
+export function PlayerFeature({ title, song, onPlayFromSeconds }: PlayerFeatureProps) {
+  const t = createTranslator(detectPreferredLocale());
 
   if (!song) {
     return (
       <section style={{ padding: "24px" }}>
         <h2>{title}</h2>
-        <p style={{ color: "#999" }}>No song loaded. Start an analysis to use the player.</p>
+        <p style={{ color: "#999" }}>{t("firstStopNeedsSong")}</p>
       </section>
     );
   }
 
   return (
     <section style={{ padding: "24px" }}>
       <h2>{title}</h2>
+      <FirstStopCallout song={song} actionMode="callback-only" onHearStop={onPlayFromSeconds} />
       <div
         style={{
           padding: "16px",
           backgroundColor: "#fafafa",
           borderRadius: "8px",
           border: "1px solid #e8e8e8",
+          marginTop: "16px"
         }}
       >
         <div style={{ marginBottom: "12px" }}>
@@ -31,16 +41,16 @@ export function PlayerFeature(props: { title: string; song?: RehearsalSong | nul
           </span>
         </div>
         <div style={{ display: "flex", gap: "8px", flexWrap: "wrap" }}>
-          {song.sections.map((section) => (
+          {song.sections.map((section, sectionIndex) => (
             <span
-              key={section.id}
+              key={`${section.id}-${sectionIndex}`}
               style={{
                 padding: "4px 12px",
                 borderRadius: "16px",
                 backgroundColor: "#fff",
                 border: "1px solid #d9d9d9",
                 fontSize: "0.85em",
-                textTransform: "capitalize",
+                textTransform: "capitalize"
               }}
             >
               {section.label}

apps/desktop/src/features/workspace/FirstStopCallout.localization.test.tsx

@@ -0,0 +1,52 @@
+import { render, screen } from "@testing-library/react";
+import { createDemoRehearsalSong, type RehearsalSong } from "@bandscope/shared-types";
+import { afterEach, describe, expect, it, vi } from "vitest";
+import { FirstStopCallout } from "./FirstStopCallout";
+
+function songWithLocalizedStop() {
+  const song = createDemoRehearsalSong();
+  const section = song.sections[0]!;
+  const role = {
+    ...section.roles[0]!,
+    id: "keyboard-stop",
+    name: "피아노",
+    rehearsalPriority: "high" as const
+  };
+  section.id = "localized-stop";
+  section.label = "stop";
+  section.timeRange = { start: 10, end: 12 };
+  section.roles = [role];
+  section.partGraph = [
+    {
+      role_id: role.id,
+      is_active: true,
+      handoff_to: [],
+      handoff_from: []
+    }
+  ];
+  return song;
+}
+
+describe("FirstStopCallout runtime and locale boundary", () => {
+  afterEach(() => {
+    vi.unstubAllGlobals();
+  });
+
+  it("contains a malformed runtime song root instead of crashing the callout", () => {
+    render(<FirstStopCallout song={null as unknown as RehearsalSong} />);
+
+    expect(
+      screen.getByText("No stop yet. Stay on tonight's map until a cut is marked.")
+    ).toBeTruthy();
+  });
+
+  it("uses particle-safe Korean section-form copy instead of exposing the raw stop enum", () => {
+    vi.stubGlobal("navigator", { language: "ko-KR" });
+
+    render(<FirstStopCallout song={songWithLocalizedStop()} />);
+
+    expect(screen.getByText("0:10 스톱에서 피아노 파트가 컷합니다.")).toBeTruthy();
+    expect(screen.queryByText("피아노이 0:10 스톱에서 컷합니다.")).toBeNull();
+    expect(screen.queryByText(/ stop에서 /)).toBeNull();
+  });
+});

apps/desktop/src/features/workspace/FirstStopCallout.reduced-motion.test.tsx

@@ -0,0 +1,62 @@
+import { fireEvent, render, screen } from "@testing-library/react";
+import { createDemoRehearsalSong } from "@bandscope/shared-types";
+import { afterEach, describe, expect, it, vi } from "vitest";
+import { FirstStopCallout } from "./FirstStopCallout";
+
+function songWithStop() {
+  const song = createDemoRehearsalSong();
+  const verse = song.sections[0]!;
+  const stop = structuredClone(verse);
+  stop.id = "stop-1";
+  stop.label = "stop";
+  stop.timeRange = { start: 18, end: 19 };
+  stop.roles = [
+    {
+      ...verse.roles[2]!,
+      id: "lead-vocal",
+      name: "Lead Vocal",
+      rehearsalPriority: "high"
+    }
+  ];
+  stop.partGraph = [
+    {
+      role_id: "lead-vocal",
+      is_active: true,
+      handoff_to: [],
+      handoff_from: []
+    }
+  ];
+  song.sections = [verse, stop];
+  return song;
+}
+
+describe("FirstStopCallout reduced motion", () => {
+  afterEach(() => {
+    vi.unstubAllGlobals();
+  });
+
+  it("scrolls immediately when the operating system requests reduced motion", () => {
+    const matchMedia = vi.fn().mockReturnValue({ matches: true });
+    vi.stubGlobal("matchMedia", matchMedia);
+
+    const grid = document.createElement("div");
+    grid.dataset.testid = "song-structure-grid";
+    const first = document.createElement("div");
+    const target = document.createElement("div");
+    const scrollIntoView = vi.fn();
+    Object.defineProperty(target, "scrollIntoView", {
+      configurable: true,
+      value: scrollIntoView
+    });
+    grid.appendChild(first);
+    grid.appendChild(target);
+    document.body.appendChild(grid);
+
+    render(<FirstStopCallout song={songWithStop()} />);
+    fireEvent.click(screen.getByRole("button", { name: "Open Lead Vocal stop at 0:18" }));
+
+    expect(matchMedia).toHaveBeenCalledWith("(prefers-reduced-motion: reduce)");
+    expect(scrollIntoView).toHaveBeenCalledWith({ block: "nearest", behavior: "auto" });
+    grid.remove();
+  });
+});