Skip to content

⚡ Bolt: [성능 개선] #812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
seonghobae wants to merge 1 commit into from
Closed

⚡ Bolt: [성능 개선] #812

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .jules/bolt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,3 +61,7 @@
## 2026-07-13 - Array.from mapping optimization
**Learning:** Using `Array.from({ length: N }).map(...)` creates an intermediate array of `undefined` values which requires memory allocation and garbage collection, adding O(N) unnecessary overhead in frequently re-rendered UI components.
**Action:** Use `Array.from({ length: N }, (_, index) => ...)` to map elements directly during array creation, avoiding intermediate allocations.

## 2026-07-20 - Eliminate intermediate list allocations in Python sum(zip(A, A[1:]))
**Learning:** Using `sum(1 for a, b in zip(list, list[1:]))` creates an intermediate list slice (`list[1:]`) and zip object, allocating O(N) memory and causing garbage collection overhead.
**Action:** Calculate the metric (e.g. state changes) inside the primary loop by caching the previous state in a local variable (e.g., `last_chord`) to achieve O(1) memory and avoid intermediate list slice allocations.
13 changes: 5 additions & 8 deletions services/analysis-engine/src/bandscope_analysis/chords/section_harmony.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,14 +84,17 @@ def _summarize_one_section(
the portion of their duration that overlaps the window.
"""
durations: dict[str, float] = {}
overlapping_chords: list[str] = []
chord_changes = 0
last_chord: str | None = None

for seg_start, seg_end, chord in segments:
overlap = min(seg_end, section_end) - max(seg_start, section_start)
if overlap <= 0.0:
continue
durations[chord] = durations.get(chord, 0.0) + overlap
overlapping_chords.append(chord)
if last_chord is not None and last_chord != chord:
chord_changes += 1
last_chord = chord

chords: list[ChordDuration] = [
{"chord": chord, "duration": duration}
Expand All @@ -104,12 +107,6 @@ def _summarize_one_section(
main_chord = entry["chord"]
break

chord_changes = sum(
1
for previous, current in zip(overlapping_chords, overlapping_chords[1:], strict=False)
if previous != current
)

return {
"start_time": section_start,
"end_time": section_end,
Expand Down
Loading