feat(player): filter loops by rehearsal role - #1066
Merged
seonghobae merged 2 commits intoAug 30, 2026
Merged
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
section picker.
that role; switching back to All Roles restores every playable section.
when a role has no mapped playable section. This filters loop targets only;
it does not claim role-specific stem playback.
This PR is intentionally stacked on the exact current #1063 head:
e517a9875d9eae13113c56d7b2b433ed9a3a7888.Verification
52 passed.258 passedacross 23 files.469/469, branches357/357, functions105/105, lines454/454../scripts/harness/quickcheck.shpasses with the repository-pinned npm10.9.9 invocation: docs/security/supply-chain/bootstrap checks, ESLint,
Ruff, Bandit, mypy, desktop/shared-types tests and coverage, Python
679 passed, 24 skippedwith 100% coverage, and Vite build.The Python suite still prints the existing child Demucs/torch segmentation
fault traceback during one mocked CLI test; the parent pytest completes and
the harness exits successfully. This PR does not claim to fix that unrelated
runtime noise.
Security Notes
and role identifiers through own data descriptors before they become loop
selection authority.
or absent role filters retain the all-role view.
introduced. No stem playback claim is added.
aria-pressed, a role-specific group label, localizedstatus copy, visible focus styles, and existing minimum touch targets.
Dependency and supply-chain rationale
change.
RehearsalRoledata and transportsnapshot helpers; no new abstraction or runtime package is introduced.
in the full harness.
Reviewer checklist
approval before merge.