Skip to content

test(desktop): enforce full configured coverage - #1057

Open
seonghobae wants to merge 1 commit into
developfrom
codex/js-coverage-gate
Open

test(desktop): enforce full configured coverage#1057
seonghobae wants to merge 1 commit into
developfrom
codex/js-coverage-gate

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 29, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • raise the configured desktop Vitest coverage thresholds from 90% to 100% for lines, functions, branches, and statements
  • document the enforced coverage baseline and changelog entry

Verification

  • npm run test --workspace apps/desktop — 216 passed; 100% lines/functions/branches/statements
  • npm run lint --workspace apps/desktop
  • npm run typecheck --workspace apps/desktop
  • git diff --check
  • python3 scripts/checks/verify_docs.py

Security Notes

  • No new runtime boundary, dependency, URL, subprocess, IPC, file-ingestion, model, or export behavior is introduced.
  • The stricter test gate fails closed when configured desktop source coverage regresses.

Devin Review

@coderabbitai

coderabbitai Bot commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 58 seconds.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 3e41e4af-3754-45ab-9157-885da2392ba0

📥 Commits

Reviewing files that changed from the base of the PR and between 749511c and f6e7d6e.

📒 Files selected for processing (3)
  • CHANGELOG.md
  • apps/desktop/vite.config.ts
  • docs/engineering/acceptance-criteria.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@seonghobae

Copy link
Copy Markdown
Collaborator Author

Current-head coverage evidence for f6e7d6e6ee12bd0e6c8e378ca100aabb4f11352c exposed a central workspace-install defect: the trusted coverage lane discovered apps/desktop but checked only that directory for package-lock.json, while this npm workspace owns the lock at repository root. Central .github PR #1411 fixes the bounded ancestor-lock installation and adds a regression contract: ContextualWisdomLab/.github#1411

The product PR remains unchanged and its local/hosted product checks are passing; no merge is requested until the central coverage gate is repaired and fresh exact-head evidence is produced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant