π¨ Palette: Add tooltips to icon-only buttons - #1022
Conversation
β¦ded `title` attribute to icon-only buttons (Remove, Zoom, Pagination) in `ScoreView` and `ScoreViewer`.\n- Ensures mouse users get immediate visual feedback on hover.\n- Added journal entry for learning and future reference.
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning Review limit reachedNext included review available in 13 minutes. View limit detailsLimit details: Youβve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: βοΈ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: π Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| size="icon-lg" | ||
| className="size-14" | ||
| aria-label={t("scoreViewerPrevPage")} | ||
| title={t("scoreViewerPrevPage")} | ||
| disabled={pageNumber <= 1} |
There was a problem hiding this comment.
π Info: Tooltips on natively disabled page buttons stay hidden
The prev/next page buttons use the native disabled prop, so their new title tooltip cannot appear while disabled since native disabled elements suppress hover events. The repo's own palette.md note recommends aria-disabled for this exact reason.
Was this helpful? React with π or π to provide feedback.
|
Superseded by canonical Score accessibility owner #731 after a fresh exact-head comparison. #102248b3b24 adds only generic |
Understood. Acknowledging that this work is now obsolete and stopping work on this task. |
μ΄ PRμ μμ΄μ½ μ μ© λ²νΌ(μμ , νλ/μΆμ, νμ΄μ§ μ΄λ λ±)μ
titleμμ±μ μΆκ°νμ¬ λ§μ°μ€ μ¬μ©μμκ² ν΄νμ μ 곡νλ λ§μ΄ν¬λ‘ UX κ°μ μ¬νμ ν¬ν¨νκ³ μμ΅λλ€. μκ°μ νΌλλ°±μ κ°ννμ¬ μ κ·Όμ±μ λμ΄κ³ , ν΄λΉ λ΄μ©μ λν μλ‘μ΄ λ°°μμ.jules/palette.mdνμΌμ κΈ°λ‘νμμ΅λλ€. λͺ¨λ ν μ€νΈ λ° κ²μ¦μ 100% ν΅κ³Όνμ΅λλ€.PR created automatically by Jules for task 7536997803112486985 started by @seonghobae