feat(workspace): name tonight's first hook plan on the map by seonghobae · Pull Request #1017 · ContextualWisdomLab/bandscope

seonghobae · 2026-08-24T12:18:13Z

Product outcome

The mounted rehearsal workspace names tonight's first hook so a part can lock the melody before the room starts. Open moves to the matching rendered map section.

Customer-facing next action: Open Lead Vocal hook at 0:10 (demo). If no corroborated hook exists, stay on tonight's map for the next rehearsal cue.

Exact current identity

Protected base: develop@acdbea6344fe1231c39535b575f4de35e4c607c9.
Exact head: f899f46018dd137ba67109360767c154d8a9431e.
Branch: feat/workspace-first-hook-plan.

Scope and trust boundary

Owned hookPlan copy on an active, corroborated part plus labeled section and time.
Do not invent hook copy from groove, cue, simplification, overlap, range, chord labels, function labels, setup notes, transposition plans, fill plans, tuning plans, dynamics plans, articulation plans, confirmed overrides, harmonic explanations, or confidence notes.
Runtime hook-plan authority is the snapshotted own data-property descriptor value. A Proxy get trap cannot substitute different buyer-visible hook copy after the own-data check.
The shared exported RehearsalRole.hookPlan declaration documents that the field is rehearsal-facing hook guidance owned by the role only when runtime graph evidence corroborates it.
Distinct from first-fill-plan, first-setup-note, first-transposition-plan, first-tuning-plan, first-dynamics-plan, and first-articulation-plan.
Reduced-motion Open uses behavior: auto.
Korean next-action copy stays particle-safe (훅).

Exact-head verification state

Current review finding PRRT_kwDORjvEXs6bsI4m was verified against the previous head, repaired on the canonical branch with descriptive shared-type JSDoc, and resolved only after the exact new blob was refetched.

Fresh repository-native workflows for exact head f899f46018dd137ba67109360767c154d8a9431e are dispatched. At the latest refetch build-baseline is in progress and ci, release, security-audit, aggregate Security Scan, sbom, SAST Semgrep, bandit, and secret-scan-gate are queued. None of these non-terminal results is counted as success, and no predecessor-head evidence transfers.

Dependency / merge gate

fix(security): establish canonical npm, PDF.js, Nanoid, and Undici baseline #783 remains the canonical protected JavaScript dependency-security owner. Inherited pdfjs-dist / nanoid / undici findings are not copied or suppressed here.
Do not mix with 🔒 [보안] CLI 무제한 파일 읽기 취약점 수정 #811, Storybook tokens, or test(analysis): govern real YouTube known-stem benchmark #828.
Keep unmerged until the unchanged then-current head has every applicable repository/central CI, cross-platform build, exact owned statement+branch coverage, docstring, SAST/security/SBOM/supply-chain/package/release gate terminal-success; zero valid unresolved findings; a qualifying independent non-author last-push approval; and ordinary branch-protection acceptance.
Queued, pending, skipped, cancelled, failed, predecessor-head, protected-base, model-only, self/author, or administrative-bypass evidence is not success.

Summary by CodeRabbit

새로운 기능
- 워크스페이스에서 오늘의 첫 훅 계획을 확인하고 해당 곡 구조 구간으로 바로 이동할 수 있습니다.
- 훅 계획이 없을 때는 안내 메시지가 표시됩니다.
개선 사항
- 영어와 한국어 UI 및 섹션 라벨을 지원합니다.
- 동작 줄이기 설정에서는 즉시 이동합니다.
- 여러 워크스페이스에서도 올바른 곡 구조로 이동하며, 잘못된 정보는 안전하게 표시하지 않습니다.
문서
- 첫 훅 계획 안내와 탐색 동작에 대한 사용 지침을 추가했습니다.

Name the owning part, owned hookPlan copy, labeled section, and time so the next rehearsal action is obvious. Open moves to the matching map section. Do not invent hook copy from other rehearsal metadata.

coderabbitai · 2026-08-24T12:19:01Z

Warning

Review limit reached

Next included review available in 15 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 349e8d1d-91cd-47bd-8ea0-e7b7a8c17d79

📥 Commits

Reviewing files that changed from the base of the PR and between f899f46 and ffa1766.

📒 Files selected for processing (13)

.Jules/palette.md
.jules/palette.md
AGENTS.md
ARCHITECTURE.md
CHANGELOG.md
CLAUDE.md
apps/desktop/src/features/workspace/FirstHookPlanCallout.tsx
apps/desktop/src/features/workspace/Workspace.test.tsx
apps/desktop/src/features/workspace/Workspace.tsx
apps/desktop/src/features/workspace/firstHookPlan.proxy-authority.test.ts
apps/desktop/src/features/workspace/firstHookPlan.ts
apps/desktop/src/locales/en/common.json
apps/desktop/src/locales/ko/common.json

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 69e3e2af-2378-4a84-97f7-c73f50c76251

📥 Commits

Reviewing files that changed from the base of the PR and between 6d92ed2 and f899f46.

📒 Files selected for processing (1)

packages/shared-types/src/index.ts

🚧 Files skipped from review as they are similar to previous changes (1)

packages/shared-types/src/index.ts

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

Walkthrough

Rehearsal 역할에 hookPlan을 추가했습니다. 첫 번째 유효한 계획을 해석하는 resolver와 FirstHookPlanCallout을 구현했습니다. Workspace는 해당 섹션으로 이동하며, 영어·한국어와 reduced-motion 동작을 지원합니다.

Changes

첫 훅 계획 기능

Layer / File(s)	Summary
hookPlan 계약 및 해석 `packages/shared-types/src/index.ts`, `packages/shared-types/test/index.test.ts`, `apps/desktop/src/features/workspace/firstHookPlan.ts`, `apps/desktop/src/features/workspace/firstHookPlan*.test.ts`	`RehearsalRole`에 선택적 `hookPlan`을 추가했습니다. 런타임 입력, 활성 graph 역할, 시간 범위, 중복 ID를 검증하고 첫 계획을 결정합니다.
Workspace 콜아웃 및 섹션 탐색 `apps/desktop/src/features/workspace/FirstHookPlanCallout.tsx`, `apps/desktop/src/features/workspace/Workspace.tsx`, `apps/desktop/src/features/workspace/FirstHookPlanCallout.test.tsx`, `apps/desktop/src/features/workspace/Workspace.test.tsx`, `apps/desktop/src/i18n/`, `apps/desktop/src/locales/*`	지역화된 콜아웃과 Open 동작을 추가했습니다. Open 동작은 유일한 renderer-owned 섹션으로 이동하며, reduced-motion 설정에서는 즉시 스크롤합니다.
커버리지 계약 및 기능 문서 `apps/desktop/vite.config.ts`, `apps/desktop/src/features/workspace/coverageContract.test.ts`, `docs/design-system/component-contract.md`, `docs/doctoring/reduced-motion-first-hook-plan-navigation.md`, `AGENTS.md`, `ARCHITECTURE.md`, `CHANGELOG.md`, `CLAUDE.md`	새 프로덕션 파일을 커버리지 목록에 추가했습니다. 첫 훅 계획의 데이터 출처, 탐색 규칙, reduced-motion 동작을 문서화했습니다.

Estimated code review effort: 4 (Complex) | ~45 minutes

Merge Risk: ⚪ Minimal · up to f899f

This localized workspace feature is merge-ready after normal checks and review; no actionable merge-blocking risk remains.

Sequence Diagram(s)

sequenceDiagram
  participant Workspace
  participant FirstHookPlanCallout
  participant resolveFirstHookPlan
  participant SongStructureRenderer
  Workspace->>FirstHookPlanCallout: song 전달
  FirstHookPlanCallout->>resolveFirstHookPlan: 첫 hookPlan 해석
  FirstHookPlanCallout->>SongStructureRenderer: 대상 section으로 scrollIntoView
  SongStructureRenderer-->>FirstHookPlanCallout: 탐색 완료 상태 반환

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	제목은 워크스페이스에서 오늘 밤의 첫 훅 계획을 지도에 이름으로 표시하는 주요 변경 사항을 정확하게 요약합니다.
Docstring Coverage	✅ Passed	Docstring check was indeterminate for this PR — some files could not be analyzed in time. Not blocking.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch feat/workspace-first-hook-plan

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

seonghobae · 2026-08-24T14:52:16Z

@opencode-agent

Repair only canonical BandScope PR #1017 branch feat/workspace-first-hook-plan at exact head 6d92ed24f5695d6c130c1df9f6353f641c49a47b if that head is still current; if it moved, refetch the intervening delta first and adapt instead of overwriting another writer.

Current-head review finding PRRT_kwDORjvEXs6bsI4m is valid and narrowly scoped: packages/shared-types/src/index.ts extends the exported RehearsalRole contract with hookPlan?: string but leaves that new field undocumented. Add a beginner-readable JSDoc immediately above hookPlan that states this copy is owned by the rehearsable part and represents its corroborated hook plan. Do not change the type, runtime behavior, dependency files, coverage thresholds, navigation logic, or #783-owned security state.

Run the shared-types lint/typecheck/tests and the applicable repository quickcheck, commit only this JSDoc repair to the same branch, and report the exact successor head plus verification evidence. Do not create another PR, merge, force-push, self-approve, or weaken protection.

seonghobae · 2026-08-26T06:38:39Z

Re-review request for exact head 90732b7fed0523f5ee5817b76151e7fb6a2bffc7: all required status contexts are green on this head (including coverage-evidence and security scans) and all review threads are resolved. @opencode-agent please review current head 90732b7fed0523f5ee5817b76151e7fb6a2bffc7 and update the review decision.

# Conflicts: # AGENTS.md # CHANGELOG.md # CLAUDE.md # apps/desktop/src/features/workspace/Workspace.tsx # apps/desktop/src/locales/en/common.json # apps/desktop/src/locales/ko/common.json

seonghobae · 2026-08-26T11:04:26Z

Resolved merge conflicts against origin/develop (749511c): union-merged AGENTS.md/CHANGELOG.md bullets, sentence-merged CLAUDE.md, kept both import sets in Workspace.tsx (FirstHookPlanCallout + firstRangeSqueeze), unioned en/ko locale tails (JSON valid, en/ko symmetric). Merged legacy .Jules/palette.md into canonical .jules/palette.md, dropped alias. No conflict markers remain. Merge head: ffa1766.

devin-ai-integration

Devin Review found 1 new potential issue.

feat(workspace): name tonight's first hook plan on the map

6d92ed2

Name the owning part, owned hookPlan copy, labeled section, and time so the next rehearsal action is obvious. Open moves to the matching map section. Do not invent hook copy from other rehearsal metadata.

This comment was marked as resolved.

Sign in to view

docs(shared-types): document hook plan ownership

f899f46

This comment was marked as resolved.

Sign in to view

seonghobae added 4 commits August 24, 2026 15:45

test(workspace): pin hook-plan runtime authority

07aac47

fix(workspace): snapshot hook-plan runtime authority

975f56d

fix(workspace): consume hook-plan authority snapshots

dcbbd4c

docs(changelog): record hook-plan authority snapshots

fd86742

This comment was marked as resolved.

Sign in to view

fix(changelog): restore 0.1.0 issue history

c27d583

This comment was marked as resolved.

Sign in to view

Merge branch 'develop' into feat/workspace-first-hook-plan

90732b7

Merge remote-tracking branch 'origin/develop' into HEAD

ffa1766

# Conflicts: # AGENTS.md # CHANGELOG.md # CLAUDE.md # apps/desktop/src/features/workspace/Workspace.tsx # apps/desktop/src/locales/en/common.json # apps/desktop/src/locales/ko/common.json

devin-ai-integration Bot reviewed Aug 26, 2026

View reviewed changes

Comment thread apps/desktop/src/features/workspace/FirstHookPlanCallout.tsx

Navigation Menu

Uh oh!

feat(workspace): name tonight's first hook plan on the map - #1017

feat(workspace): name tonight's first hook plan on the map#1017
seonghobae wants to merge 9 commits into
developfrom
feat/workspace-first-hook-plan

seonghobae commented Aug 24, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Aug 24, 2026 •

edited

Loading

Review limit reached

Walkthrough

Changes

Sequence Diagram(s)

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

seonghobae commented Aug 24, 2026

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

seonghobae commented Aug 26, 2026

Uh oh!

seonghobae commented Aug 26, 2026

Uh oh!

devin-ai-integration Bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

seonghobae commented Aug 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Product outcome

Exact current identity

Scope and trust boundary

Exact-head verification state

Dependency / merge gate

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Aug 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Walkthrough

Changes

Sequence Diagram(s)

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

seonghobae commented Aug 24, 2026

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

seonghobae commented Aug 26, 2026

Uh oh!

seonghobae commented Aug 26, 2026

Uh oh!

devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

seonghobae commented Aug 24, 2026 •

edited

Loading

coderabbitai Bot commented Aug 24, 2026 •

edited

Loading