feat(event): score CHRONOS schema slots with precision and recall - #70
Conversation
|
Warning Review limit reached
Next review available in: 42 minutes Limit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?Wait for the limit to reset, then comment An organization admin can change what happens after included review limits in Billing. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthrough
ChangesCHRONOS 스키마 슬롯
Estimated code review effort: 3 (Moderate) | ~25 minutes Merge Risk: 🔵 Low · up to The PR adds schema-slot scoring and prediction-refusal behavior, while the remaining merge-readiness risk is limited to clarifying source attribution and documenting exact reproducibility details; it is mergeable with explicit owner follow-up. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Predicted role fillers stay hypothetical. Slot precision/recall and occupancy RMSE are computed from known truth; schema predictions cannot become instances or transitions.
19b8770 to
9b09f14
Compare
# Conflicts: # CHANGELOG.md # docs/TRACEABILITY.md
|
Revalidated at current HEAD
Please run protected current-head Checks and obtain an independent qualifying approval before normal merge. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
@opencode-agent review exact current HEAD |
|
Revalidated exact current HEAD |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Addressed the new current-head citation-scope finding on exact SHA |
|
Revalidated the concurrent current head dae7e55. Pinned Rust 1.97.1 event_core tests pass: 5 unit, 1 crate contract, 4 mention/instance, 5 schema-slot, and doctests. event_core clippy with warnings denied, documentation/workspace/docstring contracts, quality tests (89 passed, 18 subtests), and git diff check pass. All current review threads are resolved; protected current-head Checks and qualifying independent approval remain required. |
|
Current-head review refresh for dae7e55:
|
|
Exact-head maintenance receipt for PR #70. Current head: Rebased by a normal merge commit and resolved only the documented CHANGELOG/ADR/connector overlap while retaining both the CHRONOS schema-slot work and current naruon live-listener evidence. Exact-head local proof passed: Rust 1.97.1 This is not a review or approval. Please evaluate this exact head with current required Checks and independent review. @cwl-noema-review @opencode-agent |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Exact-head update 7a1f33a: normalized both CHRONOS and naruon CHANGELOG entries to the canonical dash-prefixed list, eliminating the detached-list formatting defect while preserving the event metric entry. Revalidated full offline workspace tests, clippy with warnings denied, formatting, documentation/workspace contracts, diff whitespace, CodeGraph, and CodeReviewGraph. Please run fresh independent OpenCode/Noema review against this HEAD. |
![opencode-agent[bot]](https://avatars.githubusercontent.com/in/1549082?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current head7a1f33aa68c1c9be9e9da7ac7f7dadb1092ff9e4. -
Head SHA:
7a1f33aa68c1c9be9e9da7ac7f7dadb1092ff9e4 -
Workflow run: 32636793264
-
Workflow attempt: 1
Coverage evidence
Coverage Decision
- Result: FAIL
- Test evidence: not proven passing
- Docstring evidence: not proven passing when configured
- Failure count: 1
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (5 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (5 files)"]
R1 --> V1["required checks"]
Evidence --> S2["Docs (11 files)"]
S2 --> I2["operator or user guidance"]
I2 --> R2["Review risk: Docs (11 files)"]
R2 --> V2["docs review"]
OpenCode Review Overview
Pull request overviewOpenCode cannot approve yet because required coverage evidence did not pass. Review outcome1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
Coverage evidenceCoverage Decision
Changed-File Evidence Mapflowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (5 files)"]
S1 --> I1["repository behavior"]
I1 --> Conflict["Merge conflict blocks this path"]
Conflict --> V1["required checks"]
Evidence --> S2["Docs (11 files)"]
S2 --> I2["operator or user guidance"]
I2 --> Conflict["Merge conflict blocks this path"]
Conflict --> V2["docs review"]
Merge Conflict Guidance
gh pr checkout 70 --repo ContextualWisdomLab/TEPP
git fetch origin main
git merge --no-ff origin/main # or: git rebase origin/main
git status --short
# resolve files, then git add <resolved-files>
# merge path: git commit
# rebase path: git rebase --continue
git push origin HEAD:agent/event-chronos-schema-slots
# rebase path only: git push --force-with-lease origin HEAD:agent/event-chronos-schema-slots |
Stale coverage-evidence CHANGES_REQUESTED. Exact head 7a1f33a has coverage-evidence success. Not an approval.
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current head7a1f33aa68c1c9be9e9da7ac7f7dadb1092ff9e4. -
Head SHA:
7a1f33aa68c1c9be9e9da7ac7f7dadb1092ff9e4 -
Workflow run: 32699609399
-
Workflow attempt: 1
Coverage evidence
Coverage Decision
- Result: FAIL
- Test evidence: not proven passing
- Docstring evidence: not proven passing when configured
- Failure count: 1
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (5 files)"]
S1 --> I1["repository behavior"]
I1 --> Conflict["Merge conflict blocks this path"]
Conflict --> V1["required checks"]
Evidence --> S2["Docs (11 files)"]
S2 --> I2["operator or user guidance"]
I2 --> Conflict["Merge conflict blocks this path"]
Conflict --> V2["docs review"]
1 participant
Summary
#45 remains preferred merge (
ed1349f, ready, MERGEABLE BLOCKED). CodeRabbit COMMENTED only; no qualifying independent APPROVE. Exact-head Checks were cancelled by a prior draft conversion, not failing tests. Do not self-approve or force-merge. Do not leapfrog #45 with #39.Next no-0008 gap: ADR 0016 CHRONOS schema-slot precision/recall and prediction-versus-instance refusal in existing
event_core(does not recreate TDT/CHRONOS,topic_measurement,psychometric_core,compute_backend,concept_dictionary,model_selection, orinterpretation_gateway, and does not allocate 0008).refuse_schema_prediction_as_instance/refuse_schema_prediction_as_transitionnever promote a hypothesized slot-fillschema_slot_precisionandschema_slot_recallfail closed on empty or duplicate(role, argument)fill setsdecide_schema_slotuses an inclusive occupancy thresholdTest plan
schema_slot_contractfailed to compile beforeschema.rsexistedcargo test -p event_core --offline --lib --testscargo clippy -p event_core --all-targets --offline -- -D warningscargo test --workspace --offlinepython3 scripts/validate_documentation.pyand docstring/workspace contractsDo not self-approve or merge. Prefer merge #45 when exact-head required checks and a qualifying independent APPROVE exist. Do not allocate 0008.
Summary by CodeRabbit
새로운 기능
문서
테스트