-
Notifications
You must be signed in to change notification settings - Fork 0
test(persistence): cover uppercase-label and scanner edge branches #219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 📝 Info: Contradictory duplicated docstring on validate The (Refers to this code) Was this helpful? React with 👍 or 👎 to provide feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 Info: Redundant byte gate in label validation
The
is_ascii_alphanumeric() || byte == b'_'byte check invalidate_entity_label/validate_project_label(entity_sql.rs) is fully subsumed by the stricter final clause requiring lowercase/digit/underscore. It cannot independently reject any input, which is why the newAUTHOR/ACTIVEcases are needed to exercise the last operand.(Refers to this code)
Was this helpful? React with 👍 or 👎 to provide feedback.