-
Notifications
You must be signed in to change notification settings - Fork 0
feat(method): refuse copied-text residue as unique content #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
5202e1f
feat(method): refuse copied-text residue as unique content
seonghobae c1833ee
Merge remote-tracking branch 'origin/main' into review/pr149-current
seonghobae 101d10f
test: derive crate contract from workspace manifest
seonghobae e0fa669
docs: remove duplicate provider payload ledger row
seonghobae 6077b9c
Merge current main into copied text gate
seonghobae 61aac2e
chore: keep CodeGraph state local
seonghobae fede261
Merge remote-tracking branch 'origin/main' into agent/copied-text
seonghobae eee6d3b
chore: regenerate Cargo.lock after main merge
seonghobae File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| [package] | ||
| name = "copied_text" | ||
| description = "Copied-text residue is not unique content and not stopword deletion." | ||
| version.workspace = true | ||
| edition.workspace = true | ||
| rust-version.workspace = true | ||
| license.workspace = true | ||
| authors.workspace = true | ||
| repository.workspace = true | ||
| homepage.workspace = true | ||
| readme.workspace = true | ||
| keywords.workspace = true | ||
| categories.workspace = true | ||
| publish = false | ||
|
|
||
| [lints] | ||
| workspace = true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| //! Fail-closed copied-text errors. | ||
|
|
||
| use std::fmt; | ||
|
|
||
| /// A fail-closed copied-text error. | ||
| #[derive(Clone, Copy, Debug, Eq, PartialEq)] | ||
| #[non_exhaustive] | ||
| pub enum CopiedTextError { | ||
| /// Copied-text residue was treated as unique latent content. | ||
| CopiedTextIsNotUniqueContent, | ||
| /// Copied-text residue was treated as stopword deletion. | ||
| CopiedTextIsNotStopwordDeletion, | ||
| /// A recovery slice was empty or length-mismatched. | ||
| InvalidCopiedPayload, | ||
| } | ||
|
|
||
| impl fmt::Display for CopiedTextError { | ||
| fn fmt(&self, formatter: &mut fmt::Formatter<'_>) -> fmt::Result { | ||
| let message = match self { | ||
| Self::CopiedTextIsNotUniqueContent => { | ||
| "copied-text residue is not unique latent content" | ||
| } | ||
| Self::CopiedTextIsNotStopwordDeletion => "copied-text residue is not stopword deletion", | ||
| Self::InvalidCopiedPayload => "invalid copied-text payload", | ||
| }; | ||
| formatter.write_str(message) | ||
| } | ||
| } | ||
|
|
||
| impl std::error::Error for CopiedTextError {} | ||
|
|
||
| #[cfg(test)] | ||
| mod tests { | ||
| use super::CopiedTextError; | ||
|
|
||
| #[test] | ||
| fn error_messages_are_stable() { | ||
| for (error, message) in [ | ||
| ( | ||
| CopiedTextError::CopiedTextIsNotUniqueContent, | ||
| "copied-text residue is not unique latent content", | ||
| ), | ||
| ( | ||
| CopiedTextError::CopiedTextIsNotStopwordDeletion, | ||
| "copied-text residue is not stopword deletion", | ||
| ), | ||
| ( | ||
| CopiedTextError::InvalidCopiedPayload, | ||
| "invalid copied-text payload", | ||
| ), | ||
| ] { | ||
| assert_eq!(error.to_string(), message); | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,128 @@ | ||
| //! Copied-text residue versus unique latent content. | ||
|
|
||
| use crate::CopiedTextError; | ||
|
|
||
| /// Closed vocabulary of copied-text token treatments. | ||
| #[derive(Clone, Copy, Debug, Eq, PartialEq)] | ||
| pub enum CopiedKind { | ||
| /// Copied or boilerplate residue, not unique document meaning. | ||
| CopiedText, | ||
| /// Token treatment reserved for unique latent content. | ||
| UniqueContent, | ||
| } | ||
|
|
||
| impl CopiedKind { | ||
| /// Return the stable wire kind name. | ||
| #[must_use] | ||
| pub const fn wire_name(self) -> &'static str { | ||
| match self { | ||
| Self::CopiedText => "copied_text", | ||
| Self::UniqueContent => "unique_content", | ||
| } | ||
| } | ||
|
|
||
| /// Parse a stable wire kind name. | ||
| /// | ||
| /// # Errors | ||
| /// | ||
| /// Returns [`CopiedTextError::InvalidCopiedPayload`] for unrecognized names. | ||
| pub fn from_wire_name(name: &str) -> Result<Self, CopiedTextError> { | ||
| match name { | ||
| "copied_text" => Ok(Self::CopiedText), | ||
| "unique_content" => Ok(Self::UniqueContent), | ||
| _ => Err(CopiedTextError::InvalidCopiedPayload), | ||
| } | ||
| } | ||
| } | ||
|
|
||
| /// Refuse to treat copied-text residue as unique latent content. | ||
| /// | ||
| /// # Errors | ||
| /// | ||
| /// Returns [`CopiedTextError::CopiedTextIsNotUniqueContent`] when `kind` is | ||
| /// [`CopiedKind::CopiedText`]. | ||
| pub fn refuse_copied_text_as_unique_content(kind: CopiedKind) -> Result<(), CopiedTextError> { | ||
| match kind { | ||
| CopiedKind::CopiedText => Err(CopiedTextError::CopiedTextIsNotUniqueContent), | ||
| CopiedKind::UniqueContent => Ok(()), | ||
| } | ||
| } | ||
|
|
||
| /// Refuse to treat copied-text residue as stopword deletion. | ||
| /// | ||
| /// # Errors | ||
| /// | ||
| /// Returns [`CopiedTextError::CopiedTextIsNotStopwordDeletion`] when `kind` is | ||
| /// [`CopiedKind::CopiedText`]. | ||
| pub fn refuse_copied_text_as_stopword_deletion(kind: CopiedKind) -> Result<(), CopiedTextError> { | ||
| match kind { | ||
| CopiedKind::CopiedText => Err(CopiedTextError::CopiedTextIsNotStopwordDeletion), | ||
| CopiedKind::UniqueContent => Ok(()), | ||
| } | ||
| } | ||
|
|
||
| /// Fraction of recovered copied-text kinds that match known truth. | ||
| /// | ||
| /// # Errors | ||
| /// | ||
| /// Returns [`CopiedTextError::InvalidCopiedPayload`] when either slice is | ||
| /// empty or the lengths differ. | ||
| pub fn identity_recovery_rate( | ||
| truth: &[CopiedKind], | ||
| decided: &[CopiedKind], | ||
| ) -> Result<f64, CopiedTextError> { | ||
| if truth.is_empty() || truth.len() != decided.len() { | ||
| return Err(CopiedTextError::InvalidCopiedPayload); | ||
| } | ||
| let mut matches = 0_u32; | ||
| for (truth_kind, decided_kind) in truth.iter().zip(decided) { | ||
| if truth_kind == decided_kind { | ||
| matches += 1; | ||
| } | ||
| } | ||
| Ok(f64::from(matches) / truth.len() as f64) | ||
| } | ||
|
|
||
| #[cfg(test)] | ||
| mod tests { | ||
| use super::{ | ||
| CopiedKind, identity_recovery_rate, refuse_copied_text_as_stopword_deletion, | ||
| refuse_copied_text_as_unique_content, | ||
| }; | ||
| use crate::CopiedTextError; | ||
|
|
||
| #[test] | ||
| fn local_branches_cover_kinds_payloads_and_wire_names() { | ||
| assert_eq!( | ||
| refuse_copied_text_as_unique_content(CopiedKind::CopiedText), | ||
| Err(CopiedTextError::CopiedTextIsNotUniqueContent) | ||
| ); | ||
| assert_eq!( | ||
| refuse_copied_text_as_stopword_deletion(CopiedKind::CopiedText), | ||
| Err(CopiedTextError::CopiedTextIsNotStopwordDeletion) | ||
| ); | ||
| refuse_copied_text_as_unique_content(CopiedKind::UniqueContent).expect("unique"); | ||
| refuse_copied_text_as_stopword_deletion(CopiedKind::UniqueContent).expect("unique"); | ||
| for kind in [CopiedKind::CopiedText, CopiedKind::UniqueContent] { | ||
| assert_eq!( | ||
| CopiedKind::from_wire_name(kind.wire_name()).expect("round-trip"), | ||
| kind | ||
| ); | ||
| } | ||
| assert_eq!( | ||
| CopiedKind::from_wire_name("stopword"), | ||
| Err(CopiedTextError::InvalidCopiedPayload) | ||
| ); | ||
| let matched = identity_recovery_rate(&[CopiedKind::CopiedText], &[CopiedKind::CopiedText]) | ||
| .expect("rate"); | ||
| assert!((matched - 1.0).abs() < f64::EPSILON); | ||
| assert_eq!( | ||
| identity_recovery_rate(&[], &[]), | ||
| Err(CopiedTextError::InvalidCopiedPayload) | ||
| ); | ||
| assert_eq!( | ||
| identity_recovery_rate(&[CopiedKind::CopiedText], &[]), | ||
| Err(CopiedTextError::InvalidCopiedPayload) | ||
| ); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| #![forbid(unsafe_code)] | ||
| #![deny(missing_docs)] | ||
| #![allow(clippy::cast_precision_loss)] | ||
| //! Copied-text residue is not unique latent content. | ||
| //! | ||
| //! Copied and boilerplate passages stay explicit method/background structure. | ||
| //! They are not unique document meaning and are not erased by a stopword list | ||
| //! (ADR 0004/0012). | ||
|
|
||
| mod error; | ||
| mod kind; | ||
|
|
||
| /// Fail-closed copied-text errors. | ||
| pub use error::CopiedTextError; | ||
| /// Closed vocabulary of copied-text token treatments. | ||
| pub use kind::CopiedKind; | ||
| /// Fraction of recovered copied-text kinds that match known truth. | ||
| pub use kind::identity_recovery_rate; | ||
| /// Refuse to treat copied-text residue as stopword deletion. | ||
| pub use kind::refuse_copied_text_as_stopword_deletion; | ||
| /// Refuse to treat copied-text residue as unique latent content. | ||
| pub use kind::refuse_copied_text_as_unique_content; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| //! Copied-text residue is not unique content and not stopword deletion. | ||
|
|
||
| use copied_text::{ | ||
| CopiedKind, CopiedTextError, identity_recovery_rate, refuse_copied_text_as_stopword_deletion, | ||
| refuse_copied_text_as_unique_content, | ||
| }; | ||
|
|
||
| #[test] | ||
| fn copied_text_cannot_become_unique_content_or_stopword_deletion() { | ||
| assert_eq!( | ||
| refuse_copied_text_as_unique_content(CopiedKind::CopiedText), | ||
| Err(CopiedTextError::CopiedTextIsNotUniqueContent) | ||
| ); | ||
| assert_eq!( | ||
| refuse_copied_text_as_stopword_deletion(CopiedKind::CopiedText), | ||
| Err(CopiedTextError::CopiedTextIsNotStopwordDeletion) | ||
| ); | ||
| refuse_copied_text_as_unique_content(CopiedKind::UniqueContent).expect("unique"); | ||
| refuse_copied_text_as_stopword_deletion(CopiedKind::UniqueContent).expect("unique"); | ||
| } | ||
|
|
||
| #[test] | ||
| fn recovered_kinds_match_known_truth_better_than_a_unique_content_collapse() { | ||
| let truth = [ | ||
| CopiedKind::CopiedText, | ||
| CopiedKind::UniqueContent, | ||
| CopiedKind::CopiedText, | ||
| ]; | ||
| let recovered = truth; | ||
| let collapsed = [ | ||
| CopiedKind::UniqueContent, | ||
| CopiedKind::UniqueContent, | ||
| CopiedKind::UniqueContent, | ||
| ]; | ||
| let recovered_rate = identity_recovery_rate(&truth, &recovered).expect("recovered"); | ||
| let collapsed_rate = identity_recovery_rate(&truth, &collapsed).expect("collapsed"); | ||
| let expected = { | ||
| let mut matches = 0_u32; | ||
| for (truth_kind, decided_kind) in truth.iter().zip(recovered.iter()) { | ||
| if truth_kind == decided_kind { | ||
| matches += 1; | ||
| } | ||
| } | ||
| f64::from(matches) / f64::from(u32::try_from(truth.len()).expect("len")) | ||
| }; | ||
| assert!((recovered_rate - expected).abs() < f64::EPSILON); | ||
| assert!(recovered_rate > collapsed_rate); | ||
| } | ||
|
|
||
| #[test] | ||
| fn empty_or_mismatched_kind_payloads_fail_closed() { | ||
| assert_eq!( | ||
| identity_recovery_rate(&[], &[]), | ||
| Err(CopiedTextError::InvalidCopiedPayload) | ||
| ); | ||
| assert_eq!( | ||
| identity_recovery_rate(&[CopiedKind::CopiedText], &[]), | ||
| Err(CopiedTextError::InvalidCopiedPayload) | ||
| ); | ||
| assert_eq!( | ||
| identity_recovery_rate( | ||
| &[CopiedKind::CopiedText, CopiedKind::UniqueContent], | ||
| &[CopiedKind::CopiedText] | ||
| ), | ||
| Err(CopiedTextError::InvalidCopiedPayload) | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| //! Integration contract for the `copied_text` package identity. | ||
|
|
||
| #[test] | ||
| fn package_identity_is_stable() { | ||
| let observed = std::hint::black_box(env!("CARGO_PKG_NAME")); | ||
| assert_eq!(observed, "copied_text"); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
docs/adr/0012-temporal-relational-shared-latent-topic-measurement.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 Info: identity_recovery_rate logic is correct and fail-closed
identity_recovery_ratein kind.rs correctly rejects empty and length-mismatched inputs before computing, and returnsmatches / lenover paired kinds. Theu32match counter would only overflow beyond ~4 billion elements, which is not a realistic concern. Theclippy::cast_precision_lossallow at lib.rs covers thetruth.len() as f64cast. No correctness issue.Was this helpful? React with 👍 or 👎 to provide feedback.