test(browser): bound ordinary teardown to one deadline - #150
Draft
seonghobae wants to merge 7 commits into
Draft
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
marked this pull request as ready for review
August 14, 2026 04:41
seonghobae
marked this pull request as draft
August 14, 2026 08:09
seonghobae
marked this pull request as ready for review
August 14, 2026 08:18
…teardown deadline - Resolve run_mv3_compatibility.py by keeping the ordinary-teardown process-set termination evidence computation alongside the realigned parent's session/driver cleanup-failure classification. - Resolve CHANGELOG.md by keeping the parent's refined pinned-Chromium identity entry plus this lane's forced-close and ordinary teardown shared-deadline entries. - Update the shared-teardown contract to assert the same one-waiter ordering invariant against the realigned bounded termination helpers.
seonghobae
marked this pull request as draft
August 27, 2026 01:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial implementation of #28, stacked on live PR #147 branch
test/agent-task-forced-close-shared-teardown-deadline.Falsifiable defect
Ordinary controlled Agent Task teardown previously waited for the exact browser-root identity and the already sampled Chromium process set with two independent bounded waits. A slow or stuck teardown could therefore consume the configured timeout twice even though the product evidence describes one bounded teardown phase.
RED -> RCA -> GREEN
Noneremains preserved when no complete process set was captured.CHANGELOG.mdrecords this exact behavioral boundary and its limits; no cgroup/task ownership, post-snapshot process discovery, cross-platform supervision, or OS-wide orphan-absence claim is added.Fresh stack reconstruction
The live prerequisite #147 moved to exact
962e179b53ed0342fde5b50c3deac0e7454b0d4fafter this child was last validated. The child was therefore reconstructed non-destructively from GitHub's current conflict-free synthetic merge tree, preserving both the prerequisite changes and this PR's unique ordinary-teardown delta.Current exact head:
f42b388d92c03a2f2ccbe7ca07803e5f5d2aea44.Exact prerequisite/base head:
962e179b53ed0342fde5b50c3deac0e7454b0d4f.Fresh ancestry comparison: 7 commits ahead / 0 behind, with merge base exactly the current prerequisite head.
The previous exact-head CI/coverage/MV3 evidence belongs to predecessor
4da223ac612ea52c04022f5380919ce85a868d15and is not promoted to the reconstructed head. Fresh exact-head checks and review evidence must complete onf42b388d92c03a2f2ccbe7ca07803e5f5d2aea44before this child can advance.Truth boundary
This proves only bounded ordinary controlled Linux/pinned-Chromium teardown observation for the exact browser root and the already sampled Chromium process set. It does not claim cgroup/task ownership, discover processes created after the sample, prove OS-wide orphan absence, authenticate Chromium/ChromeDriver provenance, implement cross-platform supervision, or turn this CI compatibility runner into a product browser API.
The scheduled actor does not merge to protected main, self-approve, force-push, alter workflows/rulesets/secrets, tag, release, or publish.