fix(core): bind protocol dispatch to observed document epoch - #127
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 16, 2026
seonghobae
marked this pull request as ready for review
August 26, 2026 21:09
seonghobae
merged commit Aug 26, 2026
987322a
into
feat/browser-context-origin-protocol-dispatch
5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial implementation of #28, stacked on exact PR #120 head
144895d5b86ca6b4cceeb0653638e41e9578f130.Buyer/security gap
PR #120 revalidates exact browser session, browsing context, canonical origin, and protocol metadata immediately before one callback, but it deliberately returns the registry's current
DocumentEpochinstead of comparing that epoch with the document that produced the caller's observation/action intent. A same-origin navigation can advance the document epoch, rebind the same canonical origin, and still satisfy the PR #120 origin boundary. For typed input, issue #28 requires the exact observed document epoch to remain current before the side effect.Dependency
This Draft still targets independently refetched exact #120 head
144895d5b86ca6b4cceeb0653638e41e9578f130and must remain Draft while #120 and its prerequisites remain active. No prerequisite check, review, status, coverage, mergeability, or synthetic merge evidence transfers.TDD and implementation proof
The test-only predecessor
97d2a896c204c3245f56445c351c2d01168991bcdefined the missing same-call epoch contract before production support. The current exact head3d00eb5c9bcb3258550bc8e75e6bedf9d0b9f01bnow implements that contract by:DocumentEpoch;DocumentEpochMismatchwhen a same-origin new document has replaced the observed document;At exact head
3d00eb5c9bcb3258550bc8e75e6bedf9d0b9f01b, repository CI run31611351981and Manifest V3 Compatibility run31611352072both completed successfully. The branch remains Draft solely because its exact base is an active stacked prerequisite, not because predecessor evidence is being reused.Truth boundary
This deterministic composition does not authenticate the adapter/browser process, derive the origin or epoch from Chromium, decide when browser mutation must rotate the epoch, authorize destination/network/TLS/HTTP, perform browser I/O, grant Agent policy approval, validate semantic node state, or prove a post-condition. A trusted runtime must derive the observed epoch from the exact observation used to construct the action and supply it immediately before dispatch.