-
Notifications
You must be signed in to change notification settings - Fork 1
feat(ontology): search assertion-backed occupational constructs #755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
e6017d3
feat(ontology): search assertion-backed occupational constructs
seonghobae d5e3ac5
fix(ui): type-only FormEvent import for verbatimModuleSyntax
seonghobae 5bba647
docs(ontology): cite occupational construct catalog search (ADR 0256)
774727f
fix(search): preserve complete authorized construct pages
9486231
docs(gap): reconcile exact-head authority collisions
6d3d714
fix(frontend): restore export keyword on search hit interface
d8ffcbb
fix(frontend): restore closing brace and export keyword in api graft
1160fd3
docs(adr): renumber construct-catalog-search to ADR 0265
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,3 +7,6 @@ __pycache__/ | |
| .codegraph/ | ||
| .env | ||
| .coverage | ||
|
|
||
| # Local agent worktree scratch (never commit) | ||
| .worktrees/ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| # 2.20.0 — Authorized occupational construct catalog search | ||
|
|
||
| - Reviewers can search official O*NET cognitive-ability, work-style, and | ||
| work-activity labels from the ontology explorer and open the earliest | ||
| visible supporting record (ADR 0257). | ||
| - Hits require source-eligible, ABAC-visible assertion evidence. Hidden | ||
| Posts, withdrawn truth, and conflicting truth statuses stay omitted. | ||
| - Continuation uses a construct-IRI keyset. OFFSET, scores, person traits, | ||
| and catalog-only oracles remain unavailable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -49,7 +49,8 @@ cutoff. Global Ask optional `knowledge_cutoff` uses the same cover | |||||||||
|
|
||||||||||
| Create/start endpoint rules (ADR 0017 / 0021), tie-vs-miss similarity | ||||||||||
| (ADR 0026), R&R catalog ids (ADR 0019 / 0027), leftover pairs | ||||||||||
| (ADR 0048–0164 / 0182 / 0185 / 0201 / 0233), the text-channel embedding swap and cosine | ||||||||||
| (ADR 0048–0164 / 0182 / 0185 / 0201 / 0233), occupational construct catalog search | ||||||||||
| (ADR 0257), the text-channel embedding swap and cosine | ||||||||||
|
Comment on lines
+52
to
+53
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟡 CLAUDE.md cites the wrong ADR for catalog search The pointer attributes occupational construct catalog search to ADR 0257, the accepted occupation-rating observation store. The feature is ADR 0265.
Suggested change
Was this helpful? React with 👍 or 👎 to provide feedback. |
||||||||||
| clamp (ADR 0190), per-edge channel-score persistence (ADR 0195), | ||||||||||
| migration replay (ADR 0166), docstring coverage, and the measurement | ||||||||||
| boundary are all stated in [AGENTS.md](AGENTS.md) -- read it before | ||||||||||
|
|
||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 AGENTS.md cites the wrong ADR for catalog search
This paragraph attributes catalog search to ADR 0257, which is the accepted occupation-rating observation store. The governing decision is ADR 0265.
Was this helpful? React with 👍 or 👎 to provide feedback.