Skip to content

ci: cancel stale test runs when PR closes - #720

Merged
seonghobae merged 2 commits into
mainfrom
fix/pr-close-cancels-stale-tests
Aug 27, 2026
Merged

ci: cancel stale test runs when PR closes#720
seonghobae merged 2 commits into
mainfrom
fix/pr-close-cancels-stale-tests

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Summary

  • key pull-request test concurrency by PR number so a closed event cancels an older synchronize run even when GitHub changes the ref
  • retain the closed-event job skip contract
  • add a static workflow regression test

Evidence

  • uv run --extra dev pytest -q tests/test_tests_workflow_contract.py tests/test_documentation_hygiene.py — 6 passed
  • actionlint .github/workflows/tests.yml — passed
  • git diff --check — passed

This repairs the recurrence path observed after stacked PR #715 merged. It does not weaken required checks or cancel runs for open PRs or main.


Open in Devin Review

@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 18 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: fa1cffe6-90cd-462c-b852-0c00ad00ee28

📥 Commits

Reviewing files that changed from the base of the PR and between ff7431b and dda0531.

📒 Files selected for processing (2)
  • .github/workflows/tests.yml
  • tests/test_tests_workflow_contract.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae enabled auto-merge (squash) August 26, 2026 16:27

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Open in Devin Review

Comment thread tests/test_tests_workflow_contract.py
@seonghobae
seonghobae merged commit 37dbd00 into main Aug 27, 2026
33 of 36 checks passed
seonghobae added a commit that referenced this pull request Aug 27, 2026
Persist leftover-map unexplained leftover share s = U² / R² of raw
residual on leftover post–criterion pairs so the leftover the truncated
two-axis map cannot reconstruct is not read as leftover residual R,
leftover-map distance d, unexplained leftover U, or leftover-map cross
share x. Do not persist leftover-map explained share e.

After make seed, closest and farthest leftover pairs sit above the
member list with U²/R² next to leftover-map distance d; click opens
that post. Missing or non-finite share omits the badge rather than
inventing a leftover score. A share greater than 1 is stored, never
clamped. The grouping comparison strip stays on its reduced leftover
payload (distance, residual, reconstruction).

Independent of leftover stacks #640, #680, #720 and dashboard explained
share ADR 0232 (#728).
seonghobae added a commit that referenced this pull request Aug 27, 2026
Persist leftover-map unexplained leftover share s = U² / R² of raw
residual on leftover post–criterion pairs so the leftover the truncated
two-axis map cannot reconstruct is not read as leftover residual R,
leftover-map distance d, unexplained leftover U, or leftover-map cross
share x. Do not persist leftover-map explained share e.

After make seed, closest and farthest leftover pairs sit above the
member list with U²/R² next to leftover-map distance d; click opens
that post. Missing or non-finite share omits the badge rather than
inventing a leftover score. A share greater than 1 is stored, never
clamped. The grouping comparison strip stays on its reduced leftover
payload (distance, residual, reconstruction).

Independent of leftover stacks #640, #680, #720 and dashboard explained
share ADR 0232 (#728).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant