feat(projects): expose evidence-bound history in post detail - #668
feat(projects): expose evidence-bound history in post detail#668seonghobae wants to merge 27 commits into
Conversation
|
Warning Review limit reachedNext included review available in 51 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (21)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Validated the current head 97c5d39 in a clean detached worktree: project-history unit and ingestion tests pass (4 passed). Hosted required Checks remain pending and independent approval is still required. |
|
Addressed the actionable project-history review edge at exact head facbae5: project-history action keys now use NFKC/case-normalized identity deduplication and choose a non-blank source-name fallback; added two focused frontend tests (2 passed). The far-focus behavior remains intentionally bounded to the selected authorized page and is documented as truncated evidence rather than a causal or complete history claim. |
|
Applied the review follow-up at exact head f272f4b: project-history fetch results now use a request sequence guard so late responses cannot overwrite a changed post/project; SQL normalization now applies NFKC before trimming, matching Python for compatibility whitespace. The focus-post cutoff 404 remains fail-closed by design because a post newer than knowledge_cutoff is not authorized evidence. Backend focused tests (4 passed) and frontend project-history tests (2 passed). |
|
Confirmed the two informational findings at exact head f272f4b: |
|
Fixed in
The focus-key and stale-response observations remain covered by the existing request-guard and matching-key tests; no additional code change is required for those informational findings. |
|
@coderabbitai review |
|
|
Confirmed at exact head |
# Conflicts: # docs/adr/README.md # docs/product-technical-gap-baseline.md
|
Superseded by #762. PR #668's branch was built on an old base carrying 8k deletions of main's newer content; #762 three-way merges only the additive project-history layer (endpoint, client, timeline component, tests; +2279/-0) onto current main. The popup UI hookup is tracked as a scoped follow-up inside #762 because main's post-detail component tree moved past the branch's assumption. |
Closes #280. Adds the ADR 0224 read projection over existing normalized project, responsibility, and Event Lineage evidence; applies RBAC, corporate-entity scope, process-unit scope, source eligibility, and knowledge cutoff before child reads; and mounts the accessible Storybook-tested timeline in the existing post-detail popup. Free text does not create lifecycle facts. Issue #284 remains the separate authoritative ingestion boundary.