Skip to content

fix(ui): clarify ontology node types with tokens - #659

Merged
seonghobae merged 8 commits into
ContextualWisdomLab:mainfrom
seonghobae:fix/ontology-node-readability-v2191
Aug 25, 2026
Merged

fix(ui): clarify ontology node types with tokens#659
seonghobae merged 8 commits into
ContextualWisdomLab:mainfrom
seonghobae:fix/ontology-node-readability-v2191

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Summary

  • map ADR 0184 Post, Person, CorporateEntity, and Team nodes to shared light/dark design tokens while preserving shape and text as the primary cues
  • add DOM mapping, token-consumption, and WCAG AA label-contrast regression tests
  • refresh the non-identifying exact-head gap baseline, including canonical ContextualWisdomLab/disksage casing and open ADR/migration allocation conflicts

Verification

  • frontend full Vitest: 41 files, 384 tests passed
  • focused OntologyExplorer/token Vitest after final contrast test: 2 files, 21 tests passed
  • frontend lint passed
  • frontend production build passed (the existing >500 kB warning remains owned by open PR perf(frontend): split conditional workspace surfaces #644)
  • Storybook production build passed
  • rendered Storybook audited at 1440x1100 and 402x1200; screenshots remain outside git

Runtime boundary

An exact main-based synthetic Compose attempt reached healthy PostgreSQL, migrations, Valkey, Keycloak, SearXNG, and contextual-orchestrator, but backend startup failed on the Settings.tepp_api_key contract and the full frontend image stopped on pnpm 11 esbuild build-script approval. Open PRs #629/#639 already own those root repairs, so this PR does not duplicate them and makes no k6 bottleneck claim.

Independent review required. No self-approval, admin bypass, or force push.


Open in Devin Review

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 22 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5829d46d-3ed3-48d3-96ea-af5846a6a8aa

📥 Commits

Reviewing files that changed from the base of the PR and between 7e9030c and ccdfc6f.

📒 Files selected for processing (9)
  • CHANGELOG.d/ontology-node-readability.md
  • docs/product-technical-gap-baseline.md
  • docs/storybook-inventory.md
  • frontend/src/App.css
  • frontend/src/components/OntologyExplorer.test.tsx
  • frontend/src/components/OntologyExplorer.tsx
  • frontend/src/ontologyExplorerCss.test.ts
  • frontend/src/styles/tokens.css
  • frontend/src/styles/tokens.test.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae enabled auto-merge (squash) August 25, 2026 18:40
devin-ai-integration[bot]

This comment was marked as resolved.

@seonghobae

Copy link
Copy Markdown
Contributor Author

Exact-head review at 3537948a74fa13fb2f0aa7b21f976459f64b3e5d: OntologyExplorer and design-token focused tests passed (21 passed), and frontend lint passed. No local defect identified; hosted checks and independent approvals remain required.

@seonghobae

Copy link
Copy Markdown
Contributor Author

Exact-head refresh at 2e3c6f1e928cbae631230e1fda6eb464e11ca7eb: ontology label contrast measurement tests remain green (21 passed) and frontend lint passes. The follow-up is test-only; no new defect identified.

devin-ai-integration[bot]

This comment was marked as resolved.

@opencode-agent
opencode-agent Bot disabled auto-merge August 25, 2026 18:56
@seonghobae
seonghobae enabled auto-merge (squash) August 25, 2026 18:56
devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

@seonghobae

Copy link
Copy Markdown
Contributor Author

The 402 px Storybook audit exposed a keyboard-accessibility gap in the horizontally scrollable Exact values table. I repaired the existing native CSS scroll pattern at exact head 0739b9d7:

  • the table viewport is now a named, focusable region;
  • touch overscroll containment, stable scrollbar space, and the existing token-backed focus ring are applied;
  • the focused Vitest contract passes (11/11), frontend lint passes, and Storybook rebuilds successfully;
  • screenshots were re-captured outside git at 402x1200 and 1440x1100, including an independently clicked Node evidence drawer. The narrow table remains intentionally horizontally scrollable rather than compressing or hiding exact fields.

No synthetic screenshot artifact was committed.

@seonghobae

Copy link
Copy Markdown
Contributor Author

Revalidated exact current head 0739b9d71ae2bb5c85709f907e55f90518ba9947 in an isolated worktree: frontend lint passed; Vitest 41 files / 386 tests passed; production build passed (Vite emitted only the existing >500 kB chunk advisory). Hosted checks and independent review remain required.

@seonghobae

Copy link
Copy Markdown
Contributor Author

Rebased the fork branch onto current protected-main base to resolve the documented baseline conflict. New exact head: ccdfc6f14fbfc49840a7d904560e140634b26338. Focused regression/docstring/documentation/migration/content tests: 90 passed. Hosted checks and independent review remain required; no merge claim.

@seonghobae
seonghobae merged commit 494b54e into ContextualWisdomLab:main Aug 25, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant