feat(dashboard): consume TEPP topic influence evidence - #650
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…o feat/dashboard-topic-influence-consumer # Conflicts: # docs/storybook-inventory.md # tests/test_operations_dashboard.py
|
Reviewed exact head The focused external-relation test needed an explicit unavailable topic-producer response; otherwise its mock returned a case row to the new topic query and failed with a missing Local evidence: |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| where {authorized_model_scope} | ||
| ) as fast_mlsirm_influence_persisted | ||
| """, | ||
| *args, |
There was a problem hiding this comment.
🔴 Dashboard crashes on every non-external request
_fetch_topic_context_dashboard passes all five query parameters (*args) to two SQL statements that reference only $1–$4; the fifth (external_only) is unused. asyncpg rejects the extra argument, so every non-external dashboard request fails. The mock-connection tests never bind real parameters, so CI stays green.
Prompt for agents
In _fetch_topic_context_dashboard (backend/app/operations_dashboard.py), both conn.fetchrow (the readiness query around line 393) and conn.fetch (the rows query around line 490) are called with *args, where args is the 5-element tuple built in fetch_operations_dashboard: (corporate_entity_ids, process_unit_ids, period_start, period_end, external_only). However, these two SQL statements only reference positional parameters $1 through $4 (via _visible_period_sql and authorized_model_scope); they never reference $5. asyncpg requires the number of passed arguments to exactly match the highest parameter referenced in the query, so passing 5 args to a 4-parameter query raises InterfaceError and the dashboard endpoint fails for every non-external request. Fix by passing only the first four arguments (e.g. *args[:4]) to both topic-context queries, since external_only is already handled by the caller before this function runs.
Was this helpful? React with 👍 or 👎 to provide feedback.
| join topic_activity_interval activity | ||
| on activity.topic_model_run_id = influence.topic_model_run_id | ||
| and activity.topic_index = influence.topic_index | ||
| and visible_post.occurred_at >= activity.valid_from | ||
| and visible_post.occurred_at < activity.valid_to |
There was a problem hiding this comment.
🔍 Influence rows dropped when no activity interval covers the post
The eligible CTE inner-joins topic_activity_interval on the post's occurred_at falling within [valid_from, valid_to). A post whose event time lands in a gap between intervals is silently dropped, so an authorized influential post never appears. Confirm the producer guarantees gap-free interval coverage.
Was this helpful? React with 👍 or 👎 to provide feedback.
| readiness = await conn.fetchrow( | ||
| f""" | ||
| with visible_post as ( | ||
| select post.post_id | ||
| from source_post post | ||
| where {visible_post_sql} | ||
| ) | ||
| select exists ( | ||
| select 1 | ||
| from topic_context_membership membership | ||
| join topic_model_run model | ||
| on model.topic_model_run_id = membership.topic_model_run_id | ||
| join analysis_run analysis on analysis.analysis_run_id = model.analysis_run_id | ||
| join analysis_run_scope scope on scope.analysis_run_id = analysis.analysis_run_id | ||
| join visible_post on visible_post.post_id = membership.source_post_id | ||
| where {authorized_model_scope} | ||
| ) as tepp_posterior_persisted, | ||
| exists ( | ||
| select 1 | ||
| from topic_post_context_influence influence | ||
| join topic_context_membership membership | ||
| on membership.topic_model_run_id = influence.topic_model_run_id | ||
| and membership.topic_context_membership_id = influence.topic_context_membership_id | ||
| join topic_model_run model | ||
| on model.topic_model_run_id = influence.topic_model_run_id | ||
| join analysis_run analysis on analysis.analysis_run_id = model.analysis_run_id | ||
| join analysis_run_scope scope on scope.analysis_run_id = analysis.analysis_run_id | ||
| join visible_post on visible_post.post_id = membership.source_post_id | ||
| where {authorized_model_scope} | ||
| ) as fast_mlsirm_influence_persisted | ||
| """, | ||
| *args, | ||
| ) |
There was a problem hiding this comment.
📝 Info: Readiness query runs even when unused
The readiness fetchrow executes on every non-external request, but its result is consumed only in the if not rows: branch. When accepted rows exist, it is a wasted round-trip; it could be deferred until rows is empty.
Was this helpful? React with 👍 or 👎 to provide feedback.
1 participant
Outcome
Verification
Upstream readiness
TEPP PR #247 defines the posterior envelope. fast-mlsirm PR #1395 is closed without merge and its topic-context endpoint remains explicitly unavailable, so production truthfully reports fast_mlsirm_influence_not_persisted rather than fabricating values.
Stacked on #640.