fix(ci): narrow static SQL scanner suppression - #648
Conversation
…ance' into feat/global-ask-knowledge-cutoff-current # Conflicts: # docs/product-technical-gap-baseline.md
…ance' into feat/global-ask-knowledge-cutoff-current
…ance' into feat/global-ask-knowledge-cutoff-current
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| rows = await conn.fetch( | ||
| "select post_id, post_title, voc_type_code, created_at, corporate_entity_id, " | ||
| "process_unit_id, thread_group_key, secondary_grouping_key " | ||
| f"from source_post where {SOURCE_POST_ELIGIBILITY_SQL.format(alias='source_post')}" |
There was a problem hiding this comment.
📝 Info: Inlined eligibility stays static
SOURCE_POST_ELIGIBILITY_SQL receives only the fixed alias before _load_lineage_records builds the query. No caller data enters the SQL string.
Was this helpful? React with 👍 or 👎 to provide feedback.
|
Superseded: the current #632 head already contains the reviewed static SQL constants and rule-specific documented suppressions at all affected asyncpg call sites. Closing this now-conflicting duplicate instead of restacking redundant code. |
1 participant
Narrows the #632 Semgrep repair to the exact false positive:
_LINEAGE_LANDING_SQLis a module constant assembled only from code-owned eligibility SQLnosemgrepat that call siteVerification: 58 focused tests passed;
semgrep --config p/python backend/app/lineage_ingestion.py --errorreports 0 findings.