fix(frontend): approve pnpm 11 esbuild build - #625
Conversation
|
Warning Review limit reachedNext included review available in 54 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Devin Review found 2 potential issues.
🐛 1 issue in files not directly in the diff
🐛 Docker image build still fails on esbuild approval
pnpm install --frozen-lockfile runs after only package.json and pnpm-lock.yaml are copied, before COPY . ., so the new pnpm-workspace.yaml granting esbuild build approval is absent at install time. pnpm 11's strict build policy still aborts the install, breaking the image build.
Root cause
Protected #623 moved the frontend to pnpm 11.24.0. pnpm 11 defaults
strictDepBuildsto true, so a clean install failed withERR_PNPM_IGNORED_BUILDSbecause esbuild's reviewed install script had no explicitallowBuildsentry.Change
allowBuildspolicy for the installedesbuilddependency onlyVerification
corepack pnpm --version-> 11.24.0CI=true corepack pnpm install --frozen-lockfile-> esbuild postinstall completedcorepack pnpm run lintcorepack pnpm run buildgit diff --checkReference: pnpm 11 Build Settings documents
allowBuildsas the explicit build-script allowlist andstrictDepBuildsas fail-closed by default: https://pnpm.io/settings/build