Skip to content

fix(frontend): approve pnpm 11 esbuild build - #625

Merged
seonghobae merged 1 commit into
mainfrom
fix/pnpm11-esbuild-build-policy
Aug 25, 2026
Merged

fix(frontend): approve pnpm 11 esbuild build#625
seonghobae merged 1 commit into
mainfrom
fix/pnpm11-esbuild-build-policy

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Root cause

Protected #623 moved the frontend to pnpm 11.24.0. pnpm 11 defaults strictDepBuilds to true, so a clean install failed with ERR_PNPM_IGNORED_BUILDS because esbuild's reviewed install script had no explicit allowBuilds entry.

Change

  • add the pnpm 11 project-local allowBuilds policy for the installed esbuild dependency only
  • remove the completed self-modifying Global Ask pnpm 9 repair workflow, which targeted an obsolete feature branch

Verification

  • corepack pnpm --version -> 11.24.0
  • clean CI=true corepack pnpm install --frozen-lockfile -> esbuild postinstall completed
  • corepack pnpm run lint
  • corepack pnpm run build
  • git diff --check

Reference: pnpm 11 Build Settings documents allowBuilds as the explicit build-script allowlist and strictDepBuilds as fail-closed by default: https://pnpm.io/settings/build


Open in Devin Review

@seonghobae
seonghobae enabled auto-merge (squash) August 25, 2026 12:09
@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 54 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ae1d0327-bbec-48a9-bfdd-2b24ee616f6d

📥 Commits

Reviewing files that changed from the base of the PR and between c8131a2 and 81d829c.

📒 Files selected for processing (2)
  • .github/workflows/repair-global-ask-pnpm-v2.yml
  • frontend/pnpm-workspace.yaml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 2 potential issues.

🐛 1 issue in files not directly in the diff

🐛 Docker image build still fails on esbuild approval

pnpm install --frozen-lockfile runs after only package.json and pnpm-lock.yaml are copied, before COPY . ., so the new pnpm-workspace.yaml granting esbuild build approval is absent at install time. pnpm 11's strict build policy still aborts the install, breaking the image build.

Open in Devin Review

Comment thread frontend/pnpm-workspace.yaml
@seonghobae
seonghobae merged commit 03721be into main Aug 25, 2026
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant