security: document fixed similar-VOC SQL fragment - #619
Merged
Conversation
|
Warning Review limit reachedNext included review available in 21 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
PR #614 safely interpolates only the repository-owned
SOURCE_POST_ELIGIBILITY_SQLwith the fixedpostalias; every request and identity value remains an asyncpg parameter. Semgrep cannot derive that provenance and reported the same false positive twice.This adds the existing narrow scanner annotation used by the other audited eligibility queries, beside an explicit trust-boundary explanation. It does not suppress any other rule or path.
The Global Ask candidate-membership repair was already delivered by merged PR #614 and is retained unchanged.
Verification
uv run --extra dev --extra backend pytest -q tests/test_global_ask_sources.py backend/tests/test_similar_voc_api.py tests/test_post_eligibility.py— 22 passedsemgrep --config p/python backend/app/main.py backend/app/post_chat_ingestion.py --error --metrics=off— 0 findings across 151 Python rulesgit diff --check origin/main...HEAD— passedFollow-up to #614 and code-scanning findings 234/235.