Skip to content

fix(lineage): clear stale focused graph during navigation - #612

Merged
seonghobae merged 9 commits into
mainfrom
codex/clear-stale-focused-lineage
Aug 25, 2026
Merged

fix(lineage): clear stale focused graph during navigation#612
seonghobae merged 9 commits into
mainfrom
codex/clear-stale-focused-lineage

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Outcome

Follow-up to protected #609: clears the previous focused graph immediately when the selected post changes, so a new post cannot briefly display the prior post’s isolation reason while its own authorized graph loads.

Verification

  • focused isolation regressions: 2 passed
  • frontend lint passed
  • production build passed

The explicit 15-second test budget accommodates the heavily contended local host; the test itself completed in seconds once its worker started.


Open in Devin Review

@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 22 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a30af70a-0878-4abc-8141-f4ded7cce2a2

📥 Commits

Reviewing files that changed from the base of the PR and between 3f47348 and 2c50d8b.

📒 Files selected for processing (5)
  • frontend/src/App.test.tsx
  • frontend/src/App.tsx
  • frontend/src/components/WorkspaceCalendar.tsx
  • frontend/src/focusedGraphSelection.test.ts
  • frontend/src/focusedGraphSelection.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae enabled auto-merge (squash) August 25, 2026 09:18
devin-ai-integration[bot]

This comment was marked as resolved.

@seonghobae

Copy link
Copy Markdown
Contributor Author

Exact-head 09204a4 keeps the focused graph null until the authorized per-post fetch resolves, so navigation shows the existing Loading lineage state instead of a transient global graph. The now-unused global graph fetch/state were deleted. Focused isolation tests, lint, and production build pass.

devin-ai-integration[bot]

This comment was marked as resolved.

@opencode-agent
opencode-agent Bot disabled auto-merge August 25, 2026 09:38
@seonghobae
seonghobae enabled auto-merge August 25, 2026 09:44
@opencode-agent
opencode-agent Bot disabled auto-merge August 25, 2026 09:59
@seonghobae
seonghobae enabled auto-merge (squash) August 25, 2026 10:11
devin-ai-integration[bot]

This comment was marked as resolved.

…as role=status

Its resolved empty/unavailable state carried role="status" like sibling
panels' transient loading text does, so mounting it inside the Board's
collapsed Advanced Review Tools details collided with every other status
region on the page (4 failing App.test.tsx assertions). RankingsPanel's
own resolved placeholders carry no ARIA role for the same reason -- only
the "Loading..." state announces.
devin-ai-integration[bot]

This comment was marked as resolved.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

Open in Devin Review

Comment thread frontend/src/App.tsx
@seonghobae
seonghobae merged commit 48f013a into main Aug 25, 2026
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant