Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/adr/0003-fast-mlsirm-report-integration.md
Original file line number Diff line number Diff line change
Expand Up @@ -104,12 +104,12 @@ than one large PR:
0182 / 0185): after IRT main effects, persist closest and farthest
post–criterion pairs from the residual leftover map, and name
unexplained leftover `U = R − R̂` and leftover-map cross share
`x = 2 R̂_c U_c / ²` of centered leftover when Gabriel coordinates
`x = 2 R̂ U / R²` of raw residual when Gabriel coordinates
exist so the identity remainder after two-axis reconstruction is not
read as leftover residual, leftover-map distance, explained leftover
share, or unexplained leftover share. Do not persist leftover-map
explained leftover share `e`, unexplained leftover share `s`, or
two-axis reconstruction `R̂`. Do not fork LSIRM; do not invent a
explained leftover share `e`, unexplained leftover share `s`, or any other
unsupported share alias in this slice. Do not fork LSIRM; do not invent a
leftover-pair API inside `fast-mlsirm` in this slice.
8. **Leftover-map axis-share slice** (ADR 0148): persist Gabriel inertia
`σ_k² / Σ_j σ_j²` of leftover-map axes 1 and 2 on the same residual
Expand Down
6 changes: 3 additions & 3 deletions docs/adr/0048-persist-lsirm-leftover-pairs.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,12 @@ leftover row also names unexplained leftover `U = R − R̂` when
Gabriel coordinates exist so the leftover cell the two-axis map does
not reconstruct is not read as leftover residual `R` or leftover-map
distance `d` (ADR 0182), and names leftover-map cross share
`x = 2 R̂_c U_c / ²` of centered leftover when Gabriel coordinates
`x = 2 R̂ U / R²` of raw residual when Gabriel coordinates
Comment thread
seonghobae marked this conversation as resolved.
exist so the identity remainder after two-axis reconstruction is not
read as leftover residual `R`, leftover-map distance `d`, explained
leftover share `e`, or unexplained leftover share `s` (ADR 0185).
Two-axis reconstruction `R̂` / `R̂_c` and centered unexplained leftover
`U_c` are computed internally and are not persisted.
This ADR does not add a persisted reconstruction column; persisting that
separate field requires its own accepted decision record.

Cascade the rows with `report_period_score`. A leftover post must
also be a `report_member_score` row, and the leftover criterion
Expand Down
2 changes: 1 addition & 1 deletion docs/adr/0049-leftover-pair-report-ui.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ explicitly names no leftover structure, and unexplained leftover names
"leftover map leaves unexplained `U` after IRT main effects; open this
post to read the named criterion" when present. When leftover-map cross
share is also present, the next action instead names the identity
remainder `x` two leftover-map axes leave of centered leftover after
remainder `x` two leftover-map axes leave in raw residual after
IRT main effects. A missing or non-finite value falls back in order —
cross share, then unexplained leftover, then the existing
closest/farthest next action. Clicking the button opens that post with
Expand Down
12 changes: 5 additions & 7 deletions migrations/0185_report_leftover_map_cross_share.sql
Original file line number Diff line number Diff line change
@@ -1,14 +1,12 @@
-- ADR 0185: persist leftover-map cross share x = 2 R̂_c U_c / R̃² of
-- the centered leftover after two-axis leftover-map reconstruction
-- (R̃ = R − center, R̂_c = ξ_{1:2} · ζ_{1:2}, U_c = R̃ − R̂_c).
-- Distance stays Euclidean leftover-map d. Centered leftover U_c and
-- reconstruction R̂_c are computed internally and are not persisted.
-- ADR 0185: persist leftover-map cross share x = 2 R̂ U / R² of raw
-- residual after two-axis leftover-map reconstruction
-- (R̂ = ξ_{1:2} · ζ_{1:2}, U = R − R̂). Distance stays Euclidean
-- leftover-map d. This migration adds only the cross-share column.
-- Upgrade column is nullable so older leftover rows keep distance and
-- residual without fabricating a share. This migration is the single
-- source of the column on fresh and existing installations. Do not
-- edit shipped migrations 0001 / 0012 after the fact. Do not persist
-- leftover_map_explained_share, leftover_map_unexplained_share,
-- leftover_map_unexplained, or leftover_map_reconstruction.
-- leftover_map_explained_share or leftover_map_unexplained_share.
Comment thread
seonghobae marked this conversation as resolved.
-- Do not add a nonnegative CHECK: x may be negative when reconstruction
-- and unexplained leftover have opposite signs.

Expand Down
Loading