-
Notifications
You must be signed in to change notification settings - Fork 1
fix(ui-ux): make analysis-run digest verification keyboard/touch accessible #557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -2527,7 +2527,7 @@ function analysisRunCorpusHint(run: AnalysisRun): string | null { | |||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||
| /** Git-style prefix. The full digest stays on `title` for verification. */ | ||||||||||||||||||||||||||||||||
| /** Git-style prefix. The full digest is behind a `<details>` disclosure for verification. */ | ||||||||||||||||||||||||||||||||
| const ANALYSIS_RUN_DIGEST_PREFIX_LENGTH = 12; | ||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||
| function analysisRunDigestPrefix(digest: string): string { | ||||||||||||||||||||||||||||||||
|
|
@@ -2606,17 +2606,20 @@ function AnalysisRunReproducibilityDigests({ | |||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||
| return ( | ||||||||||||||||||||||||||||||||
| <div role="group" aria-label="Analysis run reproducibility digests"> | ||||||||||||||||||||||||||||||||
| <p className="post-meta"> | ||||||||||||||||||||||||||||||||
| <div className="post-meta"> | ||||||||||||||||||||||||||||||||
| <span className="visually-hidden"> | ||||||||||||||||||||||||||||||||
| Hover a prefix to read the full digest for verification.{" "} | ||||||||||||||||||||||||||||||||
| Open a prefix to read the full digest for verification.{" "} | ||||||||||||||||||||||||||||||||
| </span> | ||||||||||||||||||||||||||||||||
| {parts.map((part, index) => ( | ||||||||||||||||||||||||||||||||
| <span key={part.label}> | ||||||||||||||||||||||||||||||||
| {index > 0 ? " · " : null} | ||||||||||||||||||||||||||||||||
| <span title={part.digest}>{`${part.label} ${analysisRunDigestPrefix(part.digest)}`}</span> | ||||||||||||||||||||||||||||||||
| <details className="analysis-run-digest"> | ||||||||||||||||||||||||||||||||
| <summary>{`${part.label} ${analysisRunDigestPrefix(part.digest)}`}</summary> | ||||||||||||||||||||||||||||||||
| {part.digest} | ||||||||||||||||||||||||||||||||
| </details> | ||||||||||||||||||||||||||||||||
| </span> | ||||||||||||||||||||||||||||||||
|
Comment on lines
2614
to
2620
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟡 Disclosure nested inside inline span Each
Suggested change
Was this helpful? React with 👍 or 👎 to provide feedback. |
||||||||||||||||||||||||||||||||
| ))} | ||||||||||||||||||||||||||||||||
| </p> | ||||||||||||||||||||||||||||||||
| </div> | ||||||||||||||||||||||||||||||||
| </div> | ||||||||||||||||||||||||||||||||
| ); | ||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 Info: Full digest now always present in DOM text
The full digest was previously only in the
titleattribute; it is now text inside the closed<details>, so it is always intextContent. The component is only mounted in the detail popup (AnalysisRunReproducibilityDigestsat frontend/src/App.tsx:2913), so the home-list negative assertion still holds. Updated tests click to reveal it.Was this helpful? React with 👍 or 👎 to provide feedback.