-
Notifications
You must be signed in to change notification settings - Fork 1
feat: land leftover pair clicks on the named Post quality criterion (v2.12.8) #485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
seonghobae
merged 15 commits into
main
from
feat/leftover-criterion-evaluation-landing-v2128
Aug 25, 2026
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
308b607
feat: land leftover pair clicks on the named Post quality criterion (…
seonghobae 15f287b
test: cover farthest leftover pair landing on Post quality
seonghobae 95a33d5
fix: restore PR 485 frontend contracts
seonghobae c2102f9
test(frontend): preserve OIDC return fallback on PR 485
seonghobae 216c960
fix(docs): renumber ADR 0125 collision and retire buyer wording
seonghobae f17a116
fix(frontend): expose leftover action to screen readers
seonghobae d0ebacc
Merge remote-tracking branch 'origin/main' into HEAD
seonghobae dcaa632
fix(ui-ux): land leftover-pair clicks on the clicked pair, not the fi…
seonghobae 37f200d
Merge branch 'main' into feat/leftover-criterion-evaluation-landing-v…
seonghobae 24c8e8d
Merge remote-tracking branch 'origin/main' into HEAD
seonghobae 5d8ee75
Merge origin/main into feat/leftover-criterion-evaluation-landing-v2128
seonghobae 1b00aa2
fix(leftover): render the ADR 0158 button next action; amend ADR 0049
seonghobae 66916c9
Merge remote-tracking branch 'origin/main' into HEAD
seonghobae 0291e89
Merge remote-tracking branch 'origin/main' into HEAD
seonghobae e4c2d17
fix(leftover): comparison-strip pairs land the criterion too
seonghobae File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| # 2.12.8 Leftover pair click lands Post quality on the named criterion | ||
|
|
||
| ## Changed | ||
|
|
||
| - Clicking a leftover closest/farthest pair now opens that post with the | ||
| leftover criterion current in Post quality (IRT): the heading is | ||
| focused, the named criterion row is `aria-current`, and the next action | ||
| names the leftover score to read (ADR 0158). Home-list and report-member | ||
| opens do not carry leftover focus. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| # ADR 0158 — Leftover pair click lands Post quality on the named criterion | ||
|
|
||
| **Decision status:** Accepted | ||
| **Date:** 2026-08-23 | ||
|
|
||
| ## Context | ||
|
|
||
| ADR 0049 puts closest and farthest leftover post–criterion pairs above | ||
| the period-report member list. Clicking a pair already opens that post. | ||
| The reader still has to hunt through Post quality (IRT) for the named | ||
| criterion. The leftover residual (Jeon et al., 2021, eq. 3; Gabriel | ||
| 1971 biplot) is a post–criterion fact, not a post-only fact. | ||
|
|
||
| Event Lineage landing (ADR 0078) already shows the pattern: the click | ||
| must name the next action and mark the current node. Leftover pairs | ||
| must not reuse the Event Lineage `fromReportMember` path. That path | ||
| reorders Keyman and evaluation under Event Lineage. A leftover click | ||
| is about the IRT leftover criterion, not about reconstructing the DAG. | ||
|
|
||
| ## Decision | ||
|
|
||
| Pass leftover focus with the leftover-pair click: `pair_kind` and | ||
| `criterion_code`. Opening the post: | ||
|
|
||
| 1. Focuses the **Post quality (IRT)** heading. | ||
| 2. Marks the leftover criterion row `aria-current="true"`. | ||
| 3. Shows a leftover-criterion next action under that heading: | ||
| “{criterion} is the leftover criterion this post sat closest to / | ||
| farthest from after main effects. Read that Post quality score next.” | ||
|
|
||
| The leftover-pair button next action is “Open this post so the leftover | ||
| criterion is current in Post quality.” Home-list and report-member opens | ||
| do not carry leftover focus, so they do not show leftover copy or mark | ||
| a criterion current. | ||
|
|
||
| Do not invent leftover scores. Do not persist a second theta. Do not mix | ||
| this landing into the leftover interaction-map stack (ADR 0121). | ||
|
|
||
| ## Consequences | ||
|
|
||
| `SelectPostOptions.fromLeftoverPair` is the only leftover-focus carrier. | ||
| Evaluation rows already returned by `GET /api/posts/{id}/evaluation` | ||
| are sufficient; no new API. Missing leftover rows still render nothing | ||
| (ADR 0049). A hidden post still never appears as a leftover pair. | ||
|
|
||
| ## Related | ||
|
|
||
| Depends on [ADR 0048](0048-persist-lsirm-leftover-pairs.md), | ||
| [ADR 0049](0049-leftover-pair-report-ui.md), and | ||
| [ADR 0003](0003-fast-mlsirm-report-integration.md). | ||
| Independent of leftover-map persistence on `feat/persist-lsirm-interaction-map-v2127`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.