-
Notifications
You must be signed in to change notification settings - Fork 1
feat: show corroborated SKOS companion on organization chips (v2.14.0) #482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
ea6cd18
feat: show corroborated SKOS companion on organization chips
seonghobae 94a9033
fix: reuse organization alias snapshot
seonghobae 74ac0cc
perf(voc): skip unused alias hydration
seonghobae 022caed
fix(auth): drop unrelated login redirect change
seonghobae 2bdba2d
fix: keep organization alias suffixes distinct
seonghobae 7fd3303
fix(a11y): include related chip caption in name
seonghobae 8735483
fix: bind organization aliases to catalog IDs
seonghobae de19b5b
fix(adr): resolve ADR 0119 number collision with the Buyer-terminolog…
seonghobae 0a5b24b
test(ui): bound full alias interaction scenario
seonghobae 0f998ce
fix(docs): restore dropped SKOS-companion paragraph in AGENTS.md
seonghobae e2dd3f6
fix(ui): suppress duplicate organization aliases
seonghobae File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| # 2.14.0 — Corroborated SKOS companion on organization chips | ||
|
|
||
| ## Added | ||
|
|
||
| - Affiliate-org, Keyman-affiliation, and counterparty-org chips show the other | ||
| search-corroborated SKOS label when it is unique (`Demo Corp (DC)`). Related | ||
| corporate nodes use that companion in place of the ontology class caption. | ||
| A miss, pending row, identical labels, or a tie stays unlabeled. | ||
| - `make seed` writes the synthetic `DC` / `Demo Corp` pair as | ||
| `verify_corroborated` so the parenthetical is clickable after seed. | ||
|
|
||
| ## References | ||
|
|
||
| Miles & Bechhofer (2009); ADR 0008; ADR 0170. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
seonghobae marked this conversation as resolved.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| # ADR 0170 — Corroborated SKOS companion labels appear on organization chips | ||
|
|
||
| **Decision status:** Accepted | ||
| **Date:** 2026-08-23 | ||
|
|
||
| ## Context | ||
|
|
||
| [ADR 0008](0008-organization-abbreviation-resolution.md) already persists a | ||
| search-corroborated `skos:altLabel` / `skos:prefLabel` pair (Miles & | ||
| Bechhofer, 2009) in `organization_name_resolution`. Catalog matching still | ||
| compares mentions to `corporate_entity.entity_name`, so a chip that only | ||
| prints that name hides the short form the source used. After seed, a buyer | ||
| who reads "DC" in a post cannot see that the Demo Corp chip is the same | ||
| organization. | ||
|
|
||
| Catalog creation and mention-to-catalog resolution remain a separate stack. | ||
| This record only decides the buyer-visible caption, but that caption must be | ||
| bound to the catalog id already carried by the chip. A display-name match alone | ||
| cannot prove identity because `corporate_entity.entity_name` is not unique. | ||
|
|
||
| ## Decision | ||
|
|
||
| 1. Load every `verify_corroborated` pair as `OrganizationNameAlias`, bound to a | ||
| target `corporate_entity_id` only when exactly one current catalog row has | ||
| either stored label. Pending and uncorroborated rows stay out. | ||
| 2. Attach the other label as `organization_alias` only when the pair's target | ||
| id equals the catalog id already stored on the displayed record. An unbound | ||
| record, catalog tie, id mismatch, name miss, identical labels, or two | ||
| distinct companions stays unlabeled. The product never invents an | ||
| abbreviation from letters. | ||
| 3. Render the chip as `Demo Corp (DC)` when a companion is present, otherwise | ||
| the catalog name. Affiliate-org, Keyman-affiliation, and counterparty-org | ||
| chips reuse the existing accessible-name keys with that caption. | ||
| Related corporate nodes use the companion in place of the ontology class | ||
| caption when one is present, and keep the ontology caption otherwise. | ||
| 4. Seed the synthetic pair `DC` / `Demo Corp` as `verify_corroborated` so the | ||
| walk is clickable after `make seed`. Real organization names must not | ||
| appear in fixtures. | ||
|
|
||
| ## Consequences | ||
|
|
||
| - The raw/canonical mapping remains in `organization_name_resolution` (3NF). | ||
| Chips project the companion at read time; they do not duplicate it onto | ||
| affiliation or counterparty rows, and a same-named catalog row cannot borrow | ||
| another row's alias. | ||
| - Default frontend tests stay on unlabeled names. A stub option supplies the | ||
| companion so the parenthetical is covered without changing the unlabeled | ||
| walk. | ||
| - Fail-closed on a tie matches ADR 0026's "do not guess" discipline for | ||
| organization identity. | ||
|
|
||
| ## Related | ||
|
|
||
| Extends [ADR 0008](0008-organization-abbreviation-resolution.md). Complements | ||
| [ADR 0002](0002-figma-access-boundary.md) chip presentation. Does not change | ||
| catalog create/lock policy in [ADR 0012](0012-corporate-entity-creation-lock.md) | ||
| or [ADR 0026](0026-tied-organization-similarity.md). | ||
|
|
||
| ## References (APA 7th) | ||
|
|
||
| Miles, A., & Bechhofer, S. (Eds.). (2009). *SKOS simple knowledge organization system reference*. World Wide Web Consortium. https://www.w3.org/TR/skos-reference/ |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.