-
Notifications
You must be signed in to change notification settings - Fork 1
chore: sync current #264 head into Ask Agent workspace #352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
seonghobae
wants to merge
14
commits into
feat/ask-agent-evidence-workspace-v2180
from
feat/event-lineage-node-keeps-gnb-focus-v2170
Closed
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
ef6f5a5
feat: enforce Korean UI standards on top of latest PR stack (#347)
seonghobae 0d827fc
fix: keep provider errors behind product boundaries
seonghobae d58edc8
fix: close provider error leaks at write endpoints
seonghobae 711f027
merge current main into #258
seonghobae 678df0d
fix: keep unauthenticated admin controls out of login
seonghobae abb99aa
merge concurrent provider error boundary fix
seonghobae 44e8dcf
fix: normalize unexpected provider failures
seonghobae 5158934
fix: normalize summary enrichment failures
seonghobae d58651e
Merge remote-tracking branch 'origin/feat/analysis-run-name-evidence-…
seonghobae 643338a
fix: remove unused locale return imports
seonghobae 8cd94b2
Merge remote-tracking branch 'origin/feat/board-weekly-voc-open-event…
seonghobae e3f4561
Merge current calendar stack and wire customer tree
seonghobae 5bd176c
Merge remote-tracking branch 'origin/feat/customer-master-open-focus-…
seonghobae 39f2126
Merge remote-tracking branch 'origin/feat/ask-agent-open-focus-event-…
seonghobae File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,80 @@ | ||
| name: Repair Global Ask pnpm provisioning deterministically | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
| push: | ||
| branches: | ||
| - "feat/global-ask-public-claim-verification-v2200" | ||
| paths: | ||
| - ".github/workflows/repair-global-ask-pnpm-v2.yml" | ||
|
|
||
| permissions: | ||
| contents: write | ||
|
|
||
| concurrency: | ||
| group: repair-global-ask-pnpm-v2200-v2 | ||
| cancel-in-progress: false | ||
|
|
||
| jobs: | ||
| repair: | ||
| name: Pin repository pnpm and re-arm product integration | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout exact feature branch | ||
| uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # actions/checkout@v7 | ||
| with: | ||
| ref: feat/global-ask-public-claim-verification-v2200 | ||
| fetch-depth: 0 | ||
| persist-credentials: true | ||
|
|
||
| - name: Repair only the package-manager provisioning boundary | ||
| shell: bash | ||
| run: | | ||
| python - <<'PY' | ||
| from pathlib import Path | ||
|
|
||
| workflow = Path('.github/workflows/apply-global-ask-public-verification-v2200.yml') | ||
| text = workflow.read_text(encoding='utf-8') | ||
|
|
||
| actor_guard = " github.event.pull_request.head.repo.full_name == github.repository &&\n github.actor != 'github-actions[bot]'" | ||
| if actor_guard in text: | ||
| text = text.replace( | ||
| actor_guard, | ||
| " github.event.pull_request.head.repo.full_name == github.repository", | ||
| 1, | ||
| ) | ||
|
|
||
| old_install = " corepack enable\n pnpm --dir frontend install --frozen-lockfile" | ||
| new_install = ( | ||
| " corepack enable\n" | ||
| " corepack prepare pnpm@9.15.9 --activate\n" | ||
| " test \"$(pnpm --version)\" = \"9.15.9\"\n" | ||
| " pnpm --dir frontend install --frozen-lockfile" | ||
| ) | ||
| if old_install in text: | ||
| text = text.replace(old_install, new_install, 1) | ||
| elif new_install not in text: | ||
| raise SystemExit('refusing to edit an unknown pnpm provisioning shape') | ||
|
|
||
| if "github.actor != 'github-actions[bot]'" in text: | ||
| raise SystemExit('actor guard remains after repair') | ||
| if new_install not in text: | ||
| raise SystemExit('pinned pnpm provisioning was not installed') | ||
|
|
||
| workflow.write_text(text, encoding='utf-8') | ||
| PY | ||
|
|
||
| - name: Remove repair-only workflows and publish the narrow repair | ||
| shell: bash | ||
| run: | | ||
| rm -f .github/workflows/repair-global-ask-pnpm.yml | ||
| rm .github/workflows/repair-global-ask-pnpm-v2.yml | ||
| git config user.name "github-actions[bot]" | ||
| git config user.email "41898282+github-actions[bot]@users.noreply.github.com" | ||
| git add -A .github/workflows | ||
| git diff --cached --check | ||
| if git diff --cached --quiet; then | ||
| exit 0 | ||
| fi | ||
| git commit -m "ci: pin Global Ask pnpm provisioning" | ||
| git push origin HEAD:feat/global-ask-public-claim-verification-v2200 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| # 2.12.6 — Validate buyer image sources | ||
|
|
||
| ## Fixed | ||
|
|
||
| - Buyer image rendering now rejects script, SVG, external, and malformed | ||
| source URLs before they reach an image element. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| ## Fixed | ||
|
|
||
| - Keep the unauthenticated login surface free of authenticated admin controls and remove unused OIDC imports so TypeScript production builds pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| # 2.12.6 — Bound OIDC deep-link state parsing | ||
|
|
||
| ## Fixed | ||
|
|
||
| - OIDC callback state is parsed at most once and length-bounded before JSON | ||
| handling, preventing recursive encoded state from exhausting the browser | ||
| stack while preserving safe same-origin post deep links. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| ## Fixed | ||
|
|
||
| - Keep contextual-orchestrator, OIDC, RankWeave, TEPP, and durable-ingestion diagnostics behind stable product error boundaries while retaining the original exception for server-side chaining. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| # Mixed table and paragraph indentation | ||
|
|
||
| ## Fixed | ||
|
|
||
| - Match persisted post units to their source text instead of using ordinal | ||
| position, so a table or embedded image cannot shift the fallback indentation | ||
| of a later unresolved paragraph. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| ## Preserve partial visual regions | ||
|
|
||
| - Retain valid salient image regions for panel-level OCR and search. | ||
| - Also analyze the parent image when locator coverage is partial so text outside | ||
| the returned panels remains searchable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| # Preserve adjacent source tables | ||
|
|
||
| ## Fixed | ||
|
|
||
| - Keep consecutive persisted rows in separate buyer-facing tables when the | ||
| source post contains more than one HTML table, preserving the authored table | ||
| boundary without changing source text or semantic row content. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| ## Fix source-only indentation depth | ||
|
|
||
| - Keep leading spaces and ` ` available as diagnostics without persisting | ||
| them as authoritative structure; only declared HTML/CSS/OOXML or list | ||
| nesting is explicit. | ||
| - Keep expected structure and embedding channel failures retryable while | ||
| propagating unexpected defects to the durable ingestion ledger. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| import re | ||
|
|
||
| with open("frontend/src/i18n.ts", "r") as f: | ||
| content = f.read() | ||
|
|
||
| translations = { | ||
| "Admin": { | ||
| "ko": "관리자", | ||
| "zh": "管理员", | ||
| "ja": "管理者", | ||
| "vi": "Quản trị viên" | ||
| }, | ||
| "Admin settings": { | ||
| "ko": "관리자 설정", | ||
| "zh": "管理员设置", | ||
| "ja": "管理者設定", | ||
| "vi": "Cài đặt quản trị viên" | ||
| }, | ||
| "Tenant brand name": { | ||
| "ko": "테넌트 브랜드명", | ||
| "zh": "租户品牌名称", | ||
| "ja": "テナントブランド名", | ||
| "vi": "Tên thương hiệu khách thuê" | ||
| }, | ||
| "Save settings": { | ||
| "ko": "설정 저장", | ||
| "zh": "保存设置", | ||
| "ja": "設定を保存", | ||
| "vi": "Lưu cài đặt" | ||
| }, | ||
| "Settings saved!": { | ||
| "ko": "설정이 저장되었습니다!", | ||
| "zh": "设置已保存!", | ||
| "ja": "設定が保存されました!", | ||
| "vi": "Đã lưu cài đặt!" | ||
| } | ||
| } | ||
|
|
||
| for eng, trans in translations.items(): | ||
| content = content.replace(f' Refresh: "새로 고침",', f' Refresh: "새로 고침",\n "{eng}": "{trans["ko"]}",') | ||
| content = content.replace(f' Refresh: "조회",', f' Refresh: "조회",\n "{eng}": "{trans["ko"]}",') | ||
|
|
||
| content = content.replace(f' Refresh: "刷新",', f' Refresh: "刷新",\n "{eng}": "{trans["zh"]}",') | ||
| content = content.replace(f' Refresh: "更新",', f' Refresh: "更新",\n "{eng}": "{trans["ja"]}",') | ||
| content = content.replace(f' Refresh: "Làm mới",', f' Refresh: "Làm mới",\n "{eng}": "{trans["vi"]}",') | ||
|
|
||
| with open("frontend/src/i18n.ts", "w") as f: | ||
| f.write(content) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟨 CI repair workflow strips a bot-actor guard from a privileged workflow
The new workflow rewrites
apply-global-ask-public-verification-v2200.ymlto delete thegithub.actor != 'github-actions[bot]'condition from a job guard, leaving only the same-repo check. The edited workflow runs withcontents: writeand pushes to a branch, so removing the bot-actor exclusion allows a github-actions[bot]-authored event to re-enter the privileged path, which can create automated push/re-trigger loops or let bot-generated commits drive privileged writes.Was this helpful? React with 👍 or 👎 to provide feedback.