-
Notifications
You must be signed in to change notification settings - Fork 1
fix(ui): keep pending next actions kind-specific and audible (v0.86.3) #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| Related-node walks include team and organization mention edges. Click an | ||
| R&R team to open sibling posts. Thread-group run lists honor knowledge_cutoff. | ||
| Failed period-report rows rebuild the report; a pending TEPP corpus | ||
| does not claim a calibrated measurement. | ||
| does not claim a calibrated measurement. Pending list copy is | ||
| kind-specific (ADR 0020). |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| Pending TEPP next-action copy does not say reconstruction. List | ||
| accessible names include the next-action sentence. Detail repeats it | ||
| (ADR 0020). |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,6 +4,16 @@ All notable changes to this project are documented here. Format follows | |
| [Keep a Changelog](https://keepachangelog.com/en/1.1.0/); versioning follows | ||
| [Semantic Versioning](https://semver.org/spec/v2.0.0.html). | ||
|
|
||
| ## [0.86.3] - 2026-08-16 | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 0.86.3 is not available for this slice. #145 already shipped v0.87.0 on the same base, and #153 claims 0.86.3 for person catalog ids. #148 recorded the kind-specific pending pin without a version bump. After rebase, bump only if the AccName-only remainder is what lands — do not republish the already-merged copy change as 0.86.3. |
||
|
|
||
| ### Fixed | ||
|
|
||
| - Pending analysis-run next actions are kind-specific. A pending TEPP | ||
| row tells the operator measurement has not started — it does not say | ||
| reconstruction. The list button accessible name includes that | ||
| sentence (WCAG 2.2 SC 4.1.2). Open the row: detail repeats it | ||
| (ADR 0020). | ||
|
|
||
| ## [0.86.2] - 2026-08-16 | ||
|
|
||
| ### Fixed | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| # ADR 0020 — Pending next actions stay kind-specific and audible | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This number is already taken on the same #74 base. #154 The pending-copy decision itself is the right buyer gap. Keep v0.86.3. Rename this file and every ADR 0020 citation in this PR to 0021. Do not steal v0.87.0 from #154.
cursor[bot] marked this conversation as resolved.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do not land this file. ADR 0020 on current |
||
|
|
||
| **Decision status:** Accepted on this active PR; not protected-main truth until merge | ||
| **Date:** 2026-08-16 | ||
| **Depends on:** ADR 0014 authorized analysis-run read; ADR 0017 authorized | ||
| analysis-run create | ||
| **Refs:** Merged #128 left pending copy kind-blind; #138 is the same | ||
| slice on `main` and must not be duplicated onto this #74 stack | ||
|
|
||
| ## Context | ||
|
|
||
| #128 pinned Failed next-action copy to the registered kinds | ||
| (`analysis_run_lineage`, `analysis_run_tepp`, `analysis_run_report`). | ||
| Pending rows still used one sentence: "Reconstruction has not started | ||
| yet." A Pending TEPP row therefore told the operator to wait for | ||
| reconstruction. The list button's `aria-label` also replaced the | ||
| visible next-action, so assistive technology only heard the caption | ||
| (W3C, 2018, 2023). | ||
|
|
||
| #142 owns in-process lineage start. This decision does not start a | ||
| run, invent a theta, or add Storybook. | ||
|
|
||
| ## Decision | ||
|
|
||
| - `analysisRunNextAction` switches on both `status_code` and | ||
| `run_kind_code`. Pending TEPP says measurement has not started and | ||
| is not a calibrated result. Pending report says the report has not | ||
| been built. Pending lineage keeps the reconstruction sentence. | ||
| - The list button accessible name is | ||
| `Open analysis run: {caption}. {nextAction}` when a next action | ||
| exists, otherwise the caption alone. | ||
| - Detail repeats the same next-action sentence after the title so | ||
| opening a Failed or Pending row still tells the operator what to do. | ||
| - Running, succeeded, and cancelled rows keep list next-action empty. | ||
| TEPP corpus copy already covers those states on detail. | ||
|
|
||
| ## Consequences | ||
|
|
||
| After `make seed`, open the Failed TEPP row: the list name includes | ||
| "connect the measurement service." Request a lineage reconstruction: | ||
| the Pending lineage row still says reconstruction has not started. | ||
| A Pending TEPP fixture must not say Reconstruction. | ||
|
|
||
| ## References — APA 7th | ||
|
|
||
| World Wide Web Consortium. (2018). *Accessible name and description | ||
| computation 1.1* (W3C Recommendation). | ||
| https://www.w3.org/TR/accname-1.1/ | ||
|
|
||
| World Wide Web Consortium. (2023). *Web content accessibility | ||
| guidelines (WCAG) 2.2* (W3C Recommendation). | ||
| https://www.w3.org/TR/WCAG22/ | ||
Uh oh!
There was an error while loading. Please reload this page.