security: bind special-purpose address decisions to reviewed IANA registry - #223
security: bind special-purpose address decisions to reviewed IANA registry#223seonghobae wants to merge 6 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review Please review exact head |
|
Please perform a fresh exact-head semantic review of |
Rate Limit Exceeded
|
|
@cwl-noema-review After a qualifying exact-head OpenCode verdict, independently review |
seonghobae
left a comment
There was a problem hiding this comment.
Current-head source review for 811ba846757adb44dfc648b9b13761aa1536a110 found no blocking defect in the five-file special-purpose registry compatibility scope. The implementation applies reviewed most-specific IANA global exceptions before broader non-global compatibility ranges, recursively classifies IPv4-mapped IPv6 through the underlying IPv4 policy, preserves the narrower local-development authority path, performs no runtime registry lookup, and keeps ordinary stdlib classification for addresses outside the bounded overlay. The documented overlay matches the current IANA registries last updated 2025-10-09, including the 2001::/23 exception structure and current 192.0.0.0/24 exceptions. This is author-side review evidence only, not independent approval. Keep Draft until corrected central Dependency Review and authoritative Strix evidence run on the unchanged head and qualifying independent review exists.
|
@cwl-noema-review review Review exact current head |
Purpose
Reconstruct the unique special-purpose IP registry compatibility delta from stale/diverged Draft #173 directly on exact protected
mainwithout transferring historical checks, reviews, approvals, base identity, or mergeability.Python's
ipaddressclassification tables evolve with interpreter maintenance releases, while EgressWeave supports a Python version matrix and must keep destination authorization stable. The current IANA IPv4 and IPv6 Special-Purpose Address Space registries remain the authoritative reviewed source for the bounded compatibility overlay.Exact identity and test-first lineage
7faf7a3b8a47980113982914000e724ab6a6cda5;8312a000197eabd7d7d3d7433f6341263c79f031;26be254deb11be6d5ff1bb10f35e9e70395b91be;811ba846757adb44dfc648b9b13761aa1536a110;74211307bf83d8089ca0c935a8a6664ca897ffce.Hosted RED run
31785513013failed on Python 3.10–3.14 exactly on the new compatibility contracts. The Python 3.14.6 lane reported 1,032 passing tests and 22 intended failures, demonstrating that the prior implementation depended on interpreter-versionis_private/is_globalmetadata.The final test/documentation correction accounts for
2001:2::/48being denied through the reviewed broader2001::/23implementation range rather than requiring a redundant source literal.Implemented boundary
2002::/16CPython compatibility decision, update procedure, and local-development non-widening contract.Exact-head verification
Exact head
811ba846757adb44dfc648b9b13761aa1536a110:94723408440skipped the actual pinned Dependency review step, so the aggregate green wrapper is not accepted as substantive supply-chain evidence;Authoritative registries:
Merge contract
Keep Draft. Do not merge until:
.github#897integrates and a fresh exact-head Security Scan executes the actual pinned Dependency Review action successfully;.github#965integrates and Strix provides authoritative exact-head evidence rather than unavailable, neutral, metadata-less, or mismatched evidence;Progresses #95. Supersedes #173; historical predecessor evidence is intentionally not transferred.