-
Notifications
You must be signed in to change notification settings - Fork 0
reliability(packaging): pin isolated PEP 517 backend #212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
seonghobae
wants to merge
3
commits into
main
Choose a base branch
from
reliability/pin-pep517-build-backend-main-7faf
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+31
−1
Draft
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| """Regression contracts for isolated PEP 517 build-tool identity.""" | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| from pathlib import Path | ||
|
|
||
| try: | ||
| import tomllib | ||
| except ModuleNotFoundError: # pragma: no cover - Python 3.10 compatibility | ||
| import tomli as tomllib | ||
|
|
||
| REPOSITORY_ROOT = Path(__file__).resolve().parents[1] | ||
| PYPROJECT_PATH = REPOSITORY_ROOT / "pyproject.toml" | ||
| RELEASE_REQUIREMENTS_PATH = REPOSITORY_ROOT / "requirements-release.txt" | ||
| REVIEWED_HATCHLING_VERSION = "1.31.0" | ||
|
|
||
|
|
||
| def test_pep517_build_isolation_uses_the_reviewed_hatchling_version() -> None: | ||
| """Keep isolated source builds on the same reviewed backend as release builds.""" | ||
| with PYPROJECT_PATH.open("rb") as pyproject_file: | ||
| build_system = tomllib.load(pyproject_file)["build-system"] | ||
|
|
||
| assert build_system["build-backend"] == "hatchling.build" | ||
| assert build_system["requires"] == [f"hatchling=={REVIEWED_HATCHLING_VERSION}"] | ||
|
|
||
| release_requirements = RELEASE_REQUIREMENTS_PATH.read_text(encoding="utf-8") | ||
| assert f"hatchling-{REVIEWED_HATCHLING_VERSION}-py3-none-any.whl" in release_requirements |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔒 Security & Privacy | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
Repository: ContextualWisdomLab/EgressWeave
Length of output: 39007
🏁 Script executed:
Repository: ContextualWisdomLab/EgressWeave
Length of output: 43425
Dependency Review 결과를 완료한 뒤 병합하세요.
Dependency Review가skipped이면 이 변경을 병합하지 마세요. 보호된main에 repair를 통합한 뒤, 변경되지 않은 exact PR head에서 fresh Security Scan을 실행하세요.hatchling==1.31.0과 모든 transitive build dependencies를 검토하고 결과를 기록하세요.🤖 Prompt for AI Agents
Source: Learnings