security(evidence): bound versioned authority schema - #208
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthrough
Changesauthority 검증 강화
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related issues
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review Review exact current head |
Rate Limit Exceeded
|
seonghobae
left a comment
There was a problem hiding this comment.
Current-head source review for b44d414234e36966960730b2767e439b2b771dc0 found no blocking defect in the four-file decision-evidence schema scope. The final pattern now rejects the same dot-compacted 0x legacy authority class as runtime, including 0x7f.0.0.1 and 0.x7f, while preserving lowercase IDNA/ASCII hostname labels, the 253-byte hostname ceiling, TCP ports 1..65535, and every existing URL, credential, path and IP-literal exclusion. Independent packaged-schema parity, detached-loader behavior, buyer documentation, Python 3.10–3.14 package acceptance, 1,028 tests and exact 100% production statement/branch coverage are current-head green. This is author-side review evidence only, not independent approval. Keep Draft until exact-head SAST/Security are terminal and the corrected central Dependency Review/Strix paths plus qualifying independent review are protected and current.
|
@cwl-noema-review review Review exact current head |
Purpose
Tighten the public decision-evidence JSON Schema so externally supplied evidence cannot be schema-valid while carrying authority material that EgressWeave runtime can never emit. The contract rejects URL syntax, credentials, paths, IP literals, legacy numeric-IP spellings, non-canonical hostnames, and invalid TCP ports while preserving the exact lowercase IDNA/ASCII hostname-plus-port shape emitted by runtime evidence.
This is a provider-neutral interoperability/privacy and data-integrity boundary for SIEM/GRC/naruon/MSA consumers. It does not change outbound request authorization, DNS resolution, TLS identity, transport behavior, credentials, persistence, logging, or release authority.
Exact identity and immutable TDD lineage
7faf7a3b8a47980113982914000e724ab6a6cda5;31dd5459e641482ef356946222eff0aded622b21;88a13f42383cfdb470926ffeb6770c467b12e498;6a76112ec4baa1aa3b53c867601225d902a17b3b;29bf77cca9f8248844b35b103d1f400f8729582c;b9a263bf78e17e4be44cf650651bd94cf4133b2c;b44d414234e36966960730b2767e439b2b771dc0;docs/decision-evidence.md, the packaged v1 schema, and two focused schema contract test modules.Newly repaired parity defect
Runtime
_looks_like_ip_literal(...)removes dots and rejects every normalized hostname whose compact form starts with0x. The prior public schema rejected only an undotted0x[0-9a-f]+authority. Dotted legacy spellings such as0x7f.0.0.1:443and0.x7f:443could therefore remain schema-valid even though runtime evidence can never emit them.The new immutable RED head
6a76112e...changed tests only. Hosted CI run31878046079reproduced the defect across Python 3.10–3.14. The Python 3.14.7 lane reported exactly1 failed, 1027 passed; the failing assertion showed that0x7f.0.0.1:443matched the prior pattern.The narrow repair:
0xhostname class as runtime, including dotted variants;1..65535, and every existing URL/path/credential/IP-literal rejection;Exact-current-head verification
On unchanged final head
b44d414234e36966960730b2767e439b2b771dc0:31878368823: completed success;1028 passed;1758/1758statements and588/588branches, zero misses or partials, 100%;Remaining central prerequisites
ContextualWisdomLab/.github#840so review-agent dispatch uses a bounded GitHub-compatible envelope and durable dispatch is not falsely failed by optional reaction telemetry.ContextualWisdomLab/.github#1009and require authoritative exact-head structured Strix evidence.ContextualWisdomLab/.github#897, then rerun this unchanged accepted tree and require the actual immutable-pinned Dependency Review action to execute and succeed rather than being skipped.Keep Draft. Merge only the unchanged accepted tree through normal protected governance. Do not self-approve, bypass protections, synthesize status/review evidence, or infer acceptance from wrapper-green, skipped, queued, stale, or predecessor evidence.