security(response): require exact response stream bytes - #200
Conversation
|
Warning Review limit reached
Next review available in: 53 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
|
|
@coderabbitai review Review exact current head |
Rate Limit Exceeded
|
seonghobae
left a comment
There was a problem hiding this comment.
Current-head source review for 0cb76cf32c59263f7cd1c9f01e2f01aa2689f4ed found no blocking defect in the response-stream exact-byte boundary. Both sync and async wrappers require exact built-in bytes before invoking polymorphic length behavior, route rejection through deterministic source cleanup and the stable generic denial, and retain ordinary exact-byte streaming within the finite response budget. This is author-side review evidence only, not independent approval. Keep Draft until fresh corrected Dependency Review and authoritative Strix evidence run on the unchanged head and an independent current-head review is present.
Purpose
Repair a finite-response accounting defect at the private HTTPX/HTTPCore stream boundary. Protected
mainhistorically countedlen(chunk)before requiring the response chunk to be exact built-inbytes. Abytessubclass could override__len__and under-report its real payload, allowing the bounded stream wrapper to yield more thanmax_response_bytes.This is a dependency-shape/resource-integrity boundary, not a claim that the pinned HTTPCore version emits hostile chunks or that EgressWeave sandboxes arbitrary in-process Python.
Test-first lineage and current implementation
7faf7a3b8a47980113982914000e724ab6a6cda5;0cb76cf32c59263f7cd1c9f01e2f01aa2689f4ed;bytessubclass whose__len__falsely returned zero while the underlying payload exceeded the policy budget;type(chunk) is bytesbefore length accounting in both synchronous and asynchronous response wrappers;Focused/full CI, Python 3.10–3.14 (including 3.14), package build, exact coverage evidence, SAST, CodeQL, Trivy and OSV are green on this exact head. No formal reviews or unresolved review threads exist on the exact head.
Current non-passing acceptance evidence
Keep this PR Draft. Do not merge or treat aggregate wrapper success as acceptance yet:
31616059331is wrapper-green, but its exact-headdependency-reviewjob94179036000skipped the actualDependency reviewaction. Skipped required supply-chain evidence is non-passing. The root fix is separately governed in read-only central PRContextualWisdomLab/.github#897; do not replace it with a weaker EgressWeave-local gate or churn this clean head.94179030638concluded success only after warningStrix backend unavailable; no vulnerability report was produced. Under EgressWeave release/merge evidence semantics, that infrastructure-neutral result is not a passing semantic security review.Acceptance criteria
byteschunk.bytesbefore response-byte accounting in sync and async wrappers.Dependency reviewaction executes and succeeds.