Skip to content

test(security): reproduce response-driven cookie persistence - #193

Draft
seonghobae wants to merge 8 commits into
fix/public-client-default-headers-current-mainfrom
security/stateless-response-cookies-current-main
Draft

test(security): reproduce response-driven cookie persistence#193
seonghobae wants to merge 8 commits into
fix/public-client-default-headers-current-mainfrom
security/stateless-response-cookies-current-main

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Purpose

Close issue #134's response-driven cookie-state boundary without weakening explicit caller-owned cookie support. This PR remains intentionally stacked on #195 because the pinned public client must first stop self-denying HTTPX's ambient Connection default.

Exact current stack identity

Historical checks, reviews, comments, and generated merge revisions from earlier #193 or #195 heads are non-transferable.

Test-first security result

The regression proves that response-provided Set-Cookie remains visible to the caller without becoming ambient state on later requests from the same sync or async public client. The implemented narrow boundary uses a caller-owned CookieJar policy that rejects response-driven insertion while continuing to permit explicit caller cookie state. Exact (hostname, port) authorization and existing method, framing, redirect, proxy, Unix-socket, TLS, DNS, request/response resource and cleanup boundaries remain unchanged.

The current stack also preserves #195's removal of only HTTPX's ambient Connection default. Caller-supplied hop-by-hop fields remain subject to the existing fail-closed transport validator.

Exact-head evidence

On unchanged c2d3a004aaac06c570f32b6bca2d4ecb58452285:

  • CI run 31590185081: completed success;
  • no formal reviews existed at the last exact-head refetch;
  • no unresolved review threads existed at the last exact-head refetch.

Because this is a non-default-base stacked Draft, this evidence is not merge authority and does not transfer after predecessor integration, retargeting, or any head movement.

Remaining acceptance

  1. fix(reliability): remove ambient HTTPX Connection default #195 must reach protected main under its own exact-head/security/supply-chain/review gates.
  2. Re-resolve protected main, retarget/reconstruct test(security): reproduce response-driven cookie persistence #193 non-destructively if needed, and regenerate every applicable CI/security/supply-chain/review gate on the resulting exact head.
  3. Resolve only current valid findings; do not count predecessor, status-only, skipped, neutral, queued, rate-limited, wrapper-green, or model-only evidence as acceptance.
  4. Merge only the unchanged accepted tree when live EgressWeave/CWL governance permits it.

Progresses #134; depends on #195.

@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c1f8c7fa-8295-4aff-a256-8b8e9f264378

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae changed the base branch from main to fix/public-client-default-headers-current-main August 12, 2026 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant