security: reconstruct scalar integer sealing on current main - #153
security: reconstruct scalar integer sealing on current main#153seonghobae wants to merge 7 commits into
Conversation
|
Warning Review limit reached
Next review available in: 37 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough정책 정규화가 포트와 리소스 제한 필드에서 Changes정책 정수 입력 무결성
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related issues
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/test_policy_integer_value_types.py`:
- Around line 16-63: Extend the integer-subclass rejection and
exact-integer/ASCII-decimal-string acceptance matrices in
test_policy_rejects_integer_subclass_for_resource_limits and
test_policy_keeps_exact_integer_and_decimal_string_configuration to cover
max_response_header_fields, max_response_bytes, max_response_header_bytes,
max_request_header_bytes, and max_request_target_bytes. Add corresponding
EgressPolicy.from_authorities tests covering rejection of _PolicyIntegerSubclass
ports and equivalence of exact integer versus ASCII decimal-string ports,
preserving the existing assertions on normalized int values.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: e5f54442-382d-4bd9-959a-c75724726b43
📒 Files selected for processing (4)
CHANGELOG.mddocs/research/policy-configuration-integrity.mdsrc/egressweave/_policy_normalization.pytests/test_policy_integer_value_types.py
|
@coderabbitai review |
|
Superseded by integrated-main reconstruction
This historical reconstruction is closed without merge because protected
mainadvanced from its based3498ec9455bfd3f3bb7df78c914de0a5d1120fctodd0324c0d7edb6effc74737039d1e754af09f5aaafter the candidate was built.Ready PR #159 preserves the scalar-integer boundary, full public-constructor regression coverage, canonical guidance and release history on the exact integrated base. Its current exact head is
e80f83da3a22321e4fc013a05b3d94591dc304c0; CI31445427241and SAST31445427240are green with exact 100% owned production statement/branch coverage. Security Scan31445427209still has the actual pinnedDependency reviewstep skipped, so #159 is not merge-ready until the read-only central dependency-review repair is integrated and the unchanged head is revalidated.Historical evidence in this PR remains audit history; no check, review, approval, base identity or mergeability transfers to #159. Its former successor #154 must be reconstructed on the new predecessor rather than inheriting this stale stack.